371 Commits

• Invoke RevertResult on parent DHO when nested DHO is reverted

  The behaviour described above was removed in
  812a4b412a, thus henceforth
  contradicting `RevertResult`'s xmldoc. As it is relied on by some
  external rulesets, bring it back to unbreak them.

  Bartłomiej Dach · 2023-04-11 18:29:08 +02:00
  db86ced4b4
• Merge branch 'master' into revert-result-in-playfield
  Bartłomiej Dach · 2023-02-16 21:54:29 +01:00
  3ee046000e
• Merge branch 'master' into maximum-judgement-offset-in-hit-object
  Dean Herbert · 2023-02-15 14:48:15 +09:00
  da8ab7143b
• Move taiko-specific property out of DrawableHitObject
  Dean Herbert · 2023-02-12 16:09:28 +09:00
  9d09141ab7
• Change snapping to only apply to classic mod
  Dean Herbert · 2023-02-09 18:22:14 +09:00
  34d1890f1c
• Store RawTime in JudgementResult
  ekrctb · 2023-02-09 17:15:37 +09:00
  258de3b2d8
• Merge branch 'maximum-judgement-offset-in-hit-object' into revert-result-in-playfield
  ekrctb · 2023-02-09 16:47:58 +09:00
  5f0636c330
• Refactor SkinnableSound.Samples to be non-nullable
  Dean Herbert · 2023-01-27 19:32:30 +09:00
  74ab036f3e
• Store Result.TimeAbsolute separately from offset

  Calculating from TimeOffset is bad because it loses precision.
  The result time won't change anymore
  even If `HitObject.GetEndTime()` changes later.

  ekrctb · 2023-01-24 15:35:06 +09:00
  efef97d5be
• Move MaximumJudgementOffset to HitObject

  We want to access this property for computing lifetime

  ekrctb · 2023-01-19 21:23:55 +09:00
  11e1b22bf5
• Move judgement result revert logic to Playfield

  Previously, some judgement results were not reverted
  when the source DHO is not alive (e.g. frames skipped in editor).
  Now, all results are reverted in the exact reverse order.

  ekrctb · 2023-01-19 19:57:13 +09:00
  812a4b412a
• Use new ArgumentNullException.ThrowIfNull throw-helper API
  Berkan Diler · 2022-12-22 21:27:59 +01:00
  08d2fbeb8e
• Rename method
  Bartłomiej Dach · 2022-11-30 22:54:14 +01:00
  2e19e93036
• Update state based on result during LoadComplete
  Derrick Timmermans · 2022-11-27 20:57:00 +01:00
  cff3e06ad6
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Merge branch 'master' into combo-colour-brightness-limit
  Dean Herbert · 2022-11-11 18:24:39 +09:00
  106f1cf90b
• Move gameplay configuration to interface to allow editor overriding
  Dean Herbert · 2022-11-08 18:25:24 +09:00
  dd4cd3cf8e
• Move major barline portion to default implementation to allow for further customisation

  Of note, this removes the "major" barline triangles from legacy skins. I
  think this is more correct, as they did not display in stable.

  Dean Herbert · 2022-11-07 14:29:58 +09:00
  c69a4f9333
• Remove unused bindable
  Dean Herbert · 2022-11-06 23:34:04 +09:00
  51078bddf9
• Fix test failures and rename configuration value to match better
  Dean Herbert · 2022-11-02 18:15:18 +09:00
  3ec9686e58
• Change range to 0-100% and rename to "normalisation"
  Dean Herbert · 2022-11-02 13:47:11 +09:00
  99ba7c29dd
• Remove toggle and change method of application to blend with original colour
  Dean Herbert · 2022-11-02 13:08:29 +09:00
  2f3c80f884
• Merge branch 'master' into combo-colour-brightness-limit
  Dean Herbert · 2022-11-02 12:09:27 +09:00
  a01602e63c
• Fix DrawableHitObject.AccentColour not being updated if object entry is not attached
  Dean Herbert · 2022-11-01 19:34:53 +09:00
  f014acfc8d
• Merge branch 'master' into combo-colour-brightness-limit
  Dean Herbert · 2022-11-01 17:50:26 +09:00
  27af91003b
• Remove various simple obsoletions
  Dean Herbert · 2022-10-28 13:20:58 +09:00
  42eafe318c
• Allow combo colour normalisation to be disabled
  Dan Balasescu · 2022-10-14 14:37:24 +09:00
  8a88339e78
• Extract to struct, add dictionary term
  Dan Balasescu · 2022-10-14 14:12:53 +09:00
  15db65c037
• Limit minimum brightness of combo colours
  Dan Balasescu · 2022-10-13 14:05:33 +09:00
  4149235e63
• Clamp LifetimeStart of HitObject's to their judgement windows
  sw1tchbl4d3 · 2022-09-27 16:54:24 +02:00
  0cffbb7562
• Improve exception when attempting to call DrawableHitObject.ClearInternal
  Dean Herbert · 2022-09-22 14:44:03 +09:00
  78625fda7d
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Fix toggling hit animations on the editor not applying immediately
  Dean Herbert · 2022-05-12 17:36:35 +09:00
  10e41d018a
• Fix missed identifier typos
  Joseph Madamba · 2022-01-12 15:46:20 -08:00
  5185f6010e
• Code refactor and name changes

  cleaned code up with Jetbrains i hope it suffices

  mk-56 · 2021-12-17 13:16:06 +01:00
  fd5af1fbe7
• Merge remote-tracking branch 'origin/positional-sounds-strength-adjustment' into positional-sounds-strength-adjustment
  mk-56 · 2021-11-28 14:21:26 +01:00
  cd095b5f7d
• Fix
  mk-56 · 2021-11-28 14:12:39 +01:00
  9c42cc0c05
• Fix
  mk-56 · 2021-11-28 14:09:30 +01:00
  9065179c52
• Fixed the problems that were brought up and deleted the old bind logic
  mk-56 · 2021-11-28 14:06:53 +01:00
  c3fb793762
• Binding logic fix, nullification of unnecessary path
  mk-56 · 2021-11-28 03:25:11 +01:00
  e83115ad5e
• Initial implementation of adjustable positional hitobject audio strength
  mk-56 · 2021-11-28 02:58:08 +01:00
  eaa464e548
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Always initialize DHO transforms on LoadComplete

  With the previous commit, the transform application is skipped when the state is already changed. But it turns out the previous commit breaks slider animation in the standard editor. This is probably due to the transforms are applied before nested hit objects are added.

  ekrctb · 2021-08-10 16:34:38 +09:00
  c63dfa21e1
• Fix DHO state is overwritten to Idle on LoadComplete

  The state may already be changed before `LoadComplete` is called because DHO is already added to the draw hierarchy.

  ekrctb · 2021-08-06 19:58:46 +09:00
  f262f288fc
• Also update colours once on DrawableHitObject
  Salman Ahmed · 2021-07-23 07:32:56 +03:00
  0b3b9e35ba
• Add ComboIndexWithOffsetsBindable and bind similar to ComboIndexBindable
  Salman Ahmed · 2021-07-22 16:40:33 +03:00
  523c154f15
• Merge branch 'master' into refactor-combo-colour-retrieval
  Salman Ahmed · 2021-07-20 10:08:25 +03:00
  1af230c48c
• Remove redundant arguments
  PercyDan54 · 2021-07-05 23:52:39 +08:00
  e1c646b9b2
• Allow setting Entry of PoolableDrawableWithLifetime

  It is more convenient than using the constructor because the only limited kind of expression is allowed in a base constructor call.
  Also, the object initializer syntax can be used.

  ekrctb · 2021-06-16 16:00:08 +09:00
  117e94bc94
• Add missing CurrentSkin null check in DHO disposal
  Bartłomiej Dach · 2021-06-11 09:18:58 +02:00
  296761ade5