1
0
mirror of https://github.com/ppy/osu.git synced 2025-02-06 23:53:00 +08:00
Commit Graph

70863 Commits

Author SHA1 Message Date
danielthirtle
072b3b20ab make inspect code happy 2025-01-08 02:11:17 +13:00
danielthirtle
09f6889eae code cleanup 2025-01-08 01:51:32 +13:00
danielthirtle
6b492b2bb0 use aimNoSliders for sliderbreak factor 2025-01-01 01:57:42 +13:00
TextAdventurer12
2f886e78c9 scale sliderbreaks with combo 2024-12-29 12:53:55 +13:00
TextAdventurer12
845459b767 refactor to remove unnecesary calculation and need for new tuple 2024-12-27 22:58:44 +13:00
TextAdventurer12
4ff5ea13b4 Merge branch 'pp-dev' into match-my-freak-sliders 2024-12-27 22:45:44 +13:00
James Wilson
3ddeaf8460
Use lastAngle when nerfing repeated angles on acute bonus (#31245)
* Use `lastAngle` when nerfing repeated angles on acute bonus

* Bump acute multiplier

* Correct outdated wiggle bonus comment

* Update test

---------

Co-authored-by: StanR <hi@stanr.info>
2024-12-24 12:43:44 +03:00
danielthirtle
081e9ae8ef make code inspector happy + cleanup 2024-12-22 17:30:30 +13:00
danielthirtle
b0059d6f7a Merge branch 'pp-dev' into match-my-freak-sliders 2024-12-22 17:01:11 +13:00
danielthirtle
3e5f319c75 use countMiss instead of effectiveMissCount as the base for sliderbreaks 2024-12-22 16:54:15 +13:00
danielthirtle
966efedf0b cap sliderbreak count at count100 + count50 2024-12-22 16:53:06 +13:00
StanR
6808a5a77c
Change slider drop penalty to use actual number of difficult sliders, fix slider drop penalty being too lenient (#31055)
* Change slider drop penalty to use actual number of difficult sliders, fix slider nerf being too lenient

* Move cubing to performance calculation

* Add separate list for slider strains

* Rename difficulty atttribute

* Rename attribute in perfcalc

* Check if AimDifficultSliderCount is more than 0, code quality fixes

* Add `AimDifficultSliderCount` to the list of databased attributes

* Code quality

---------

Co-authored-by: James Wilson <tsunyoku@gmail.com>
2024-12-21 23:45:29 +00:00
danielthirtle
e0019c46a5 scale misscount by proportion of difficult sliders 2024-12-22 04:03:52 +13:00
Jay Lawton
f6a36f7b2e
Implement Reading Skill into osu!taiko (#31208) 2024-12-21 13:19:14 +03:00
StanR
f722f94f26
Simplify osu! high-bpm acute angle jumps bonus (#30902)
* Simplify osu! high-bpm acute angle jumps bonus

* Add aim wiggle bonus

* Add hitwindow-based aim velocity decrease

* Revert "Add hitwindow-based aim velocity decrease"

This reverts commit bcebe9662c.

* Move wiggle multiplier to a const, slightly decrease acute bonus multiplier

* Make sure the previous object in the wiggle bonus is also part of the wiggle

* Scale the wiggle bonus multiplayer down

* Increase the acute angle jump bonus multiplier

* Make wiggle bonus only apply on >150 bpm streams, make repetitive angle penalty

* Reduce wiggle bonus multiplier to not break velocity>difficulty relation

* Adjust wiggle falloff function to fix stability issues

* Adjust wiggle consts

* Update tests
2024-12-20 23:32:51 +00:00
Jay Lawton
d8c3d899eb
remove particular condition on convert nerf (#31196)
Co-authored-by: James Wilson <tsunyoku@gmail.com>
2024-12-19 17:22:16 +00:00
Jay Lawton
ecd6b41928
Increase accscalingshift and include countok in hit proportion (#31195)
* revert acc scaling shift to previous values

* increase variance in accuracy values across od

* move return values, move nullcheck into return

---------

Co-authored-by: James Wilson <tsunyoku@gmail.com>
2024-12-19 14:45:11 +00:00
Jay Lawton
4ca88ae2d6
Refactor TaikoDifficultyCalculator and add DifficultStrain attributes (#31191)
* refactor + countdifficultstrain

* norm in utils

* adjust scaling shift

* fix comment

* revert all value changes

* add the else back

* remove cds comments
2024-12-19 11:32:59 +00:00
YaniFR
0f2f25db53
Adjust DifficultyValue curve to avoid lower star rating of osu!taiko being too inflated (#31067)
* low sr

* merge two line

* update decimal

* fix formatting

---------

Co-authored-by: StanR <hi@stanr.info>
2024-12-18 21:11:51 +03:00
Jay Lawton
79a3afe06f
Implement considerations for Relax within osu!taiko diffcalc (#30591) 2024-12-18 18:16:27 +03:00
Dan Balasescu
d54238240a
Merge pull request #31156 from frenzibyte/mobile-delayed-resume-overlay
Use time-based resume overlay when playing osu! on touchscreen
2024-12-18 15:25:10 +09:00
Salman Alshamrani
4bf90a5571 Use time-based resume overlay when playing osu! on touchscreen 2024-12-16 08:24:22 -05:00
Bartłomiej Dach
d72a0b04b8
Merge pull request #31084 from NicholasChin28/mania-profile-overlay-tooltip
Add missing mania tooltip overlay for 4k and 7k
2024-12-16 14:22:41 +09:00
Bartłomiej Dach
8a2f161619
Merge pull request #31139 from peppy/settings-sensitivity
Expose high precision mouse toggle when searching for "sensitivity" and other keywords
2024-12-16 13:40:32 +09:00
Bartłomiej Dach
9652c5a7ca
Merge pull request #31110 from peppy/timing-current-point-indicator
Change the way "current" points are hinted on timing screen
2024-12-16 13:27:06 +09:00
Bartłomiej Dach
ecb7a809f2
Revert "Fix text anchor for mania tooltip"
This reverts commit c0b6e784a5.

The change affects editor and other stuff and I'm not sure it's correct.
It's not like client needs to match the appearance really. It already
doesn't in many places.
2024-12-16 13:18:47 +09:00
Bartłomiej Dach
cfdb959cf6
Split actual methods & fix completely broken localisation
Localisable strings cannot be plainly interpolated or joined. That is a
lossy operation that loses data.
2024-12-16 13:16:52 +09:00
Bartłomiej Dach
8d1d026f56
Clean up model
- Properly annotate things as nullable
- Remove weird passthrough property (more on that later)
2024-12-16 13:14:21 +09:00
Dean Herbert
a8948628e6
Expose high precision mouse toggle when searching for "sensitivity" and other keywords 2024-12-16 13:12:21 +09:00
Bartłomiej Dach
573d709fae
Merge pull request #31109 from peppy/fix-editor-timing-undo-redo
Fix adjusting control point offset after undo/redo causing catastrophic failure
2024-12-16 12:40:22 +09:00
Bartłomiej Dach
98e8d0b497
Merge branch 'master' into timing-current-point-indicator 2024-12-16 12:22:14 +09:00
Bartłomiej Dach
1058abb4ab
Fix code quality 2024-12-16 12:22:06 +09:00
Nicholas Chin
e2edd9e0d5 Fix code quality issues 2024-12-15 13:53:33 +08:00
Nicholas Chin
153e6c0c22 Use Count comparison instead of Any 2024-12-14 08:29:32 +08:00
Dean Herbert
c93b6dba2b
Merge pull request #31108 from peppy/quick-retry-for-replays
Allow using "quick retry" shortcut in more cases from results screen
2024-12-13 08:18:59 -08:00
Nicholas Chin
c0b6e784a5 Fix text anchor for mania tooltip 2024-12-13 21:58:23 +08:00
Dean Herbert
9025103b8b
Reword comment to hopefully be more understandable 2024-12-13 20:02:17 +09:00
Dean Herbert
da840e3fac
Change the way "current" points are hinted on timing screen
I actually thought things were bugged with the previous display method,
since the hinting was very similar to the hover colour/state.

I've adjusted this to hopefully give users a better idea of what this is
intending to show them.
2024-12-13 19:45:18 +09:00
Dean Herbert
64555debc2
Fix adjusting control point offset after undo/redo causing catastrophic failure
Closes https://github.com/ppy/osu/issues/31098.

Low effort fix because it was already half broken. The test was testing
in isolation but in actual editor usage it wasn't working as expected.
2024-12-13 19:33:51 +09:00
Dan Balasescu
35c70ceb18
Merge pull request #31106 from peppy/player-settings-fix-overlap-skins
Fix player settings overlay cog overlapping skin elements
2024-12-13 19:30:39 +09:00
Dean Herbert
4b0cdd761d
Add note about player settings overlay button 2024-12-13 18:58:20 +09:00
Dan Balasescu
f84c67babd
Merge pull request #31101 from Joehuu/recommended-diff-beatmap-listing
Add recommended difficulty numerical value near filter in beatmap listing
2024-12-13 18:57:16 +09:00
Dan Balasescu
e2af8820de
Merge pull request #31107 from bdach/flaky-editor-test
Attempt to fix flaky editor beatmap creation test
2024-12-13 18:53:43 +09:00
Dan Balasescu
22a5ed8a07
Merge branch 'master' into player-settings-fix-overlap-skins 2024-12-13 18:36:12 +09:00
Dan Balasescu
c29c3d48bf
Merge pull request #31105 from peppy/player-settings-no-show-skin-editor
Fix player settings overlay appearing while in skin editor
2024-12-13 18:34:05 +09:00
Dean Herbert
d00bc4bdd1
Also allow using "quick retry" for other replays 2024-12-13 18:14:45 +09:00
Dean Herbert
0e0d96829f
Fix "quick retry" hotkey not working for autoplay 2024-12-13 18:08:29 +09:00
Dan Balasescu
edbaaa9468
Fix test 2024-12-13 17:41:55 +09:00
Bartłomiej Dach
fdc41ace7e
Fix flaky editor beatmap creation test
As seen in
https://github.com/ppy/osu/actions/runs/12289146465/job/34294167417#step:5:1588
or
https://github.com/ppy/osu/actions/runs/12310133160/job/34358241666#step:5:53.

Exception messages hint pretty strongly at this being a threading issue
and there does seem to be a rather frivolous lack of waiting for
`CreateNewDifficulty()` to do its thing, so I'm thinking maybe this will
help.
2024-12-13 17:35:41 +09:00
Dean Herbert
a796af9511
Fix player settings overlay cog overlapping skin elements
This brings it down to be in line with the flowing elements that usually
do their best to not get in the way.

Decided against putting it in the `HUDOverlay` flow for simplicity. It
will work fine until it doesn't.
2024-12-13 17:28:15 +09:00