40495 Commits

This Branch

This Branch

All Branches

• Move empty window check to bar error meter

  It's not valid in the base `HitErrorMeter`, as the colour meter only
  displays colour for a given judgement, so it is still valid to add new
  items to it even if the hit window is 0, as misses are still possible.

  Bartłomiej Dach · 2021-06-07 13:16:07 +02:00
  0531c2dcd9
• Add failing assertions to hit error meter test
  Bartłomiej Dach · 2021-06-07 13:16:07 +02:00
  37d062c7cd
• Remove bogus CatchHitWindows

  `CatchHitWindows` were a vestige from the past, and were not actually
  used anywhere except for the hit error meter test, giving off an
  appearance that the hit error meter was working properly.
  `CatchHitObject` actually specifies empty hit windows.

  Bartłomiej Dach · 2021-06-07 13:16:07 +02:00
  122a624b7f
• Merge pull request #13364 from Susko3/android-add-mime-type-x-osu-archive

  Add `application/x-osu-archive` mime type to Android `IntentFilter`s

  Dan Balasescu · 2021-06-07 19:30:15 +09:00
  b32191f924
• Merge pull request #13360 from peppy/fix-slider-repeat-arrow-rotation-editor
  Bartłomiej Dach · 2021-06-07 12:22:41 +02:00
  8d7a250c6e
• Merge branch 'master' into fix-slider-repeat-arrow-rotation-editor
  Dan Balasescu · 2021-06-07 18:46:25 +09:00
  3225bc2c71
• Merge pull request #13362 from peppy/fix-background-screen-reload

  Stop `BackgroundScreenDefault` from reloading beatmap background when already correct

  Dan Balasescu · 2021-06-07 18:44:47 +09:00
  ee256083e3
• add application/x-osu-archive mime type to Android IntentFilters
  Susko3 · 2021-06-07 11:24:48 +02:00
  a0fbf29b98
• Merge pull request #13357 from ekrctb/fruit-representation

  Move osu!catch "fruit visual representation" state from `DrawableFruit` to skin pieces

  Dean Herbert · 2021-06-07 17:49:00 +09:00
  824130355a
• Add more test coverage
  Dean Herbert · 2021-06-07 17:32:10 +09:00
  729e05241f
• Fix switching storyboard mode not triggering a reload
  Dean Herbert · 2021-06-07 17:32:04 +09:00
  59130be99c
• Stop BackgroundScreenDefault from reloading beatmap background when already correct
  Dean Herbert · 2021-06-07 17:22:36 +09:00
  f677f9b5f4
• Merge pull request #13359 from peppy/update-framework

  Update framework

  Dan Balasescu · 2021-06-07 16:56:23 +09:00
  d95f3841cc
• Add missing null handling for never Markdig version
  Dean Herbert · 2021-06-07 16:08:44 +09:00
  e8d4147773
• Merge branch 'master' into fruit-representation
  Dean Herbert · 2021-06-07 16:05:00 +09:00
  1b93234c76
• Fix slider repeat arrow not updating rotation immediately while paused in editor

  A bit of a local solution, but not sure there's a better way to handle
  this.
  
  Closes #13342.

  Dean Herbert · 2021-06-07 15:58:43 +09:00
  277eb9fa6e
• Update framework
  Dean Herbert · 2021-06-07 15:48:45 +09:00
  aa700702fe
• Merge pull request #13358 from ekrctb/move-files

  Move all osu!catch legacy skin piece files to the correct location

  Dean Herbert · 2021-06-07 15:47:58 +09:00
  a17bbe8393
• Move all osu!catch legacy skin piece files to the correct location
  ekrctb · 2021-06-07 15:10:47 +09:00
  bb02c35f2d
• Remove "fruit visual representation" state from DrawableFruit

  Instead, skin pieces compute visual representation from `IndexInBeatmap`.

  ekrctb · 2021-06-07 14:49:37 +09:00
  ac5c55bd2c
• Move FruitVisualRepresentation namespace
  ekrctb · 2021-06-07 13:59:17 +09:00
  166e4565be
• Merge pull request #13338 from Craftplacer/fix-osutestscene-content

  Add `DummyAPIAccess` to `OsuTestScene` one parent up

  Dean Herbert · 2021-06-05 15:32:55 +09:00
  cce0220060
• Merge branch 'master' into fix-osutestscene-content
  Dean Herbert · 2021-06-05 14:49:19 +09:00
  9f6e3996b1
• Add DummyAPIAccess one parent up
  Craftplacer · 2021-06-05 03:30:21 +02:00
  1084906d40
• Merge pull request #13261 from smoogipoo/fix-spectator-frame-conversion

  Fix spectator crashing when converting mania replay frames

  Dean Herbert · 2021-06-05 00:38:15 +09:00
  10acad6524
• Merge pull request #13336 from ekrctb/pdwl-catch-explosion

  Fix catch hit lighting not always showing when a replay is rewound

  Dan Balasescu · 2021-06-04 22:19:34 +09:00
  bde0071de8
• Fix potential race incorrectly pausing the source clock
  smoogipoo · 2021-06-04 21:58:51 +09:00
  009aa994d0
• Merge branch 'master' into fix-spectator-frame-conversion
  Dan Balasescu · 2021-06-04 21:17:40 +09:00
  57a38374db
• Merge pull request #13331 from ekrctb/pdwl-follow-point

  Use general lifetime container for follow point container

  Dan Balasescu · 2021-06-04 20:39:39 +09:00
  fa7611f1e2
• Merge branch 'master' into pdwl-follow-point
  Dan Balasescu · 2021-06-04 20:04:02 +09:00
  a3bec49b3b
• Use seeded RNG for catch explosion animation

  The animation is always the same when a replay is rewound or a beatmap is played multiple times.

  ekrctb · 2021-06-04 19:54:46 +09:00
  8e20f90ed5
• Add NextSingle of version taking output range to StatelessRNG
  ekrctb · 2021-06-04 19:52:12 +09:00
  5512231bf4
• Merge pull request #13303 from LeNitrous/mainmenu-storyboard-backgrounds

  Add storyboards as a main menu background source

  Dean Herbert · 2021-06-04 19:50:40 +09:00
  840f084dc4
• Maintain catch hit explosion by lifetime entries

  - Fix hit explosion not showing when a replay is rewound to a time after a hit object is caught

  ekrctb · 2021-06-04 19:46:50 +09:00
  181f1da3d3
• Bring back scheduling of follow point update
  ekrctb · 2021-06-04 18:41:02 +09:00
  d7da66d876
• Remove one TODO

  It can be removed because pooled drawables are always ready, and `FollowPointConnection` is also ready when applied.

  ekrctb · 2021-06-04 17:09:59 +09:00
  0098ac2760
• Resolve nullable inspection, enable nullable for FollowPointLifetimeEntry
  ekrctb · 2021-06-04 17:09:59 +09:00
  bc892086fe
• Use general lifetime container for follow point container
  ekrctb · 2021-06-04 16:31:50 +09:00
  b373b120ff
• Merge pull request #13313 from ekrctb/factor-out-hoc

  Factor out entry management logic of `HitObjectContainer` to the new base class

  Dan Balasescu · 2021-06-04 16:06:48 +09:00
  2069a5bd28
• Merge pull request #13328 from peppy/increase-music-volume

  Increase music volume back to 80% for the time being

  Dan Balasescu · 2021-06-04 15:36:04 +09:00
  35aeef6838
• Merge branch 'master' into factor-out-hoc
  Dan Balasescu · 2021-06-04 15:31:35 +09:00
  b283c48abb
• Merge pull request #7316 from mcendu/kiai

  Implement kiai flash of hit circles

  Dan Balasescu · 2021-06-04 15:31:19 +09:00
  a02c39b066
• Tidy up code
  Dean Herbert · 2021-06-04 15:18:16 +09:00
  19a44d65c5
• Merge branch 'master' into fix-spectator-frame-conversion
  Dean Herbert · 2021-06-04 15:06:15 +09:00
  23096c58bb
• Increase music volume back to 80% for the time being
  Dean Herbert · 2021-06-04 15:00:53 +09:00
  071c07586a
• apply suggestions

  - apply 0 alpha to beatmap background if storyboard replaces it
  - use an AudioContainer to mute all samples coming from the storyboard

  Nathan Alo · 2021-06-04 13:56:10 +08:00
  996c156106
• Add legacy implementation
  Dean Herbert · 2021-06-04 14:51:35 +09:00
  f62a2747f6
• Add test coverage
  Dean Herbert · 2021-06-04 14:14:51 +09:00
  52557da335
• Tidy up constants
  Dean Herbert · 2021-06-04 14:14:51 +09:00
  5953674737
• Merge branch 'master' into kiai
  Dean Herbert · 2021-06-04 13:50:12 +09:00
  ff70f99da2