76 Commits

Author	SHA1	Message	Date
Dean Herbert	04dbb5d3c6	Disallow setting "NoScores" externally as it is handled internally	2022-01-30 16:18:19 +09:00
Dean Herbert	acc1199add	Consolidate flows of Set operations, either result or error	2022-01-30 16:16:00 +09:00
Dean Herbert	c401629dd8	Also refactor placeholder logic to make more sense	2022-01-30 10:50:32 +09:00
Dean Herbert	b434e29a7c	Move loading hide operation inside early return to ensure not hidden too early ... It should only be hidden after the async load completes.	2022-01-30 03:10:15 +09:00
Dean Herbert	dad9cc9315	Ensure Reset/Scores_Set run inline where possible	2022-01-30 03:06:29 +09:00
Dean Herbert	9b573fbc2b	Add missing entries to switch statement and guard against out of range	2022-01-30 02:58:53 +09:00
Dean Herbert	d21464ea61	Fix assertions to work in both directions	2022-01-30 02:54:51 +09:00
Dean Herbert	d3cb910cf8	Convert inline math to not so inline to make operation more explicit	2022-01-30 02:37:01 +09:00
Dean Herbert	3d771c0fc7	Remove unnecessary loading hide call from PlaceholderState_Set and add more assertiveness	2022-01-30 02:34:31 +09:00
Dean Herbert	6f54f8ad78	Add more safety around CancellationToken usage	2022-01-29 23:58:57 +09:00
Dean Herbert	d0b74a91fb	Fix edge cases with score drawable loading	2022-01-29 23:58:57 +09:00
Dean Herbert	0293d95f82	Simplify IsOnlineScope usage	2022-01-29 23:58:57 +09:00
Dean Herbert	daea13f491	Simplify flow of cancellation token	2022-01-29 23:58:57 +09:00
Dean Herbert	3d59bab7c6	Remove fetch callback logic completely	2022-01-29 23:58:57 +09:00
Dean Herbert	13f445ddd5	Move score update code into own method	2022-01-29 23:58:57 +09:00
Dean Herbert	c48e9f2bbd	Remove more unnecessary schedule/cancel logic	2022-01-29 23:58:57 +09:00
Dean Herbert	a700ad3849	Remove scoresLoadedOnce weirdness	2022-01-29 23:58:57 +09:00
Dean Herbert	661fec7c8a	Make score setter private	2022-01-29 23:58:57 +09:00
Dean Herbert	b85b2c01fb	Reorder based on accessibility and add regions	2022-01-29 23:58:57 +09:00
Dean Herbert	c548658662	Remove move unused pieces	2022-01-29 23:58:57 +09:00
Dean Herbert	17aa9f3040	Remove pointless level of schedule/cancel logic	2022-01-29 23:58:57 +09:00
Dean Herbert	64925b3fea	Remove unused Content override	2022-01-29 23:58:57 +09:00
Dean Herbert	b9dac6c3b2	Reorder and tidy up bindable flows	2022-01-29 23:58:57 +09:00
Dean Herbert	aee93934d5	Rename methods to make more sense (and always run through AddOnce)	2022-01-29 23:58:57 +09:00
Dean Herbert	c6d303a5b4	Add xmldoc to Leaderboard class	2022-01-29 23:58:57 +09:00
Dean Herbert	6944151486	Apply batch fixing of built-in types using var	2021-10-27 13:04:41 +09:00
Dean Herbert	3803f2f462	Fix leaderboard potentially displaying the wrong scores ... Closes #14762. This class is ugly. I think the whole process should be clened up once we have correctly-scheduled `SynchronizationContext`s. There's not much saving it as long as all these interdispersed `Schedule`s around required.	2021-10-06 16:07:29 +09:00
PercyDan54	e1c646b9b2	Remove redundant arguments	2021-07-05 23:52:39 +08:00
Dean Herbert	fc442713bb	Debounce schedule at base class	2021-06-14 14:26:40 +09:00
Dean Herbert	8dd48d48f6	Add support for song select leaderboard to handle newly imported scores	2021-06-14 14:20:23 +09:00
Bartłomiej Dach	610ed99ae3	Add null checks to unguarded resolved-as-null fields	2020-11-14 14:52:58 +01:00
Dean Herbert	9753dab93b	Remove IOnlineComponent and change existing components to use bindable flow	2020-10-22 14:19:12 +09:00
Dean Herbert	d6efa3069a	Merge branch 'master' into fix-login-placeholder-inheritance	2020-10-19 16:25:44 +09:00
smoogipoo	bbef7ff720	Fix leaderboard loading spinner disappearing too early	2020-09-09 20:19:07 +09:00
smoogipoo	bff652a26f	Persist nulls to the top score bindable	2020-09-02 14:29:46 +09:00
smoogipoo	ed74c39b55	Move UserTopScoreContainer into base leaderboard	2020-08-31 19:54:22 +09:00
Joehu	ac7252e152	Fix context menu not masking outside of leaderboard area	2020-07-12 22:04:00 -07:00
Joehu	0d26ad9ddb	Fix user top score not having a context menu	2020-07-11 16:22:01 -07:00
Lucas A	e136ecec5f	Create ClickablePlaceholder and make of use it where applicable.	2020-04-23 14:01:47 +02:00
Dean Herbert	92f6f0207c	Rename LoadingAnimation to LoadingSpinner	2020-02-21 15:33:31 +09:00
recapitalverb	c753cb46c5	Use [Resolved] wherever possible	2020-02-14 20:14:00 +07:00
Dean Herbert	76cfe1f42c	Merge branch 'master' into online-container	2020-02-14 15:18:27 +09:00
Lucas A	e9a5298484	Allow setting the displayed text on LoginPlaceholder	2020-01-12 15:50:35 +01:00
Dean Herbert	ab9603b06a	Merge remote-tracking branch 'upstream/master' into #7146	2020-01-09 17:08:12 +08:00
Dean Herbert	6dd45e52ef	Move text definition inside class	2020-01-08 17:22:51 +09:00
Lucas A	7f92cefe10	Apply review suggestions	2020-01-07 19:06:47 +01:00
Lucas A	5fd5665467	Use implementation on song select leaderboards.	2020-01-04 19:59:25 +01:00
Lucas A	3bd3ebad49	Move placeholders to a dedicated namespace	2020-01-04 19:56:34 +01:00
wltu	bb2b1475cd	Merge branch 'master' of https://github.com/ppy/osu into #7146	2019-12-17 12:54:47 -08:00
Huo Yaoyuan	40b43b85f1	CA1715: use prefix for generic parameters.	2019-12-17 13:00:25 +08:00