osu-lazer

Remove button sound from sample toggle buttons

The new ones added in this change don't play the UI sounds, likely
because they make it nigh impossible to actually hear what the gameplay
samples will sound like.

This removes the same sounds from the existing buttons to match.

Dean Herbert · 2025-12-18 20:17:46 +09:00

13aeed15f9

Fix playing sample multiple times

Bartłomiej Dach · 2025-10-31 08:55:55 +01:00

8755a01622

Add sample set selection controls to sample popovers

- Below 20 custom sample sets, they are shown as ternary buttons.
- Above 20 custom sample sets, they are shown in a dropdown (yes there
  are actual cases of this as I've been informed by the NAT; one example
  being https://osu.ppy.sh/beatmapsets/1018061#osu/2197383)

As a bonus, to make determining what the heck is actually changing when
adjusting these controls, the full set of applicable sounds now plays on
adding/removing additions, changing their banks, as well as changing the
custom set (if any).

For now there are no user-facing controls to add the samples to the map
yourself, you have to know how to name the `.wav`s and edit-externally
them in yourself. *For now.*

Bartłomiej Dach · 2025-10-24 12:09:27 +02:00

e2681c4163

Make bank selection controls dropdowns instead of text boxes

Longstanding complaint. Text boxes make no sense if anything that isn't
the three legacy values gets deleted on save anyway.

Bartłomiej Dach · 2025-10-24 11:52:45 +02:00

1f2f86b016

Show sample suffix on timeline pieces

Bartłomiej Dach · 2025-10-24 11:52:45 +02:00

fa7bd482d2

Fix editor memory leak

Dan Balasescu · 2025-09-02 09:21:31 +09:00

cac136d3c6

Simplify editor "ternary button" structure

As I look into re-implementing the ability to choose combo colour for an
object (also known as "colourhax") from the editor UI, I stumble upon
these wretched ternary items again and sigh a deep sigh of annoyance.

The structure is overly rigid. `TernaryItem` does nothing that
`DrawableTernaryItem` couldn't, except make it more annoying to add
specific sub-variants of `DrawableTernaryItem` that could do more
things.

Yes you could sprinkle more levels of virtuals to
`CreateDrawableButton()` or something, but after all, as Saint Exupéry
says, "perfection is finally attained not when there is no longer
anything to add, but when there is no longer anything to take away."
So I'm leaning for taking one step towards perfection.

Bartłomiej Dach · 2025-01-09 13:41:22 +01:00

5c8ae6f851

Reduce HitSampleInfo constants allocations

Andrei Zavatski · 2025-01-07 00:36:58 +03:00

e8dc09f5bc

Merge branch 'master' into hs-toggle2

Bartłomiej Dach · 2024-11-01 18:44:33 +01:00

f2afec23f9

Remove hide sample toggle

In line with feedback from
https://github.com/ppy/osu/pull/29896#issuecomment-2378676851.

Bartłomiej Dach · 2024-11-01 18:44:24 +01:00

8f48682d0a

Use FinishTransforms to init visual state

OliBomby · 2024-10-19 23:57:05 +02:00

c03017438e

contract sample point pieces based on smallest gap on the timeline

It finds the smallest distance between two sample point pieces on the alive timeline blueprints

OliBomby · 2024-10-05 20:52:45 +02:00

48da758c39

Implement auto additions editor-only

OliBomby · 2024-10-01 16:40:48 +09:00

0a78eb9628

Merge branch 'master' into additions

Dean Herbert · 2024-10-01 16:38:56 +09:00

1b4215576d

Make points slightly smaller when contracted and fix width getting obliterated

Dean Herbert · 2024-09-27 17:24:24 +09:00

9dcce67b81

Use bindable flow for zoom handling

Dean Herbert · 2024-09-27 17:13:26 +09:00

ce41dc4629

Reduce sample point pieces to pink dot if zoomed out

OliBomby · 2024-09-19 16:20:26 +02:00

34087a0f1a

Add view menu toggle for sample points

OliBomby · 2024-09-17 11:27:23 +02:00

e4cfa7c86f

dont seek on right-click, only on keyboard request

OliBomby · 2024-08-29 19:34:14 +02:00

8fe7ab131c

Automatic seek to sample point on right-click

OliBomby · 2024-08-27 19:40:33 +02:00

b5b4f915a9

Add float comparison leniency just in case

OliBomby · 2024-08-27 19:04:16 +02:00

daad476593

Revert "add arrow indicator"

This reverts commit 1ce9e97fd4.

OliBomby · 2024-08-21 14:12:58 +02:00

423feadd64

add arrow indicator

OliBomby · 2024-08-20 23:38:38 +02:00

1ce9e97fd4

Merge remote-tracking branch 'upstream/master' into doubleclick

OliBomby · 2024-08-20 23:19:27 +02:00

ae6d855f8d

Merge branch 'master' into additions

Dean Herbert · 2024-08-08 03:31:11 +09:00

b5a19707d0

Make sample popover change properties of all samples in multiple selection

Closes https://github.com/ppy/osu/issues/28916.

The previous behaviour *may* have been intended, but it was honestly
quite baffling. This seems like a saner variant.

Bartłomiej Dach · 2024-07-24 12:15:12 +02:00

1ed7e4b075

allow hotkeys in sample point piece

OliBomby · 2024-07-14 20:59:46 +02:00

5e86a01e5e

Add a bit more padding between node overlays and hitobjects in timeline

Dean Herbert · 2024-07-12 17:22:36 +09:00

d2cb07b157

Extend behaviour to sample edit popover