143 Commits

• Fix editor seeks not being debounced enough

  Could lead to huge slowdowns when running multi-threaded and performing
  a long drag.

  Dean Herbert · 2025-12-30 23:17:47 +09:00
  853836a48b
• Change editor to not seek smoothly when performing distant seeks

  This reverts to the way stable does things. Smooth seeking is nice and
  all, but slows things down and doesn't give the instant reponse that
  mappers are used to.
  
  This should fix some performance issues regarding seeking as it no
  longer tries to render large portions of the map during the seek
  operation.
  
  Note that I've also forced the summary timeline to always non-smooth
  seek. It was bugging out in weird ways when doing smooth seeks and I
  don't want to attempt to fix it.

  Dean Herbert · 2025-12-29 17:44:03 +09:00
  8347f83f9c
• Debounce track seeks only when track is playing

  This fixes the editor no longer seeking smoothly when paused.
  
  Closes https://github.com/ppy/osu/issues/35963.

  Dean Herbert · 2025-12-11 16:00:13 +09:00
  f71eb4b980
• Adjust to 200 ms debounce

  This [matches
  stable](https://github.com/peppy/osu-stable-reference/blob/52f3f75ed7efd7b9eb56e1e45c95bb91504337be/osu!/Audio/AudioEngine.cs#L1295)
  and feels somewhat better.

  Dean Herbert · 2025-11-21 16:56:58 +09:00
  13dab24d41
• Debounce continuous track seeks to at most one every 500ms

  See https://github.com/ppy/osu/pull/35677#issuecomment-3555903209.

  Bartłomiej Dach · 2025-11-20 12:23:31 +01:00
  6052ed790d
• Combine CentreMarker with MarkerVisualisation
  Andrei Zavatski · 2025-07-18 13:19:41 +03:00
  5cb51e5e21
• Move xmldoc to correct place
  Andrei Zavatski · 2025-07-18 12:46:21 +03:00
  c8eae6fd86
• Add xmldoc explaining the purpose of VerticalTrianglesDrawNode
  Andrei Zavatski · 2025-07-18 12:43:58 +03:00
  a7da7554bc
• Add antialiasing to triangles in MarkerVisualisation
  Andrei Zavatski · 2025-07-18 12:25:54 +03:00
  8362456148
• Fix very short kiai sections not showing up on editor summary timeline

  Closes https://github.com/ppy/osu/issues/33836.

  Dean Herbert · 2025-06-24 14:54:54 +09:00
  dbdf2d9aca
• Adjust preview time display to not conflict with bookmarks
  Dean Herbert · 2025-02-28 14:05:49 +09:00
  e1723ec1bb
• Add basic brighten animation instead
  Dean Herbert · 2025-02-11 17:13:34 +09:00
  b9ed217308
• Disable scale animation when holding editor "test" button
  Dean Herbert · 2025-02-11 17:11:20 +09:00
  1fa8d53232
• Do not expose track directly in EditorClock

  Intends to stop people from mutating it directly, and going through
  `EditorClock` members like `AudioAdjustments` instead.

  Bartłomiej Dach · 2025-01-07 11:40:18 +01:00
  98bb723438
• Implement basic bookmark support in editor
  Bartłomiej Dach · 2024-12-03 15:14:22 +01:00
  d60b7f4798
• Move bookmarks out of BeatmapInfo

  Not sure why I didn't do that in https://github.com/ppy/osu/pull/28473...

  Bartłomiej Dach · 2024-12-03 14:17:14 +01:00
  808934581f
• Use FastCircle for kiai visualisation
  Andrei Zavatski · 2024-08-31 17:32:24 +03:00
  837fa1b8dc
• Merge branch 'master' into fast-circle
  Andrei Zavatski · 2024-08-31 17:31:30 +03:00
  501ea68a21
• Simplify scroll speed point display code now that it only serves one purpose
  Dean Herbert · 2024-08-31 13:14:56 +09:00
  6b8b49e4f1
• Rework kiai handling in summary timeline
  Andrei Zavatski · 2024-08-31 01:59:40 +03:00
  225418dbb3
• Use FastCircle in demanding places in the editor
  Andrei Zavatski · 2024-08-30 17:45:26 +03:00
  f5a2b5ea03
• Merge remote-tracking branch 'upstream/master' into scroll-speed-std
  OliBomby · 2024-08-22 20:17:14 +02:00
  2de5ecceb8
• Fix scroll speed visualisation missing on start kiai effect points

  They were being drawn far offscreen because the width of the kiai multiplied with the X coordinate of the scroll speed vis.

  OliBomby · 2024-08-22 20:17:09 +02:00
  ad8e7f1897
• Add property EditorShowScrollSpeed to Ruleset
  OliBomby · 2024-08-22 19:53:34 +02:00
  998b5fdc12
• Move break display to background of summary timeline
  Dean Herbert · 2024-08-20 17:45:44 +09:00
  bccc797bcb
• Hide scroll speed in bottom timeline
  OliBomby · 2024-08-16 14:43:09 +02:00
  b253d8ecbf
• Make break periods in bottom timeline transparent
  OliBomby · 2024-08-16 13:22:09 +02:00
  5624c1d304
• Use purple again for kiai time specifically
  Dean Herbert · 2024-07-19 19:59:38 +09:00
  c2cc85e6f0
• Increase opacity of control points slightly
  Dean Herbert · 2024-07-19 19:50:21 +09:00
  5ee645ac8f
• Fix summary timeline timing points having x position applied twice
  Dean Herbert · 2024-07-16 18:32:54 +09:00
  f1325386f0
• Apply tooltip to bookmark pieces too

  Bookmarks don't show on real beatmaps, but they do show in test scenes
  (namely `TestSceneEditorSummaryTimeline`).
  
  Also does some more changes to adjust the markers to the latest updates
  to other markers.

  Bartłomiej Dach · 2024-07-12 11:12:20 +02:00
  217b01d303
• Fix nullability issue
  Dean Herbert · 2024-07-12 18:11:23 +09:00
  2453e2fd00
• Add tooltips to summary timeline display
  Dean Herbert · 2024-07-12 16:39:41 +09:00
  2454722601
• Adjust various visuals of summary timeline in a hope for user acceptance

  .. with a somewhat appealing design.

  Dean Herbert · 2024-07-12 13:57:42 +09:00
  685b19a571
• Merge branch 'master' into timeline-redesign
  Dean Herbert · 2024-07-11 18:38:17 +09:00
  95464ebf36
• Pool summary timeline break visualisations to reduce allocations
  Bartłomiej Dach · 2024-07-10 11:42:28 +02:00
  b881c25b17
• Remove unused using
  Bartłomiej Dach · 2024-07-09 10:57:21 +02:00
  ca4c0aa7e2
• Redesign bottom timeline pieces to match stable better
  Bartłomiej Dach · 2024-07-09 09:25:22 +02:00
  5d5dd0de00
• Fix summary timeline not correctly updating after changes to breaks

  Closes https://github.com/ppy/osu/issues/28678.
  
  Oops.

  Dean Herbert · 2024-06-30 20:32:16 +09:00
  8bb51d5a4f
• Adjust break colours to match closer to stable
  Dean Herbert · 2024-06-19 22:02:10 +08:00
  a718af8af5
• Fix summary timeline not reloading properly on break addition/removal
  Bartłomiej Dach · 2024-06-19 10:26:01 +02:00
  7ed587b783
• Fix bottom timeline break visualisations not updating
  Bartłomiej Dach · 2024-06-18 15:54:34 +02:00
  f88f05717a
• Fix allocations in EffectPointVisualisation
  Andrei Zavatski · 2024-02-29 20:35:20 +03:00
  eb0933c3a5
• Update design of summary timeline current time marker
  Dean Herbert · 2023-07-14 17:00:42 +09:00
  fe70f24925
• Localise part of editor
  ansel · 2023-01-15 01:50:47 +03:00
  78e562903d
• Enable nullability for editor components
  ansel · 2023-01-12 18:07:54 +03:00
  2365b065a4
• Rewrite visualisation piece to bind once and without potential event leak
  Salman Ahmed · 2023-01-07 14:40:15 +03:00
  abca13eb6c
• Adjust binding logic
  Bartłomiej Dach · 2023-01-01 19:45:23 +01:00
  efdd557f3b
• Adjust visual appearance of preview time part

  - Use slightly different hue of green to distinguish from difficulty
    control points. The colour is still not ideal, but picking
    a distinctive enough hue is pretty hard.
  
  - Place the preview time part at the bottom rather at the top.
    Not sure why it was at the top; not only could it overlap with the
    control points, but it also looked quite badly misaligned there
    when bookmarks were displayed at the bottom.

  Bartłomiej Dach · 2023-01-01 19:42:55 +01:00
  452ebddfd2
• Merge branch 'master' into previewTime
  Bartłomiej Dach · 2023-01-01 18:38:19 +01:00
  0e59b55a12