74826 Commits

This Branch

This Branch

All Branches

• Always add an icon
  Dan Balasescu · 2025-08-16 16:03:47 +09:00
  01de2dc55b
• Make non-nullable member truly non-nullable
  Dan Balasescu · 2025-08-15 19:33:19 +09:00
  2750f5bb53
• Replace OnUpdate() usage with local update
  Dan Balasescu · 2025-08-15 19:32:54 +09:00
  5a1750071e
• Merge pull request #34662 from bdach/refetch-leaderboard-on-retry

  Refetch leaderboard when (slow) retrying a beatmap

  Dean Herbert · 2025-08-15 18:29:17 +09:00
  46744c6f15
• Merge pull request #34651 from Hiviexd/verify/check-video-usage

  Add verify check for inconsistent video usage

  Bartłomiej Dach · 2025-08-15 11:06:20 +02:00
  099d1dc459
• Merge pull request #34657 from peppy/audio-hotfix-aaaaaaaaaaaa

  Ignore more potentially incorrect data from BASS

  Bartłomiej Dach · 2025-08-15 11:05:52 +02:00
  6f733fd3fc
• Rename variables
  Bartłomiej Dach · 2025-08-15 10:21:50 +02:00
  5722e85791
• Remove failing test

  Test was added in 5495c2090a to exercise a
  previous version of the hotfix-workaround of not allowing seeking back.
  Now that the hotfix-workaround also encompasses seeking *forward*, which
  breaks another 100 tests, thus requiring the hotfix-workaround to be
  turned off for tests, this situation is just completely out of
  control. So I'm just removing the test because ugh.

  Bartłomiej Dach · 2025-08-15 10:01:10 +02:00
  126d0c6bdb
• Merge pull request #34533 from AeroKoder/user-avatar-notification

  Made the user avatar square, in `UserAvatarNotification`.

  Dean Herbert · 2025-08-15 16:05:00 +09:00
  6ed7ba350d
• Mark flaky test as explicit

  See https://github.com/ppy/osu/pull/34625#discussion_r2269595186.

  Bartłomiej Dach · 2025-08-15 08:54:03 +02:00
  b89d8cc5b3
• Merge pull request #33558 from frenzibyte/ssv2-crash

  Fix song select crashing on beatmap with two difficulties of same online ID

  Bartłomiej Dach · 2025-08-15 08:50:51 +02:00
  0e5900add9
• Fix half written comment and adjust threshold down slightly
  Dean Herbert · 2025-08-15 15:40:30 +09:00
  1f10bff7a7
• Don't enforce hotfix during debug builds, to allow interactive tests to run correctly
  Dean Herbert · 2025-08-15 15:29:51 +09:00
  69647f4c9c
• Merge pull request #34659 from bdach/bss-submission-double-bind

  Fix navigating back and forth from beatmap submission settings screen crashing

  Dean Herbert · 2025-08-15 02:45:37 +09:00
  4bb5509267
• Merge pull request #34640 from bdach/multiple-tag-filters

  Add support for specifying multiple user tag filters at once

  Dean Herbert · 2025-08-15 02:39:47 +09:00
  734043fb0d
• Merge branch 'master' into bss-submission-double-bind
  Salman Alshamrani · 2025-08-14 17:20:51 +03:00
  28c9a62634
• Merge pull request #34658 from peppy/fix-tag-search-operation
  Bartłomiej Dach · 2025-08-14 15:55:01 +02:00
  f7a029ff55
• Refetch leaderboard when (slow) retrying a beatmap

  Probably closes https://github.com/ppy/osu/issues/34645.
  
  Obviously this is only good if the score has managed to process online
  and slot into a leaderboard before the user requested a retry. I can't
  make miracles happen.
  
  Notably this is not applied to quick retry, because it would make quick
  retry slower, and the presumption is that if the user is quick-retrying
  their last score is likely useless for global leaderboards anyway. (The
  one exception to that last part is possibly quick-retrying from results
  screen, which is a flow that we have, but maybe fine to ignore it...?)

  Bartłomiej Dach · 2025-08-14 14:31:49 +02:00
  44e76a61a9
• Add failing test
  Bartłomiej Dach · 2025-08-14 14:18:25 +02:00
  116a45c9cb
• add more tests for pairwise comparison
  Hivie · 2025-08-14 13:15:19 +01:00
  07e982e02f
• handle pairwise comparison for video start times
  Hivie · 2025-08-14 13:14:58 +01:00
  f928f9953b
• Also ensure that ordering doesn't matter
  Dean Herbert · 2025-08-14 21:14:35 +09:00
  7a1cad7312
• Update test code
  Salman Alshamrani · 2025-08-14 14:14:45 +03:00
  67b4d8432c
• Merge branch 'master' into ssv2-crash
  Salman Alshamrani · 2025-08-14 14:09:54 +03:00
  347d621437
• Fix navigating back and forth from beatmap submission settings screen crashing

  supersedes https://github.com/ppy/osu/pull/34656

  Bartłomiej Dach · 2025-08-14 12:57:10 +02:00
  3bfa7bf862
• Fix tags popover search functionality not always working

  This is super haphazard in the first place but I'm going to look past
  that for now.
  
  Basically, due to the order of operation, the tags could be initialised
  via `updateTags()` before the perform search action was initialised,
  leading to clicks doing nothing.

  Dean Herbert · 2025-08-14 19:43:03 +09:00
  6c4c2c1a6a
• Ignore more potentially incorrect data from BASS

  This is still a workaround but arguably it's something we could leave in
  place without much loss. I think this at least feels better than the
  previous code.
  
  Notably, you could argue the test coverage of the fail case is lower
  since made it implicit that all tests will avoid the "backwards seek"
  detections.  But we never really had tests correctly- fail on the original
  so I don't see any loss of value.

  Dean Herbert · 2025-08-14 19:20:30 +09:00
  82906300b4
• Update test coverage to do less irrelevant things
  Salman Alshamrani · 2025-08-14 12:42:20 +03:00
  a04cc047c1
• Remove TODO comment
  Salman Alshamrani · 2025-08-14 12:38:04 +03:00
  693c39c23b
• Merge branch 'master' into multiple-tag-filters
  Salman Alshamrani · 2025-08-14 12:32:32 +03:00
  032c81a21e
• Merge pull request #34639 from bdach/difficulty-range-from-non-expired

  Calculate multiplayer room difficulty range based only on non-expired items

  Bartłomiej Dach · 2025-08-14 10:56:10 +02:00
  b5e8d83900
• Merge branch 'master' into difficulty-range-from-non-expired
  Salman Alshamrani · 2025-08-14 10:21:03 +03:00
  bbc1509cd1
• add tests
  Hivie · 2025-08-13 20:26:50 +01:00
  961aef539c
• add verify check for video usage
  Hivie · 2025-08-13 20:26:46 +01:00
  e52a4638fe
• add util for getting storyboard video of a difficulty
  Hivie · 2025-08-13 20:26:26 +01:00
  79fcd045b3
• Merge pull request #34644 from smoogipoo/fix-status-icon-colour

  Fix incorrect status colour for DnD users

  Dean Herbert · 2025-08-14 02:44:28 +09:00
  5469357b23
• Merge pull request #34584 from Hiviexd/verify/refactor-verifier-context

  Refactor `BeatmapVerifierContext`

  Dean Herbert · 2025-08-14 02:28:57 +09:00
  75c72b150e
• Fix incorrect status colour for DnD users
  Dan Balasescu · 2025-08-13 19:50:30 +09:00
  47022d23f1
• Clean up ctors

  There were too many of them, and they were a bit twisty for my liking.

  Bartłomiej Dach · 2025-08-13 12:32:17 +02:00
  19f28813a0
• Expand xmldoc
  Bartłomiej Dach · 2025-08-13 12:24:40 +02:00
  076d6df78e
• Fix FilterCriteria only being able to support one tag filter at once

  Other textual keyword filters also worked like that, wherein if you did
  `artist=a artist=b` the second filter would overwrite the second, but in
  those cases the query is against a single field, so attempting to put
  multiple search criteria in conjunction on a single field is kind of
  nonsensical, so it was sort of fine to do that.
  
  Which is not the case for user tags, which are multi-valued.

  Bartłomiej Dach · 2025-08-13 10:24:54 +02:00
  3fb1880466
• Add failing test coverage for applying multiple concurrent tag filters
  Bartłomiej Dach · 2025-08-13 10:21:23 +02:00
  a8b827782e
• Fix keyword filters potentially being wrongly merged together due to regex wildcard greedy matching

  Because of greedy matching, a filter of
  
      tag="style/clean"! tag="song representation/simple"!
  
  would not parse into 2 separate filters like
  
      (tag, =, "style/clean"!)
      (tag, =, "song representation/simple"!)
  
  but rather a single one like
  
      (tag, =, "style/clean"! tag="song representation/simple"!)
  
  This sort of matches what web did in
  https://github.com/ppy/osu-web/pull/12044, except web does some stuff
  with quote escaping that I'd rather not, and also the search syntax
  seems to slightly deviate because web seems to be using single quotes
  and double quotes to open the value part of the filter. I'm not sure
  what the difference is and I'd rather not go into all that right now.

  Bartłomiej Dach · 2025-08-13 10:21:10 +02:00
  08a0025e31
• Add failing test coverage for parsing multiple concurrent tag filters
  Bartłomiej Dach · 2025-08-13 10:07:50 +02:00
  6ddb2d3305
• Calculate multiplayer room difficulty range based only on non-expired items

  Previously (https://github.com/ppy/osu/pull/34464) this was based on
  room status, but in review of the web-side change it was pointed out
  that even an open room could have no active items
  (https://github.com/ppy/osu-web/pull/12325#pullrequestreview-3082894354).

  Bartłomiej Dach · 2025-08-13 09:32:50 +02:00
  aa88d90eb2
• Adjust test to match expected behaviour
  Bartłomiej Dach · 2025-08-13 09:27:01 +02:00
  447858ee5e
• Merge pull request #34625 from peppy/fix-song-select-event-feedback

  Fix selection being finalised immediately on beatmap updates arriving

  Bartłomiej Dach · 2025-08-12 14:57:01 +02:00
  2025.813.0-tachyon 734dea1be4
• Merge pull request #34592 from Hiviexd/feature/argon-unstable-rate-counter

  Add "Argon" unstable rate counter

  Bartłomiej Dach · 2025-08-12 14:06:39 +02:00
  4bed784a20
• Fix selection being finalised immediately on beatmap updates arriving
  Dean Herbert · 2025-08-12 20:22:37 +09:00
  4c734c2a0e
• Add test coverage of debounce being bypassed when beatmaps are updated
  Dean Herbert · 2025-08-12 20:22:36 +09:00
  bc5ec22dee