mirror of
https://github.com/ppy/osu.git
synced 2024-11-15 13:47:24 +08:00
9f5a280bc2
Intends to fix test failures as seen in https://github.com/ppy/osu/actions/runs/6692350567/job/18181352642#step:5:129 This is what happens if you carelessly fire and forget. The working theory (that I'm not sure I have the tools to conclusively confirm) is that the async write from the key binding changing could fire _after_ the section is reset. I briefly considered having the test wait for the change, but given that the entirety of the surrounding flow is using sync operations, this just looks like a bug to me. And there's no real sane way to inject async into that flow due to dependence on `OsuButton.Action`. |
||
|---|---|---|
| .. | ||
| Sections | ||
| DangerousSettingsButton.cs | ||
| ISettingsItem.cs | ||
| MultiplierSettingsSlider.cs | ||
| OutlinedTextBox.cs | ||
| RulesetSettingsSubsection.cs | ||
| SettingsButton.cs | ||
| SettingsCheckbox.cs | ||
| SettingsDropdown.cs | ||
| SettingsEnumDropdown.cs | ||
| SettingsFooter.cs | ||
| SettingsHeader.cs | ||
| SettingsItem.cs | ||
| SettingsNumberBox.cs | ||
| SettingsPercentageSlider.cs | ||
| SettingsSection.cs | ||
| SettingsSidebar.cs | ||
| SettingsSlider.cs | ||
| SettingsSubsection.cs | ||
| SettingsTextBox.cs | ||
| SidebarButton.cs | ||
| SidebarIconButton.cs | ||