1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-16 05:42:54 +08:00
osu-lazer/osu.Game/Screens/OnlinePlay
Dean Herbert dea7f2308c Fix participant panels potentially keeping a reference to an old user
If a user leave and then rejoins a multiplayer match while another user
is not at the lobby screen, there is a potential the `ParticipantPanel`
tracking the user will not correctly be recreated to reference the new
instance of the `MultiplayerUser`.

This happens because the `OnRoomUpdated` call is scheduled, which means
it is not running in the background, coupled with the local logic that
relies on `IEquatable(MultiplayerRoomUser)` (which in turn falls back to
a UserID comparison).

Changing this to a reference comparison is the easiest way to resolve
this. Whether we change the `IEquatable` implementation is up for
discussion.

Closes https://github.com/ppy/osu/issues/15970.
2021-12-07 17:24:04 +09:00
..
Components Merge branch 'master' into i-ruleset-store 2021-12-04 15:05:39 +01:00
Lounge Clean up unused resolved properties 2021-12-03 18:49:49 +09:00
Match Ensure user is returned to the RoomSubScreen before gameplay is started 2021-12-06 14:03:52 +09:00
Multiplayer Fix participant panels potentially keeping a reference to an old user 2021-12-07 17:24:04 +09:00
Playlists Clean up unused resolved properties 2021-12-03 18:49:49 +09:00
DrawableRoomPlaylist.cs Fix dangling line post-rebase 2021-12-01 21:36:25 +09:00
DrawableRoomPlaylistItem.cs Remove mentions of "panel" and "direct" from names of old download buttons 2021-11-27 15:08:03 +01:00
DrawableRoomPlaylistWithResults.cs Only show owner in match subscreen 2021-11-26 17:40:45 +09:00
FooterButtonFreeMods.cs Remove "Unranked" text from ModDisplay 2021-06-09 13:45:09 +09:00
FreeModSelectOverlay.cs Remove mod multiplier completely 2021-06-25 16:36:31 +09:00
Header.cs Use Torus alternates on online play screens as per design 2021-10-04 00:26:41 +02:00
IOnlinePlaySubScreen.cs Rename I{Multiplayer -> OnlinePlay}SubScreen 2020-12-25 18:07:34 +01:00
IRoomManager.cs Refactorings 2021-08-13 22:09:47 +09:00
OngoingOperationTracker.cs Move lease check inside schedule 2021-01-30 21:03:09 +01:00
OnlinePlayComposite.cs Remove unnecessary nameofs 2021-11-19 15:45:45 +09:00
OnlinePlayScreen.cs Clean up unused resolved properties 2021-12-03 18:49:49 +09:00
OnlinePlaySongSelect.cs Rename LocalPlayer to User in mod select prefixes 2021-09-01 17:22:52 +09:00
OnlinePlaySubScreen.cs Move AllowTrackAdjustments specification to RoomSubScreen 2021-09-17 13:24:01 +09:00
OnlinePlaySubScreenStack.cs Move gradient to be part of the background for now 2021-08-23 15:27:32 +09:00