1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-15 09:07:25 +08:00
osu-lazer/osu.Game/Tests
Bartłomiej Dach 776fabd77c
Only use MD5 when performing metadata lookups
Both online and offline using the cache.

The rationale behind this change is that in the current state of
affairs, `TestPartiallyMaliciousSet()` fails in a way that cannot be
reconciled without this sort of change.

The test exercises a scenario where the beatmap being imported has an
online ID in the `.osu` file, but its hash does not match the online
hash of the beatmap. This turns out to be a more frequent scenario than
envisioned because of users doing stupid things with manual file editing
rather than reporting issues properly.

The scenario is realistic only because the behaviour of the endpoint
responsible for looking up beatmaps is such that if multiple parameters
are given (e.g. all three of beatmap MD5, online ID, and filename), it
will try the three in succession:

	f6b341813b/app/Http/Controllers/BeatmapsController.php (L260-L266)

and the local metadata cache implementation reflected this
implementation.

Because online ID and filename are inherently unreliable in this
scenario due to being directly manipulable by clueless or malicious
users, neither should not be used as a fallback.
2024-10-30 08:12:30 +01:00
..
Beatmaps Fix test failures due to automatic break generation kicking in 2024-06-19 11:32:08 +02:00
Gameplay Implement toggling visibility of pass and fail storyboard layers 2024-06-14 13:59:02 +02:00
Rulesets Mark CreateConfig() return type as nullable because it's not required all ruleset to implement. 2022-07-10 10:15:27 +08:00
Visual Only use MD5 when performing metadata lookups 2024-10-30 08:12:30 +01:00
CleanRunHeadlessGameHost.cs Update IPC usages 2024-01-18 19:45:36 +09:00
FlakyTestAttribute.cs Fix flaky tests not running at all with environment variable set 2022-07-07 04:24:10 +03:00
OsuTestBrowser.cs Remove test scene background stack and use new ChangeBackgroundColour method 2023-10-12 14:08:31 +09:00
PollingChatClient.cs Apply NRT to APIRequest 2024-08-30 18:35:31 +09:00
TestChatClientConnector.cs Rename PollingChatClientConnector to better describe usage 2024-01-29 16:56:28 +09:00
VisualTestRunner.cs Update IPC usages 2024-01-18 19:45:36 +09:00