1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-11 09:27:29 +08:00
osu-lazer/osu.Game/Screens
Bartłomiej Dach 0d2a47167c
Fix crash on calculating playlist duration when rate-changing mods are present
Regressed in https://github.com/ppy/osu/pull/28399.

To reproduce, enter a playlist that has an item with a rate-changing mod
(rather than create it yourself).

This is happening because `APIRuleset` has `CreateInstance()`
unimplemented:

    b4cefe0cc2/osu.Game/Online/API/Requests/Responses/APIBeatmap.cs (L159)

and only triggers when the playlist items in question originate from
web.

This is why it is bad to have interface implementations throw outside of
maybe mock implementations for tests. `CreateInstance()` is a scourge
elsewhere in general, we need way less of it in the codebase (because
while convenient, it's also problematic to implement in online contexts,
and also expensive because reflection).
2024-06-25 11:28:10 +02:00
..
Backgrounds Fix incorrect background being loaded due to async race 2024-05-01 00:05:14 +08:00
Edit Merge branch 'master' into timeline-drag-selection-crash 2024-06-20 15:16:10 +09:00
Footer Merge branch 'master' into footer-v2-become-global 2024-06-08 14:13:05 +03:00
Import
Menu Add minimal viable variant of new daily challenge screen 2024-06-10 13:09:12 +02:00
OnlinePlay Fix crash on calculating playlist duration when rate-changing mods are present 2024-06-25 11:28:10 +02:00
Play Adjust calls to GetContainingInputManager() 2024-06-18 07:41:19 +02:00
Ranking Clamp X value to avoid excessive balance shift 2024-06-13 18:06:19 +02:00
Select Adjust calls to GetContainingInputManager() 2024-06-18 07:41:19 +02:00
SelectV2 Adjust calls to GetContainingInputManager() 2024-06-18 07:41:19 +02:00
Spectate Remove managed clocks from SpectatorSyncManager on gameplay completion / abort 2024-04-26 15:29:59 +08:00
Utility Adjust calls to GetContainingInputManager() 2024-06-18 07:41:19 +02:00
BackgroundScreen.cs Unload beatmap storyboard background when no longer present 2023-11-09 17:20:11 +03:00
BackgroundScreenStack.cs Use alternative method of scheduling storyboard unload 2023-11-16 15:37:53 +09:00
IHandlePresentBeatmap.cs Automated pass 2023-06-24 01:00:03 +09:00
IHasSubScreenStack.cs Automated pass 2023-06-24 01:00:03 +09:00
IOsuScreen.cs Move screen footer to OsuGame 2024-05-16 07:48:58 +03:00
IPerformFromScreenRunner.cs
Loader.cs Remove disclaimer screen completely 2023-12-28 17:21:29 +09:00
OsuScreen.cs Move screen footer to OsuGame 2024-05-16 07:48:58 +03:00
OsuScreenDependencies.cs
OsuScreenStack.cs Move screen footer to OsuGame 2024-05-16 07:48:58 +03:00
ScorePresentType.cs Remove redundant nullable suppression directives 2023-06-07 08:20:41 +03:00
ScreenWhiteBox.cs
StartupScreen.cs Automated pass 2023-06-24 01:00:03 +09:00