osu-lazer

mirror of https://github.com/ppy/osu.git synced 2026-05-17 04:32:35 +08:00

Files

T

Bartłomiej Dach 9f91c2e25c Emit important replay frames on every judgement

- Closes https://github.com/ppy/osu/issues/4287
- Probably closes https://github.com/ppy/osu/issues/25405 (but not
  retroactively)

Up until now, whether or not a replay frame is emitted depended solely
on the user's input, i.e. mouse movement or key presses/releases. This,
intersected with the replay playback system which is given allowance to
perform interpolation between replay frames, leads to potential
situations wherein a replay can play inaccurately when a judgement takes
place without user input meaningfully changing. One such case is slider
ends with their 36ms of judgement leniency; see
https://github.com/ppy/osu/issues/25405#issuecomment-2879031106 for
details on that.

To that end, this commit aims to counteract that issue by *forcing* an
important replay frame to be emitted on every new judgement recorded
during gameplay. This will only benefit rulesets wherein judgements can
occur that are not inherently tied to user input changing, which are
going to be osu! as mentioned above, and maybe possibly catch. I don't
foresee this doing anything relevant for taiko or mania.

9f91c2e25c · 2025-05-15 11:43:09 +02:00

History

Configuration

Apply Bindable.Parse refactorings

2023-12-13 14:07:38 +09:00

Difficulty

Disable incorrect cancellation token inspection

2025-04-07 20:12:49 +09:00

Edit

Simplify taglib interactions further

2025-04-28 15:52:31 +09:00

Filter