1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-16 21:52:54 +08:00
osu-lazer/osu.Game/Screens/Select
Bartłomiej Dach f1842d781e
Decouple AdvancedStats from global mods
Closes https://github.com/ppy/osu/issues/30163.

If I'm to be blunt, the decoupled stuff in song select makes my head
spin. I spent a solid 20 minutes thinking how I was going to fix this
one but then finally realised that generally most of the cause there
was the fact that `AdvancedStats` was seeing the new rulesets *before*
the "ensure global selected mods are valid for current ruleset" logic,
and so decided to just _delay_ that until the decoupled transfer
thingamajig happens.

I was honestly considering combining `BeatmapInfo`, `Ruleset`, and
`Mods` into one property on `AdvancedStats`. I figured I'd rather not
push my luck and try the baseline version first, but I honestly think
that direction is going to be required at some point to properly corral
all of the decoupled madness taking place in song select.
2024-10-10 14:22:16 +02:00
..
Carousel Use for with exposed IReadOnlyList rather than making internal container public 2024-09-04 15:25:36 +09:00
Details Decouple AdvancedStats from global mods 2024-10-10 14:22:16 +02:00
Filter Automated pass 2023-06-24 01:00:03 +09:00
Leaderboards Fix song select leaderboard tab ordering not matching stable 2023-12-28 14:13:35 +09:00
Options Use new overlay pop-in/pop-out samples 2023-08-17 18:36:36 +09:00
BeatmapCarousel.cs Remove unused parameter in applyActiveCriteria 2024-09-18 17:22:09 +09:00
BeatmapClearScoresDialog.cs make ResetConfirmDialog properly utilise its parent's logic 2023-03-05 20:57:26 +01:00
BeatmapDeleteDialog.cs Fix delete dialogs having generic "Caution" header text 2024-10-07 16:46:53 +09:00
BeatmapDetailArea.cs functionality is done 2023-09-03 02:09:01 +03:00
BeatmapDetailAreaDetailTabItem.cs Automated pass 2023-06-24 01:00:03 +09:00
BeatmapDetailAreaLeaderboardTabItem.cs Automated pass 2023-06-24 01:00:03 +09:00
BeatmapDetailAreaTabControl.cs Partial everything 2022-11-27 00:00:27 +09:00
BeatmapDetailAreaTabItem.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
BeatmapDetails.cs Apply padding to GridContainers directly 2024-02-20 23:18:37 +03:00
BeatmapInfoWedge.cs Adjust song select info icon size slightly 2024-08-05 17:21:50 +09:00
BeatmapInfoWedgeBackground.cs Automated pass 2023-06-24 01:00:03 +09:00
BeatmapInfoWedgeV2.cs Add comment explaining the max width 2023-09-06 15:01:55 -07:00
FilterControl.cs Adjust calls to GetContainingInputManager() 2024-06-18 07:41:19 +02:00
FilterCriteria.cs Add mods to FilterCriteria, pass to ruleset method 2024-03-28 23:03:26 +09:00
FilterQueryParser.cs Add 'yes'/'no' acronyms to the played= filter 2024-09-06 18:04:39 +09:00
Footer.cs Partial everything 2022-11-27 00:00:27 +09:00
FooterButton.cs Partial everything 2022-11-27 00:00:27 +09:00
FooterButtonMods.cs Swap the low and high multiplier color 2024-06-26 21:39:14 +08:00
FooterButtonOptions.cs Automated pass 2023-06-24 01:00:03 +09:00
FooterButtonRandom.cs Show "rewind" text on random button when beginning a right mouse press 2023-05-17 14:51:40 +09:00
LocalScoreDeleteDialog.cs Fix delete dialogs having generic "Caution" header text 2024-10-07 16:46:53 +09:00
ModSpeedHotkeyHandler.cs Fix rate change hotkeys sometimes losing track of adjust pitch setting 2024-09-30 08:47:02 +02:00
NoResultsPlaceholder.cs Partial everything 2022-11-27 00:00:27 +09:00
PlayBeatmapDetailArea.cs Fix song select leaderboard tab ordering not matching stable 2023-12-28 14:13:35 +09:00
PlaySongSelect.cs Adjust calls to GetContainingInputManager() 2024-06-18 07:41:19 +02:00
SkinDeleteDialog.cs Fix delete dialogs having generic "Caution" header text 2024-10-07 16:46:53 +09:00
SongSelect.cs Decouple AdvancedStats from global mods 2024-10-10 14:22:16 +02:00
SongSelectTouchInputDetector.cs Rename touch "input handlers" to detectors 2023-11-06 10:08:19 +01:00
WedgeBackground.cs Only apply dim changes when background blur is disabled 2023-02-15 14:16:34 +09:00