1
0
mirror of https://github.com/ppy/osu.git synced 2026-05-13 20:33:35 +08:00
Files
osu-lazer/osu.Game.Rulesets.Mania.Tests
T
Bartłomiej Dach b578d34da4 Attempt to fix flaky mania key count change test
Can reproduce the failure via something like

diff --git a/osu.Game.Rulesets.Mania/Edit/Setup/ManiaDifficultySection.cs b/osu.Game.Rulesets.Mania/Edit/Setup/ManiaDifficultySection.cs
index fe5c437e40..92c58a7bde 100644
--- a/osu.Game.Rulesets.Mania/Edit/Setup/ManiaDifficultySection.cs
+++ b/osu.Game.Rulesets.Mania/Edit/Setup/ManiaDifficultySection.cs
@@ -187,13 +187,13 @@ private void updateKeyCount(ValueChangedEvent<int> keyCount)
             {
                 if (!t.GetResultSafely())
                 {
-                    Schedule(() =>
+                    Scheduler.AddDelayed(() =>
                     {
                         changeHandler!.RestoreState(-1);
                         Beatmap.Difficulty.CircleSize = keyCount.OldValue;
                         setStateFromActualKeyCount(keyCount.OldValue);
                         updatingKeyCount = false;
-                    });
+                    }, 1000);
                 }
                 else
                 {

so I'm banking on this being just a case of CI fuzzing the test by being
slow.

If the test fails again on this same assert after this change there are
bigger problems at hand. But given the lack of local reproduction I'd
rather start with this than spend an hour staring at it.
b578d34da4 · 2026-05-08 09:38:56 +02:00
History
..
2025-07-02 14:00:33 +02:00
2024-08-07 14:36:04 -07:00
2024-08-29 20:21:32 +09:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2024-07-03 00:19:04 +09:00
2024-08-07 14:36:04 -07:00