1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-15 13:07:24 +08:00
osu-lazer/osu.Game/Online
Bartłomiej Dach 776fabd77c
Only use MD5 when performing metadata lookups
Both online and offline using the cache.

The rationale behind this change is that in the current state of
affairs, `TestPartiallyMaliciousSet()` fails in a way that cannot be
reconciled without this sort of change.

The test exercises a scenario where the beatmap being imported has an
online ID in the `.osu` file, but its hash does not match the online
hash of the beatmap. This turns out to be a more frequent scenario than
envisioned because of users doing stupid things with manual file editing
rather than reporting issues properly.

The scenario is realistic only because the behaviour of the endpoint
responsible for looking up beatmaps is such that if multiple parameters
are given (e.g. all three of beatmap MD5, online ID, and filename), it
will try the three in succession:

	f6b341813b/app/Http/Controllers/BeatmapsController.php (L260-L266)

and the local metadata cache implementation reflected this
implementation.

Because online ID and filename are inherently unreliable in this
scenario due to being directly manipulable by clueless or malicious
users, neither should not be used as a fallback.
2024-10-30 08:12:30 +01:00
..
API Only use MD5 when performing metadata lookups 2024-10-30 08:12:30 +01:00
Chat Fix delete dialogs having generic "Caution" header text 2024-10-07 16:46:53 +09:00
Leaderboards Merge branch 'master' into LeaderBoardScore_clean 2024-06-07 22:42:49 +03:00
Metadata Add logging when starting and stopping watch operations in online metadata client 2024-07-29 13:19:01 +02:00
Multiplayer Use full async flow rather than ContinueWith 2024-10-22 18:48:01 +09:00
Notifications/WebSocket Fix ruleset medals not displaying due to deserialisation failure 2024-03-11 21:34:10 +01:00
Placeholders Add hover color back to ClickablePlaceholder 2024-10-21 21:09:26 +08:00
Rooms Apply NRT to APIRequest 2024-08-30 18:35:31 +09:00
Solo Move away from Solo namespace 2024-02-29 01:21:17 +03:00
Spectator Send mods in spectator frame headers 2024-10-07 13:45:34 +02:00
BeatmapDownloadTracker.cs Add inline comments for iOS locals 2024-09-26 16:48:42 +09:00
DevelopmentEndpointConfiguration.cs Remove no longer relevant changes 2024-01-29 09:05:03 +01:00
DownloadState.cs Fix playlist items showing download button briefly during initial local presence checks 2022-09-08 17:10:45 +09:00
DownloadTracker.cs Partial everything 2022-11-27 00:00:27 +09:00
EndpointConfiguration.cs Update endpoints to final production endpoints 2024-01-30 18:40:17 +09:00
HubClient.cs Rename StartAsync -> ConnectAsync 2022-11-02 11:44:16 +09:00
HubClientConnector.cs Also send version hash header under more accepted convention of name 2024-07-17 16:21:46 +02:00
IHubClientConnector.cs Implement client-side disconnection flow 2023-11-21 15:15:45 +09:00
ILinkHandler.cs Add and use ILinkHandler interface 2022-06-20 20:04:21 +02:00
IStatefulUserHubClient.cs Add extended xmldoc to DisconnectRequested() 2024-02-16 13:09:36 +01:00
OnlineStatusNotifier.cs Handle forced logouts due to password change too 2024-01-26 10:53:27 +01:00
OnlineViewContainer.cs Update APIState checks 2023-11-16 20:39:23 +09:00
PersistentEndpointClient.cs Add/adjust xmldocs 2022-11-02 13:16:34 +09:00
PersistentEndpointClientConnector.cs Use staggered exponential backoff when retrying in PersistentEndpointClientConnector 2024-02-06 15:40:30 +01:00
PollingComponent.cs Partial everything 2022-11-27 00:00:27 +09:00
ProductionEndpointConfiguration.cs Remove no longer relevant changes 2024-01-29 09:05:03 +01:00
ScoreDownloadTracker.cs Add inline comments for iOS locals 2024-09-26 16:48:42 +09:00
SignalRDerivedTypeWorkaroundJsonConverter.cs Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0 2022-12-16 18:16:26 +09:00
SignalRUnionWorkaroundResolver.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
SignalRWorkaroundTypes.cs Simplify UserActivity for serialisability over the wire 2023-12-06 18:52:26 +01:00
UserStatisticsUpdate.cs Move away from Solo namespace 2024-02-29 01:21:17 +03:00
UserStatisticsWatcher.cs Move away from Solo namespace 2024-02-29 01:21:17 +03:00