1
0
mirror of https://github.com/ppy/osu.git synced 2025-02-20 18:43:04 +08:00
osu-lazer/osu.Game.Rulesets.Catch/Edit
Bartłomiej Dach 5c8ae6f851
Simplify editor "ternary button" structure
As I look into re-implementing the ability to choose combo colour for an
object (also known as "colourhax") from the editor UI, I stumble upon
these wretched ternary items again and sigh a deep sigh of annoyance.

The structure is overly rigid. `TernaryItem` does nothing that
`DrawableTernaryItem` couldn't, except make it more annoying to add
specific sub-variants of `DrawableTernaryItem` that could do more
things.

Yes you could sprinkle more levels of virtuals to
`CreateDrawableButton()` or something, but after all, as Saint Exupéry
says, "perfection is finally attained not when there is no longer
anything to add, but when there is no longer anything to take away."
So I'm leaning for taking one step towards perfection.
2025-01-09 13:41:22 +01:00
..
Blueprints Add comments backreferences to copies of duplicated code for future use 2024-12-11 16:26:11 +09:00
Checks Refactor abstract check to reduce duplication 2024-03-26 11:13:03 +01:00
BananaShowerCompositionTool.cs Refactor PlacementBlueprint to not be hitobject specific 2024-09-24 20:31:00 +02:00
CatchBeatmapVerifier.cs Make check ruleset specific 2024-03-22 14:48:22 -03:00
CatchBeatSnapGrid.cs Abstract out common implementation of BeatSnapGrid 2023-10-17 16:42:52 +09:00
CatchBlueprintContainer.cs Remove #nullable disable from Catch.Edit namespace 2023-01-15 17:29:32 +09:00
CatchDistanceSnapGrid.cs Remove #nullable disable from Catch.Edit namespace 2023-01-15 17:29:32 +09:00
CatchDistanceSnapProvider.cs Made reading of ReadCurrentDistanceSnap public 2024-11-18 23:49:40 +01:00
CatchEditorPlayfield.cs Apply code feedback and also resize catcher trails when any is shown 2024-10-24 23:17:47 +02:00
CatchEditorPlayfieldAdjustmentContainer.cs Bypass Parent nullability checks for now 2023-10-17 17:48:45 +09:00
CatchHitObjectComposer.cs Simplify editor "ternary button" structure 2025-01-09 13:41:22 +01:00
CatchHitObjectInspector.cs Do not show distance to next/previous object if said object is a banana shower 2024-11-21 12:17:43 +01:00
CatchHitObjectUtils.cs Remove #nullable disable from Catch.Edit namespace 2023-01-15 17:29:32 +09:00
CatchSelectionHandler.cs Simplify implementation 2024-03-28 10:12:27 +01:00
DrawableCatchEditorRuleset.cs Apply code feedback and also resize catcher trails when any is shown 2024-10-24 23:17:47 +02:00
FruitCompositionTool.cs Refactor PlacementBlueprint to not be hitobject specific 2024-09-24 20:31:00 +02:00
JuiceStreamCompositionTool.cs Refactor PlacementBlueprint to not be hitobject specific 2024-09-24 20:31:00 +02:00
PositionRange.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00