1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-18 21:53:21 +08:00
osu-lazer/osu.Game/Overlays
Bartłomiej Dach 46d3220c07
Isolate sample screens from global mods bindable
Fixes scenario wherein entering the first run setup overlay, exiting at
the "UI scale" step (which shows a song select), then moving to actua
song select and trying to select a mod would lead to a crash.

The crash was caused by two active mod screen instances attempting to
swap the global mod bindable's mod instances for ones they owned. This
logic - while generally problematic and hard to maintain - was fixing
several issues with mod reference management and setting copying, so I'm
letting it live another day.

This change will mean that the song select preview on the "UI scale"
step will not receive the same mods that the actual game has enabled.
That said, it already doesn't use the same beatmap or ruleset, so this
looks fine to break.
2022-05-07 21:44:58 +02:00
..
AccountCreation Update screen transition events to use new event args 2022-04-22 00:52:44 +09:00
BeatmapListing Update search textbox implementation to use BasicSearchTextBox instead 2022-05-03 06:18:42 +07:00
BeatmapSet Fix IDE0005 and IDE0034 2022-05-03 13:09:19 +08:00
Changelog Remove unused params from BDL methods 2022-01-15 01:06:39 +01:00
Chat Replace HandlePositionalInput override with simple hover effect 2022-05-05 19:13:48 +09:00
Comments Use existing web localisation for most hardcoded strings 2022-04-20 16:31:11 -07:00
Dashboard Remove unused using 2022-04-21 15:34:14 +09:00
Dialog Move dangerous hold specification to base class 2022-05-06 14:34:31 +09:00
FirstRunSetup Isolate sample screens from global mods bindable 2022-05-07 21:44:58 +02:00
Login Also fix case of login form username/password 2022-04-24 17:11:25 +09:00
MedalSplash
Mods Add various xmldoc for nested classes 2022-05-08 02:03:28 +09:00
Music Update search textbox implementation to use BasicSearchTextBox instead 2022-05-03 06:18:42 +07:00
News Fix news sidebar assuming returned posts are always from given year 2022-01-19 23:13:30 +01:00
Notifications Use existing web localisation for most hardcoded strings 2022-04-20 16:31:11 -07:00
OSD Fix toast popups spamming samples when adjusting osu!mania scroll speed during gameplay 2021-12-15 12:45:23 +09:00
Profile Fix IDE0005 and IDE0034 2022-05-03 13:09:19 +08:00
Rankings Fix IDE0005 and IDE0034 2022-05-03 13:09:19 +08:00
Settings Merge pull request #16576 from frenzibyte/osu-distance-spacing 2022-05-03 12:15:18 +09:00
Toolbar Use existing web localisation for most hardcoded strings 2022-04-20 16:31:11 -07:00
Volume Globalise beatmap selection key bindings as "group" selection 2022-05-04 16:46:32 +03:00
Wiki Use existing web localisation for most hardcoded strings 2022-04-20 16:31:11 -07:00
AccountCreationOverlay.cs Remove unused params from BDL methods 2022-01-15 01:06:39 +01:00
BeatmapListingOverlay.cs Ensure old results are cleared from beatmap overlay on logout 2022-02-22 14:56:04 +09:00
BeatmapSetOverlay.cs Fix clicking anywhere in the beatmap overlay dismissing it 2022-05-02 20:27:00 +09:00
BreadcrumbControlOverlayHeader.cs Allow null for breadcrumb control 2021-07-17 20:33:26 +08:00
ChangelogOverlay.cs Remove unused params from BDL methods 2022-01-15 01:06:39 +01:00
ChatOverlay.cs Use existing web localisation for most hardcoded strings 2022-04-20 16:31:11 -07:00
ChatOverlayV2.cs Use BindableFloat for chat height 2022-05-05 23:13:32 +01:00
DashboardOverlay.cs Implement TabbableOnlineOverlay component 2021-01-18 21:22:50 +03:00
DialogOverlay.cs Remove DialogOverlay local fades (is already managed by PopupDialogs themselves) 2022-05-05 15:02:23 +09:00
FirstRunSetupOverlay.cs Use plum colour scheme in multiplayer to match rest of multiplayer screens 2022-05-05 22:16:54 +02:00
FullscreenOverlay.cs Add localisation support to overlay header title/description 2021-04-21 14:37:29 +09:00
HoldToConfirmOverlay.cs Apply batch fixing of built-in types using var 2021-10-27 13:04:41 +09:00
IDialogOverlay.cs Cache IDialogOverlay as its type in interface 2022-04-18 21:06:27 +03:00
INamedOverlayComponent.cs Add localisation support to overlay header title/description 2021-04-21 14:37:29 +09:00
INotificationOverlay.cs Add unread count to INotificationOverlay and fix toolbar button DI logic 2022-04-19 11:16:45 +09:00
IOverlayManager.cs Extract interface for overlay management 2022-05-05 22:16:55 +02:00
LoginOverlay.cs Update further ChangeFocus usages 2022-02-15 02:42:39 +03:00
MedalOverlay.cs Remove redundant arguments 2021-07-05 23:52:39 +08:00
MusicController.cs Completely remove subscription from MusicController 2022-01-25 16:53:02 +09:00
NewsOverlay.cs Pass fetch more action in via ctor to avoid potential nullref 2021-05-26 22:49:39 +09:00
NotificationOverlay.cs Use existing web localisation for most hardcoded strings 2022-04-20 16:31:11 -07:00
NowPlayingOverlay.cs Stop detaching and exposing beatmaps from MusicController 2022-01-25 16:51:21 +09:00
OnlineOverlay.cs Hoist scroll cache declaration to original place of definition 2021-06-07 11:18:18 +02:00
OnScreenDisplay.cs Fix toast popups spamming samples when adjusting osu!mania scroll speed during gameplay 2021-12-15 12:45:23 +09:00
OverlayActivation.cs
OverlayColourProvider.cs Remove static OverlayColourProviders 2022-02-20 21:09:08 +01:00
OverlayHeader.cs
OverlayHeaderBackground.cs
OverlayPanelDisplayStyleControl.cs Update mapper usages with LocalisableDescription 2021-07-31 01:47:14 +03:00
OverlayRulesetSelector.cs Revert initial ruleset value logic 2021-08-23 13:28:21 +03:00
OverlayRulesetTabItem.cs Fix tooltips not shown on selected tab 2022-04-30 15:37:44 +03:00
OverlayScrollContainer.cs Move action to private named method to avoid null inspection 2021-11-05 03:51:08 +03:00
OverlaySidebar.cs create abstract class OverlaySidebar 2021-06-04 00:12:13 +07:00
OverlaySortTabControl.cs Fix TabControls using the wrong sample 2022-04-28 17:30:24 +09:00
OverlayStreamControl.cs
OverlayStreamItem.cs Localise friends online status stream control. 2021-06-30 21:16:21 +02:00
OverlayTabControl.cs add sound to tab controls 2021-06-18 19:16:00 +09:00
OverlayTitle.cs Add localisation support to overlay header title/description 2021-04-21 14:37:29 +09:00
OverlayView.cs Revert "Allow OverlayView fetching with no API requests required" 2020-12-18 01:27:58 +03:00
RankingsOverlay.cs Add missing null checks 2021-10-05 17:59:38 +09:00
RestoreDefaultValueButton.cs Remove doubled-up opacity specification 2021-10-18 19:43:48 +02:00
SettingsOverlay.cs Add comment regarding section initialisation in ScreenBehaviour 2022-04-27 16:02:39 +09:00
SettingsPanel.cs Use new framework exposed event instead of schedule 2022-04-22 00:55:17 +09:00
SettingsSubPanel.cs Add test coverage of textbox focus in settings panels when switching between nested panels 2022-03-31 15:24:21 +09:00
SettingsToolboxGroup.cs Remove not-accessed field 2022-05-06 13:09:37 +02:00
SortDirection.cs
TabbableOnlineOverlay.cs Add login placeholder logic to OnlineOverlay 2021-02-18 18:07:24 +09:00
TabControlOverlayHeader.cs Apply batch fixing of built-in types using var 2021-10-27 13:04:41 +09:00
UserProfileOverlay.cs Update UserProfileOverlay and ClickableAvatar to treat system users more correctly 2022-03-28 22:57:16 +09:00
VersionManager.cs Move VersionManager from osu.Desktop to osu.Game 2022-01-15 19:42:38 +01:00
VolumeOverlay.cs Let selection container handle manual selection changes 2021-07-06 13:24:18 +02:00
WaveOverlayContainer.cs Use unique samples for Dialog, NowPlaying, SettingsPanel and WaveOverlay pop-in/pop-out 2021-02-10 16:04:47 +09:00
WikiOverlay.cs Remove brackets surrounding one-line statements 2022-03-04 10:14:19 +03:00