Bartłomiej Dach 2c39e1e9db Ensure submission progress sample is stopped when transitioning into a final state ...

Probably closes https://github.com/ppy/osu/issues/35138. I'm not sure. I
only got the issue to reproduce once, on dev, using a very large
archive that was uploading really slowly, and then never again.

The working theory is that basically handling of `progressSampleChannel`
is quite dodgy and it could possibly, in circumstances unknown, be
allowed to play forevermore after transitioning to failed / canceled
state. Success state does not get this treatment because it has special
logic to set progress to 1.

2c39e1e9db · 2025-09-29 15:30:45 +02:00

History

..

Components

Combine CentreMarker with MarkerVisualisation

2025-07-18 13:19:41 +03:00

Compose

Fix editor memory leak

2025-09-02 09:21:31 +09:00

Design

Enable nullability for design screen

2023-01-14 02:24:48 +03:00

GameplayTest

Use better guard (and reword subsequent comment)

2025-09-02 12:42:07 +02:00

Setup

Fix editor metadata section reload potentially confusing title and author

2025-07-31 10:58:43 +02:00

Submission

Ensure submission progress sample is stopped when transitioning into a final state

2025-09-29 15:30:45 +02:00

Timing

Fix rider EAP new naming inspections

2025-05-25 20:39:55 +09:00

Verify

pass on BeatmapManager directly

2025-08-09 11:59:20 +01:00

BackgroundDimMenuItem.cs

Use existing strings

2023-01-15 14:39:34 +03:00

BeatmapEditorChangeHandler.cs

Change the way initial state saving works in EditorChangeHandler to be closer to first change

2023-02-07 16:22:51 +09:00

BindableBeatDivisor.cs

Add divisor colour for 5,7,9 snaps

2025-07-29 13:30:04 +09:00

BookmarkController.cs

Add xmldoc for menu implying external consumption

2025-02-06 13:48:38 +09:00

BookmarkResetDialog.cs

Added warning

2025-02-03 16:47:38 +08:00

BottomBar.cs

Fix editor click-through issues on bottom bar too

2025-04-09 10:28:06 +02:00

ClipboardContent.cs

Automated #nullable processing

2022-06-17 16:37:17 +09:00

CreateNewDifficultyDialog.cs

Localise create/save dialog

2023-01-15 01:50:47 +03:00

DeleteDifficultyConfirmationDialog.cs

Fix delete dialogs having generic "Caution" header text

2024-10-07 16:46:53 +09:00

DiscardUnsavedChangesDialog.cs

Add "discard unsaved changes" operation to beatmap editor

2025-03-05 14:34:44 +01:00

Editor.cs

Resolve IBindable<WorkingBeatmap> via DI in EditorBackgroundScreen

2025-07-21 20:58:09 -07:00

EditorBeatmap.cs

Move BeatmapVersion from BeatmapInfo to IBeatmap

2025-03-17 15:04:48 +01:00

EditorBeatmapProcessor.cs

Only update combo information when any changes happened

2025-01-08 10:28:06 +01:00

EditorBeatmapSkin.cs

Enable NRT in EditorBeatmapSkin

2024-02-23 14:52:44 +01:00

EditorChangeHandler.cs

Add RestoreState() to IEditorChangeHandler

2024-06-11 11:31:30 +02:00

EditorClipboard.cs

Automated pass

2023-06-24 01:00:03 +09:00

EditorClock.cs

Do not expose track directly in EditorClock

2025-01-07 11:40:18 +01:00

EditorLoader.cs

Rename AllowBackButton to AllowUserExit and rewrite visibility flow structure

2024-11-26 16:52:39 -05:00

EditorRoundedScreenSettings.cs

Automated pass

2023-06-24 01:00:03 +09:00

EditorRoundedScreenSettingsSection.cs

Partial everything

2022-11-27 00:00:27 +09:00

EditorScreen.cs

Move workaround to subscreen

2024-05-24 10:35:33 +02:00

EditorScreenMode.cs

Localise part of editor

2023-01-15 01:50:47 +03:00

EditorScreenWithTimeline.cs

Add back incorrectly removed control point display toggle

2024-08-22 01:05:47 +09:00

EditorSkinProvidingContainer.cs

Partial everything

2022-11-27 00:00:27 +09:00

EditorState.cs

Automated #nullable processing

2022-06-17 16:37:17 +09:00

ExternalEditScreen.cs

Make everything translatable

2024-10-11 14:50:51 -04:00

HitAnimationsMenuItem.cs

Automated pass

2023-06-24 01:00:03 +09:00

IEditorChangeHandler.cs

Add RestoreState() to IEditorChangeHandler

2024-06-11 11:31:30 +02:00

LegacyEditorBeatmapPatcher.cs

Fix undoing bookmark operations potentially making them unsorted

2025-02-05 15:30:11 +01:00

ManualBreakPeriod.cs

Make (Manual)BreakPeriod a class again

2024-06-19 14:53:09 +02:00

PromptForSaveDialog.cs

Localise create/save dialog

2023-01-15 01:50:47 +03:00

SaveAndReloadEditorDialog.cs

Add "discard unsaved changes" operation to beatmap editor

2025-03-05 14:34:44 +01:00

SaveRequiredPopupDialog.cs

Simplify save dialogs

2024-07-11 12:15:17 +09:00

TableHeaderText.cs

Rewrite ControlPointTable to use virtualised list

2024-06-26 10:40:02 +02:00

TransactionalCommitComponent.cs

Change the way initial state saving works in EditorChangeHandler to be closer to first change

2023-02-07 16:22:51 +09:00

WaveformOpacityMenuItem.cs

Move timeline toggle controls to "view" menu

2024-06-17 10:16:40 +02:00