1
0
mirror of https://github.com/ppy/osu.git synced 2025-02-13 20:33:11 +08:00
osu-lazer/osu.Game/Skinning
Bartłomiej Dach 25b1443c50 Remove dead branch and mark implementation as temporary
The previous implementation was checking if the `x0` or `x2` anchors
were selected to decide on which way to transfer the drawable's scale,
but that check actually ends up being always true for corner anchors. To
visualise, this is how the corner anchors correspond to `Anchor` flags:

    x0  x1  x2
    |   |   |
y0 -O---O---O-
    |   |   |
y1 -O---+---O-
    |   |   |
y2 -O---O---O-
    |   |   |

The Os indicate where the reference anchors are on a selection box.
The first conditional eliminates the middle ones, which makes sense.
But after excluding them from further deliberations (marking via X):

    x0  x1  x2
    |   |   |
y0 -O---X---O-
    |   |   |
y1 -X---+---X-
    |   |   |
y2 -O---X---O-
    |   |   |

The remaining anchors always have `x0` or `x2` set. So to avoid
confusion, just always transfer one way for now. At some point this
should be torn out in favour of an actual implementation of the desired
behaviour.
2021-05-13 17:50:12 +02:00
..
Editor Remove dead branch and mark implementation as temporary 2021-05-13 17:50:12 +02:00
BeatmapSkinProvidingContainer.cs Reverted change to AllowConfigurationLookup and added a separate AllowColourLookup bool with config case based on lookup type in SkinProvidingContainer GetConfig call. 2021-01-13 13:07:07 -05:00
DefaultLegacySkin.cs Actually annotate the correct ctor 2021-05-12 23:53:39 +02:00
DefaultSkin.cs Merge branch 'skin-serialisation' into remove-skinnable-hud-classes 2021-05-13 19:05:08 +09:00
DefaultSkinConfiguration.cs Remove redundant logic 2019-12-25 14:55:22 +09:00
GameplaySkinComponent.cs Use char overloads for string methods 2020-10-16 11:52:29 +02:00
GlobalSkinColours.cs Move combo colours to GlobalSkinColours 2020-02-07 14:58:07 +09:00
HUDSkinComponent.cs Use char overloads for string methods 2020-10-16 11:52:29 +02:00
HUDSkinComponents.cs Remove text skin components in favour of plain LegacySpriteTexts 2021-03-13 06:05:36 +03:00
IAnimationTimeReference.cs Expose animation start time as mutable in interface 2020-11-22 13:11:22 +01:00
IPooledSampleProvider.cs Trim double full-stop in xmldoc 2020-11-30 19:43:20 +01:00
ISkin.cs Add the concept of skinnable target containers and mark a basic one for HUD elements 2021-05-11 18:39:14 +09:00
ISkinComponent.cs Introduce the concept of SkinComponents 2019-08-30 14:55:52 +09:00
ISkinnableDrawable.cs Rename ISkinnableComponent to ISkinnableDrawable 2021-05-13 17:06:00 +09:00
ISkinnableTarget.cs Merge branch 'skin-serialisation' into skin-editor-default-placement-location 2021-05-13 19:09:34 +09:00
ISkinSource.cs Turn on warnings, resolve issues 2019-04-25 17:36:17 +09:00
LegacyAccuracyCounter.cs Rename ISkinnableComponent to ISkinnableDrawable 2021-05-13 17:06:00 +09:00
LegacyBeatmapSkin.cs Use ISample everywhere in Skin GetSample lookup path 2021-02-18 18:32:28 +09:00
LegacyColourCompatibility.cs Merge remote-tracking branch 'upstream/master' into catch-combo-counter 2020-09-01 20:17:25 +03:00
LegacyFont.cs Add legacy font enum and extensions 2021-03-13 06:05:36 +03:00
LegacyHealthDisplay.cs Rename ISkinnableComponent to ISkinnableDrawable 2021-05-13 17:06:00 +09:00
LegacyJudgementPieceNew.cs Move CanBeNull specification to the interface 2020-11-20 16:30:48 +09:00
LegacyJudgementPieceOld.cs Show main judgement content above hitobjects 2020-11-20 16:25:48 +09:00
LegacyManiaSkinConfiguration.cs simplify implementation and adjust the default values 2020-12-13 22:43:36 +06:00
LegacyManiaSkinConfigurationLookup.cs add support for ScorePosition into LegacyManiaSkin 2020-12-10 20:11:08 +06:00
LegacyManiaSkinDecoder.cs Only trim trailing spaces to avoid breakage in storyboard parsing 2021-03-18 16:30:30 +09:00
LegacyRollingCounter.cs Update Legacy components to not require skin in ctor 2021-05-11 18:39:14 +09:00
LegacyScoreCounter.cs Rename ISkinnableComponent to ISkinnableDrawable 2021-05-13 17:06:00 +09:00
LegacySkin.cs SkinnableTargetWrapper -> SkinnableTargetComponentsContainer 2021-05-13 18:54:30 +09:00
LegacySkinConfiguration.cs Move hit circle font from osu! ruleset 2021-03-13 06:05:36 +03:00
LegacySkinDecoder.cs Remove unnecessary second call to StripComments in skin parsing logic 2021-03-25 13:35:42 +09:00
LegacySkinExtensions.cs Fix incorrect default font overlap for score and combo 2021-03-26 10:35:46 +03:00
LegacySkinResourceStore.cs Allow legacy skin textures from subpaths 2020-04-06 19:03:15 +09:00
LegacySkinTransformer.cs Use ISample everywhere in Skin GetSample lookup path 2021-02-18 18:32:28 +09:00
LegacySpriteText.cs Update Legacy components to not require skin in ctor 2021-05-11 18:39:14 +09:00
PausableSkinnableSound.cs Add failing test 2021-04-20 16:51:00 +09:00
PoolableSkinnableSample.cs Fix disposal rather than performing some weird hack 2021-03-19 20:30:52 +09:00
Skin.cs SkinnableTargetWrapper -> SkinnableTargetComponentsContainer 2021-05-13 18:54:30 +09:00
SkinConfigManager.cs Constrain configuration lookup as enum. 2019-12-09 17:45:26 +08:00
SkinConfiguration.cs Remove set from properties in SkinConfiguration classes 2020-08-31 17:48:36 +02:00
SkinCustomColourLookup.cs Refactor skin configuration to be infinitely extensible 2019-09-03 17:57:34 +09:00
SkinFileInfo.cs Update licence header (and remove year) 2019-01-24 17:43:03 +09:00
SkinInfo.cs Fix missed InstantiationInfo setter usages 2021-05-12 23:34:25 +02:00
SkinManager.cs Remove outdated TODO 2021-05-13 17:22:05 +09:00
SkinnableDrawable.cs Fix inspection 2021-05-13 21:59:38 +09:00
SkinnableSound.cs Fix back to front initialisation order 2021-03-20 10:51:58 +09:00
SkinnableSprite.cs Fix SkinnableSprite initialising a drawable even when the texture is not available 2020-11-18 19:03:34 +09:00
SkinnableSpriteText.cs Apply changes to UI components overriding functions with changing signatures 2021-02-22 19:01:42 +09:00
SkinnableTarget.cs Add the concept of skinnable target containers and mark a basic one for HUD elements 2021-05-11 18:39:14 +09:00
SkinnableTargetComponent.cs Add the concept of skinnable target containers and mark a basic one for HUD elements 2021-05-11 18:39:14 +09:00
SkinnableTargetComponentsContainer.cs SkinnableTargetWrapper -> SkinnableTargetComponentsContainer 2021-05-13 18:54:30 +09:00
SkinnableTargetContainer.cs SkinnableTargetWrapper -> SkinnableTargetComponentsContainer 2021-05-13 18:54:30 +09:00
SkinProvidingContainer.cs Use ISample everywhere in Skin GetSample lookup path 2021-02-18 18:32:28 +09:00
SkinReloadableDrawable.cs Add initial hit sample pooling 2020-11-19 19:51:09 +09:00
SkinStore.cs Add optional skin foreign key to databased settings 2019-05-27 01:56:19 +09:00
SkinUtils.cs Add missing license header 2019-09-05 17:01:14 +09:00