mirror of
https://github.com/ppy/osu.git
synced 2024-12-16 23:42:54 +08:00
e937b778f6
`ensureSourceClockSet()` was intended to only run when the adjustable source hasn't been set at all yet. As it turns out permitting it to run unconditionally can break the state of the underlying interpolated clock. This is caused by the following factors: * While the decoupleable clock is running, its `CurrentTime` does not come from either the source clock, or the internal stopwatch; it is instead calculated using the base `InterpolatingFramedClock` logic. * A source change of a decoupleable clock seeks the provided source clock to the decoupleable's current time. * When an interpolating clock is seeked (decoupleable clock is also an interpolating one), its interpolation state (`{Last,Current}InterpolatedTime`) are reset to 0. * If the interpolating clock determines that its current time is too far away from the source's time (which was set when the source is changed), it will ignore the source and instead continue to use its current time until the source clock has caught up. Overall, the source change is not really necessary if a source is already there. The only reason to ensure it was set was to make sure the first seek of the gameplay clock wasn't performed in decoupled mode. Therefore, add a guard to make sure the source is only set if there isn't one already. |
||
---|---|---|
.. | ||
Break | ||
HUD | ||
PlayerSettings | ||
BeatmapMetadataDisplay.cs | ||
BreakOverlay.cs | ||
BreakTracker.cs | ||
ComboEffects.cs | ||
DimmableStoryboard.cs | ||
EpilepsyWarning.cs | ||
FailAnimation.cs | ||
FailOverlay.cs | ||
GameplayBeatmap.cs | ||
GameplayClock.cs | ||
GameplayClockContainer.cs | ||
GameplayMenuOverlay.cs | ||
HotkeyExitOverlay.cs | ||
HotkeyRetryOverlay.cs | ||
HUDOverlay.cs | ||
ISamplePlaybackDisabler.cs | ||
KeyCounter.cs | ||
KeyCounterAction.cs | ||
KeyCounterDisplay.cs | ||
KeyCounterKeyboard.cs | ||
KeyCounterMouse.cs | ||
KeyCounterState.cs | ||
MasterGameplayClockContainer.cs | ||
PauseOverlay.cs | ||
Player.cs | ||
PlayerConfiguration.cs | ||
PlayerLoader.cs | ||
ReplayPlayer.cs | ||
ReplayPlayerLoader.cs | ||
ResumeOverlay.cs | ||
RoomSubmittingPlayer.cs | ||
ScreenSuspensionHandler.cs | ||
ScreenWithBeatmapBackground.cs | ||
SkipOverlay.cs | ||
SoloPlayer.cs | ||
SoloSpectator.cs | ||
SongProgress.cs | ||
SongProgressBar.cs | ||
SongProgressGraph.cs | ||
SongProgressInfo.cs | ||
SpectatorPlayer.cs | ||
SpectatorPlayerLoader.cs | ||
SpectatorResultsScreen.cs | ||
SquareGraph.cs | ||
SubmittingPlayer.cs |