62006 Commits

This Branch

This Branch

All Branches

• Merge pull request #24418 from peppy/now-playing-async-fix

  Fix now playing overlay background occasionally showing incorrect background

  Bartłomiej Dach · 2023-07-30 14:05:49 +02:00
  b51e577239
• Merge pull request #24415 from peppy/multi-spectator-improvements

  General visual improvements to mutliplayer spectatator screen

  Bartłomiej Dach · 2023-07-30 12:43:26 +02:00
  898913f32a
• Merge pull request #24361 from peppy/fix-editor-global-music-hotkey-conflicts

  Disallow interacting with the global track state in `Player` and `Editor`

  Bartłomiej Dach · 2023-07-30 12:28:53 +02:00
  e208f38bcb
• Remove pending export operation if active score is changed
  Dean Herbert · 2023-07-30 16:41:45 +09:00
  6d5b3617b3
• Don't queue export replay operations if button is disabled
  Dean Herbert · 2023-07-30 16:41:33 +09:00
  35ec55c1f6
• Add proper cancellation and out-of-order blocking logic to NowPlayingOverlay's background carousel
  Dean Herbert · 2023-07-30 16:21:35 +09:00
  de61b74e91
• Apply NRT to NowPlayingOverlay
  Dean Herbert · 2023-07-30 16:17:04 +09:00
  07d224ecb6
• Remove unnecessary async fetch of beatmap in NowPlayingOverlay

  No idea if this was historically required for some reason, but it's
  definitely not required now.

  Dean Herbert · 2023-07-30 16:16:25 +09:00
  4f83c8661a
• Disable multiplayer spectator zoom when there's only one player's screen visible
  Dean Herbert · 2023-07-30 14:40:58 +09:00
  45ceaba00d
• Add test with only one player
  Dean Herbert · 2023-07-30 14:40:24 +09:00
  feea412bec
• Adjust xmldoc to explicitly metnion it only affects end user control
  Dean Herbert · 2023-07-30 13:52:58 +09:00
  7138291636
• Move disables to loading screens for better coverage of edge cases
  Dean Herbert · 2023-07-30 13:45:42 +09:00
  945d89e955
• Update BreakInfoLine to formatting standards
  Joseph Madamba · 2023-07-29 11:05:15 -07:00
  4ddf05602f
• Remove unnecessary text comparison
  Joseph Madamba · 2023-07-29 11:02:04 -07:00
  6ebfafa9c3
• fix Possible NullReferenceException in test
  cdwcgt · 2023-07-30 02:56:52 +09:00
  404a927caf
• remove useless using
  cdwcgt · 2023-07-30 02:50:16 +09:00
  99dd156d53
• revert test change
  cdwcgt · 2023-07-30 02:49:30 +09:00
  5d09eca104
• remove nullable for Box
  cdwcgt · 2023-07-30 02:49:13 +09:00
  ba80d1e2d5
• string mod should not null

  Already assigned in the constructor

  cdwcgt · 2023-07-30 02:41:45 +09:00
  0590121309
• move to initialiser
  cdwcgt · 2023-07-30 02:41:45 +09:00
  bc2ca11bb0
• remove null check for b.Beatmap
  cdwcgt · 2023-07-30 02:41:44 +09:00
  a1f0e59784
• use no null when true
  cdwcgt · 2023-07-30 02:41:25 +09:00
  6ad8339c66
• Remove unnecessary prefix parameter
  Joseph Madamba · 2023-07-29 10:40:18 -07:00
  740898dffb
• Apply NRT to BreakInfoLine
  Joseph Madamba · 2023-07-29 10:39:50 -07:00
  9d928c0225
• Hide toolbar when entering multiplayer spectator
  Dean Herbert · 2023-07-30 02:29:14 +09:00
  75625f089e
• Further refactorings along with shadow implementation
  Dean Herbert · 2023-07-30 02:29:14 +09:00
  38244c081f
• Improve animation and sizing of maximised screen display
  Dean Herbert · 2023-07-30 02:29:14 +09:00
  84bc14c1dd
• Move Facade to nested class
  Dean Herbert · 2023-07-30 02:29:14 +09:00
  1826819663
• Add corner radius around player areas
  Dean Herbert · 2023-07-30 02:29:14 +09:00
  5fa0a21b56
• Moved enum to bottom of enumeration table
  QuantumSno · 2023-07-29 13:18:47 -04:00
  65b4ae506e
• remove all canBeNull from attribute
  cdwcgt · 2023-07-30 01:57:54 +09:00
  88a1cf4005
• fix nullable for TeamList
  cdwcgt · 2023-07-30 01:49:57 +09:00
  9482f74456
• RemoveTeam shouldn't have nullable arg
  cdwcgt · 2023-07-30 01:40:13 +09:00
  cb4adf115c
• debug assert closest != null
  cdwcgt · 2023-07-30 01:39:56 +09:00
  625ed729ee
• use cast instead AsNonNull
  cdwcgt · 2023-07-30 01:39:31 +09:00
  033c9091c0
• Merge pull request #24386 from peppy/fix-autoplay-mod-revert

  Fix temporary auto mod (ctrl+enter at song select) not reverting in all scenarios

  Bartłomiej Dach · 2023-07-29 16:43:46 +02:00
  55cb400674
• Merge branch 'master' into fix-autoplay-mod-revert
  Bartłomiej Dach · 2023-07-29 16:12:11 +02:00
  579b0bc570
• Fix wrong test step name
  Bartłomiej Dach · 2023-07-29 16:12:02 +02:00
  43a51671ac
• null check in test
  cdwcgt · 2023-07-29 22:41:26 +09:00
  4c33013674
• remove #nullable disable in tournament
  cdwcgt · 2023-07-29 22:25:06 +09:00
  8a06914438
• Fix accuracy break info decimal separator being incorrect in certain languages
  Joseph Madamba · 2023-07-28 23:26:07 -07:00
  a3301dc7ff
• Merge pull request #24405 from bdach/spinner-input-test
  Dean Herbert · 2023-07-29 11:34:45 +09:00
  a7ff084be2
• Fix tests crashing due to HUDOverlay not finding DrawableRuleset in Update()
  Bartłomiej Dach · 2023-07-29 01:07:49 +02:00
  1fd4a6dc96
• Add test scene for checking spinner judgements
  Bartłomiej Dach · 2023-07-29 00:49:21 +02:00
  cd416e09f9
• Merge pull request #24360 from peppy/spinner-faster-rotation

  Change spinner rotation animation to match input 1:1

  Bartłomiej Dach · 2023-07-29 00:48:56 +02:00
  c21167e2ab
• Merge branch 'master' into playfield-skin-layer
  Bartłomiej Dach · 2023-07-29 00:01:06 +02:00
  4db203ecc3
• Merge pull request #24389 from peppy/ladder-grid-expand

  Allow ladder editor grid to scale with content

  Bartłomiej Dach · 2023-07-28 23:40:40 +02:00
  35defd97e1
• Fix non-compiling test

  To be fair, currently the test is a bit pointless (as it has no reason
  to be a `SkinnableTestScene`, it gains precisely nothing from it - all
  that is shown there is some generic components on song select). But that
  is no worse then `master`, so look away for now.

  Bartłomiej Dach · 2023-07-28 23:36:57 +02:00
  aca8310cd1
• Use better safety in rectangular grid

  - Checking `DrawSize != Vector2.Zero` is too specific. It could also
    crash on zero-height-but-non-zero-width, or
    zero-width-but-non-zero-height.
  
  - Take the `gridCache.Validate()` call out of the zero checks, because
    even if the width or height are zero, not generating anything is valid
    and there is no reason to validate every frame until `gridCache` gets
    invalidated again.

  Bartłomiej Dach · 2023-07-28 22:57:02 +02:00
  c6f0cf50ca
• Merge branch 'master' into ladder-grid-expand
  Bartłomiej Dach · 2023-07-28 22:51:33 +02:00
  0c10d875ce