osu-lazer

Add test coverage showing selection not being held post-filter when difficulties are being split out

Dean Herbert · 2025-09-10 16:37:16 +09:00

fa6b830a13

Fix realm not being cached in beatmap carousel tests

Dean Herbert · 2025-09-10 16:37:12 +09:00

278b232318

Fix one more failing test

Dean Herbert · 2025-09-10 02:41:27 +09:00

014b55602d

Fix multiple failing song select tests

Dean Herbert · 2025-09-10 01:31:15 +09:00

0cd3894fa6

Adjust song select debounce to be high than repeat_initial_delay

I'm doing this silently to see if any users complain without being told
about the change. Without this, when holding left arrow for short
bursts, precisely *one* beatmap change happens before actual key repeat
kicks in, which feels really weird (updates the leaderboard / background
unexpectedly).

This is the simplest way to resolve the issue, so if users aren't
offended by it I think we should commit to it.

Personally it's still fast enough to not annoy me at all.

Dean Herbert · 2025-09-09 19:11:50 +09:00

2bd734918a

Update framework

Dean Herbert · 2025-09-09 18:02:02 +09:00

6362fed097

Update resources

Dean Herbert · 2025-09-09 18:01:06 +09:00

16594f2986

Merge pull request #34956 from peppy/bpm-filtering-less-precise

Adjust BPM filtering at song select to be less precise

Dean Herbert · 2025-09-09 17:33:49 +09:00

68e7af0c02

Merge pull request #34920 from cl8n/retro-skin

Add "retro" default skin

Dean Herbert · 2025-09-09 15:48:12 +09:00

caad065433

Merge pull request #34932 from Joehuu/fix-argon-judgement-colored-numbers

Fix `ArgonJudgementCounterDisplay` not showing colored numbers when "Show label" is off

Dean Herbert · 2025-09-09 15:20:49 +09:00

11696a7a3c

Adjust BPM filtering at song select to be less precise

Closes https://github.com/ppy/osu/issues/34942.

Dean Herbert · 2025-09-09 15:02:57 +09:00

f94d5004ea

Guard against ArgonJudgementCounterDisplay crashing due to fuckery

I can't see how this can happen in a normal flow, so just doing it as a
safety measure. Pointed out in https://github.com/ppy/osu/issues/34940
but likely due to a third party fuck being loaded.

Dean Herbert · 2025-09-09 14:56:21 +09:00

335bc6cdf6

Merge pull request #34952 from peppy/rank-display-rate-limit-change

Change debounce method in rank display to allow more immediate updates

Dean Herbert · 2025-09-08 17:23:56 +09:00

eb24e02c38

Change debounce method in rank display to allow more immediate updates

Dean Herbert · 2025-09-08 15:12:49 +09:00

06c1b81c1b

Merge pull request #34948 from Joehuu/fix-sheared-dropdown-click-sound-area

Fix sheared dropdown click sound area

Dean Herbert · 2025-09-08 13:40:15 +09:00

35885a17b4

Fix sheared dropdown click sound area

Joseph Madamba · 2025-09-07 11:00:26 -07:00

c2bc67d083

Fix external edit filename sanitising unintentionally dropping folder separators (#34945 )

* Add failing test coverage showing external edits not working with folders

* Fix external edit filename sanitising unintentionally dropping folder separators

Closes https://github.com/ppy/osu/issues/34929.

Dean Herbert · 2025-09-07 21:47:20 +09:00

645518f5bd

Fix ArgonJudgementCounterDisplay not showing colored numbers when "Show label" is off

Joseph Madamba · 2025-09-05 12:25:40 -07:00

18b5c652a3

Replace old-skin with retro skin in tests

clayton · 2025-09-05 21:21:52 +09:00

3c1c537b1b

Add "retro" default skin

clayton · 2025-09-05 21:21:52 +09:00

6af48975b0

Update resources

Dean Herbert · 2025-09-05 21:20:12 +09:00

058835440d

Update resources

Dean Herbert · 2025-09-05 19:16:47 +09:00

ea79422b60

Merge pull request #34905 from NiyazBiyaz/update-rank-display

Fix `rank-up` and `rank-down` sounds playing too often in some scenarios

Dean Herbert · 2025-09-05 16:53:55 +09:00

2025.905.0 2025.905.0-tachyon 543d21a0ce

Improve initial state handling

Dean Herbert · 2025-09-05 16:19:55 +09:00

ab7985f31e

Change DefaultRankDisplay to start with no value

Dean Herbert · 2025-09-05 16:10:27 +09:00

52c10a42be

Change debounce to be delayed since last actual change to avoid state flickering

Dean Herbert · 2025-09-05 16:10:12 +09:00

912c0a39cf

Simplify implementation

Dean Herbert · 2025-09-05 16:01:22 +09:00

45ef97c92c

Fix rank-up and rank-down sounds playing too often in some scenarios

NiyazBiyaz · 2025-09-05 15:41:04 +09:00

54d4b16a01

Merge pull request #34917 from smoogipoo/matchmaking-pool-model

Replace MatchmakingSettings with MatchmakingPool

Dean Herbert · 2025-09-05 15:26:49 +09:00

54a0c7af23

Merge pull request #34914 from bdach/error-on-exiting-editor

Fix errors on exiting from editor if there are no more beatmaps remaining for the ruleset active in song select

Dean Herbert · 2025-09-05 15:24:07 +09:00

891b717b3d

Merge pull request #34903 from peppy/song-select-better-debounce

Fix song select debounce not handling long (stutter) frames well

Dean Herbert · 2025-09-05 15:02:53 +09:00

11e1c2d73f

Add GetMatchmakingPools server method

Dan Balasescu · 2025-09-05 14:40:58 +09:00

4475bcafa9

Replace MatchmakingSettings with MatchmakingPool

Dan Balasescu · 2025-09-05 14:40:48 +09:00

32576ff249

Fix broken reselection logic

d4b357dfa0 contains a sneaky regression.
The previous code read:

    if (CurrentSelection != null && CheckModelEquality(beatmap, CurrentSelection))
	RequestSelection(matchingNewBeatmap);

and the new one reads:

    if (CurrentSelection is GroupedBeatmap currentBeatmapUnderGrouping)
    {
	var candidateSelection = currentBeatmapUnderGrouping with { Beatmap = beatmap };
	if (CheckModelEquality(candidateSelection, CurrentSelection))
	    RequestSelection(candidateSelection);
    }

The point is that we want to reselect `matchingNewBeatmap` here, not the
old selection. The `CheckModelEquality()` check's purpose is to check
whether *the current selection needs updating*.

I'm not sure why tests just wonderfully passed despite this, but my
suspicion is that it was because of accidental copying of realm guids
that obscured this problem.

Bartłomiej Dach · 2025-09-04 13:11:31 +02:00

134f854d7b

Fix test failing because of new realm check

Bartłomiej Dach · 2025-09-04 12:44:36 +02:00

bae288859b

Ensure that matching beatmap still exists when performing replace operation in the carousel

Bartłomiej Dach · 2025-09-04 12:44:18 +02:00

6e5bf57fe7

Merge pull request #34912 from peppy/matchmaking-model-types

Add matchmaking model types required for server-side deploy

Dean Herbert · 2025-09-04 19:32:07 +09:00

2025.904.0 0027b9846d

Add variant to MatchmakingSettings

Dean Herbert · 2025-09-04 18:43:46 +09:00

1627f67ada

Add matchmaking model types required for server-side deploy

Dan Balasescu · 2025-09-04 18:26:56 +09:00

815bf9c37b

Fix multiple concerns with new debounce logic

Tried many approaches but this seems simplest to guarantee no test (or
other) regressions..

Dean Herbert · 2025-09-04 18:13:16 +09:00

b0c7b6c700

Merge pull request #34911 from bdach/fix-no-report-in-playlists

Fix not being able to report users from playlists chat

Dean Herbert · 2025-09-04 17:08:08 +09:00

3fcc8d45cb

Merge pull request #34904 from bdach/local-rank-includes-unproven-scores

Treat guest user scores & scores of unknown users as the local user's

Dean Herbert · 2025-09-04 17:06:51 +09:00

f1d06f796a

Fix not being able to report users from playlists chat

Reported internally.

Bartłomiej Dach · 2025-09-04 09:45:32 +02:00

be365dfdc5

Change debounce consideration to use dynamic FPS moving average rather than fixed 60 fps

This should better account for scenarios where user FPS is below 60 fps.
Previously the debounce would unexpectedly be longer than usual for low
FPS scenarios.

Dean Herbert · 2025-09-04 02:19:28 +09:00

b2501ae58f

Merge pull request #32297 from LukynkaCZE/argon-judgement-counter