h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-06-09 04:13:39 +08:00
Code Issues Releases Wiki Activity

Improve initial state handling

Browse Source
This commit is contained in:
Dean Herbert
2025-09-05 16:19:55 +09:00
Unverified
parent 52c10a42be
commit ab7985f31e
2 changed files with 19 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game/Screens/Play/HUD/DefaultRankDisplay.cs
+9 -2
View File
@@ -63,6 +63,13 @@ namespace osu.Game.Screens.Play.HUD
lastSamplePlayback = statics.GetBindable<double?>(Static.LastRankChangeSamplePlaybackTime);
}
protected override void LoadComplete()
{
base.LoadComplete();
updateRank(scoreProcessor.Rank.Value);
}
protected override void Update()
{
base.Update();
@@ -75,7 +82,7 @@ namespace osu.Game.Screens.Play.HUD
return;
}
if ((timeSinceChange += Time.Elapsed) >= time_before_commit || scoreProcessor.HasCompleted.Value)
if ((timeSinceChange += Time.Elapsed) >= time_before_commit || scoreProcessor.HasCompleted.Value || currentRank == ScoreRank.F)
updateRank(currentRank);
}
@@ -87,7 +94,7 @@ namespace osu.Game.Screens.Play.HUD
bool enoughSampleTimeElapsed = !lastSamplePlayback.Value.HasValue || Time.Current - lastSamplePlayback.Value >= OsuGameBase.SAMPLE_DEBOUNCE_TIME;
// Also don't play rank-down sfx on quit/retry/initial update.
if (rank != displayedRank && rank > ScoreRank.F && PlaySamples.Value && enoughSampleTimeElapsed && displayedRank != null)
if (displayedRank != null && rank > ScoreRank.F && PlaySamples.Value && enoughSampleTimeElapsed)
{
if (rank > displayedRank)
rankUpSample.Play();
osu.Game/Skinning/LegacyRankDisplay.cs
+10 -3
View File
@@ -67,6 +67,13 @@ namespace osu.Game.Skinning
lastSamplePlayback = statics.GetBindable<double?>(Static.LastRankChangeSamplePlaybackTime);
}
protected override void LoadComplete()
{
base.LoadComplete();
updateRank(scoreProcessor.Rank.Value);
}
protected override void Update()
{
base.Update();
@@ -79,7 +86,7 @@ namespace osu.Game.Skinning
return;
}
if ((timeSinceChange += Time.Elapsed) >= time_before_commit || scoreProcessor.HasCompleted.Value)
if ((timeSinceChange += Time.Elapsed) >= time_before_commit || scoreProcessor.HasCompleted.Value || currentRank == ScoreRank.F)
updateRank(currentRank);
}
@@ -89,7 +96,7 @@ namespace osu.Game.Skinning
rankDisplay.Texture = texture;
if (texture != null)
if (texture != null && displayedRank != null)
{
var transientRank = new Sprite
{
@@ -111,7 +118,7 @@ namespace osu.Game.Skinning
bool enoughSampleTimeElapsed = !lastSamplePlayback.Value.HasValue || Time.Current - lastSamplePlayback.Value >= OsuGameBase.SAMPLE_DEBOUNCE_TIME;
// Also don't play rank-down sfx on quit/retry/initial update.
if (rank != displayedRank && rank > ScoreRank.F && PlaySamples.Value && enoughSampleTimeElapsed && displayedRank != null)
if (displayedRank != null && rank > ScoreRank.F && PlaySamples.Value && enoughSampleTimeElapsed)
{
if (rank > displayedRank)
rankUpSample.Play();