Dan Balasescu
768cd6d4d8
Merge pull request #13446 from ekrctb/catcher-area-movement-logic
...
Move catcher movement logic of `Catcher` to `CatcherArea`
2021-06-11 19:42:54 +09:00
Jamie Taylor
15d3b4444d
Rename HoverSounds and HoverClickSounds samples
2021-06-11 19:34:54 +09:00
Robin Avery
635300b311
Recalculate closest anchor when origin is changed
2021-06-11 06:28:30 -04:00
Bartłomiej Dach
e194f8b34a
Replace lifetime workaround with explicit set
2021-06-11 12:26:58 +02:00
Robin Avery
a506f2a776
Revert rename of lambda variables
2021-06-11 06:22:24 -04:00
Bartłomiej Dach
7bb27bfd0e
Add test scene for hidden mod
2021-06-11 12:17:38 +02:00
Salman Ahmed
f20146d446
Fix potentially adding null skin sources
2021-06-11 12:58:38 +03:00
Salman Ahmed
fbb856d84b
Call base when overriding lookup methods
...
Rather than arbitrarily accessing `Skin` here and there.
2021-06-11 12:44:44 +03:00
Salman Ahmed
e59beffc4e
Forward all base transformer lookup methods to Skin
2021-06-11 12:44:25 +03:00
Salman Ahmed
9e16359f18
Refactor disallowing in SkinProvidingContainer to become per source
...
Fixes `FindProvider` becoming completely broken, because of no way to perform the checks on one skin source.
2021-06-11 12:29:29 +03:00
ekrctb
af3f253b21
Refactor ScrollingHitObjectContainer and expose more useful methods
2021-06-11 18:28:48 +09:00
Ivan Pavluk
6d06066dde
forgot to run code inspection
2021-06-11 15:54:48 +07:00
Dean Herbert
8eab7df955
Move BindCollectionChanged out of async load
2021-06-11 17:51:58 +09:00
Salman Ahmed
2e01e61177
Move TODO comment to correct location
2021-06-11 11:46:30 +03:00
Salman Ahmed
8132852753
Add other affectable change action cases
2021-06-11 11:34:22 +03:00
Dean Herbert
956c4ba225
Merge pull request #13445 from ekrctb/fix-catch-test-legacy-skin
...
Specify legacy skin version of `old-skin` test skin
2021-06-11 17:29:30 +09:00
Salman Ahmed
a985e3b8d3
Apply documentation settings for better readability
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
2021-06-11 11:25:07 +03:00
Ivan Pavluk
e34e26ae52
remove outdated comment
2021-06-11 15:12:05 +07:00
Ivan Pavluk
09df23e2a6
improve reasoning for hd_sv_scale
2021-06-11 15:07:41 +07:00
Dan Balasescu
434c7b69d2
Merge pull request #13447 from bdach/missing-event-null-check
...
Add missing `CurrentSkin` null check in DHO disposal
2021-06-11 16:56:34 +09:00
Dean Herbert
20759657de
Rename configuration variables and refactor lots more
2021-06-11 16:37:31 +09:00
Dean Herbert
3d645608eb
Remove nullability of DI dependencies and fix incorrect load order
2021-06-11 16:28:53 +09:00
Dean Herbert
139401a04a
Inline and refactor overly verbose MessageNotifier code
2021-06-11 16:27:31 +09:00
Bartłomiej Dach
296761ade5
Add missing CurrentSkin null check in DHO disposal
2021-06-11 09:18:58 +02:00
Dean Herbert
16e3a19738
Fix notification overlay not being in correct place in test scene
2021-06-11 16:18:51 +09:00
Dean Herbert
f00967388a
Refactor tests a bit
2021-06-11 16:17:42 +09:00
Dean Herbert
c00f9ae4b7
Reword settings text
2021-06-11 16:11:37 +09:00
Ivan Pavluk
46b379899e
add taiko hd mod (2nd attempt)
2021-06-11 14:09:23 +07:00
Dean Herbert
33aec57238
Replace 1.0 version in old skin test assets with none
2021-06-11 15:45:34 +09:00
ekrctb
7f7c2c73e0
Move catcher movement logic of Catcher to CatcherArea
2021-06-11 15:39:06 +09:00
ekrctb
8d0840020b
Specify legacy skin version of old-skin testing skin
...
Old-style catcher sprite is not supported for all versions
2021-06-11 15:33:13 +09:00
Dean Herbert
04413f1634
Merge pull request #13444 from peppy/editor-timeline-taiko-hit-colouring
...
Show osu!taiko centre/rim colouring in editor timeline
2021-06-11 15:10:24 +09:00
Dean Herbert
debd359d2e
Update xmldoc
2021-06-11 14:50:21 +09:00
Dean Herbert
b9050f91a4
Expose as Skins and consume SkinInfo from instances
2021-06-11 14:49:35 +09:00
Dean Herbert
562cfe8703
Fix filename not matching type rename
2021-06-11 14:34:18 +09:00
Dean Herbert
9c34cb0777
Share colour constants with default drawable piece implementations
2021-06-11 14:20:08 +09:00
Dan Balasescu
97375d9625
Merge pull request #13438 from bdach/more-metadata-fields
...
Add remaining metadata fields to editor setup screen
2021-06-11 14:17:34 +09:00
Dean Herbert
bc3b7233ab
Show osu!taiko centre/rim colouring in editor timeline
...
Closes #13443 .
2021-06-11 14:17:30 +09:00
Dan Balasescu
1e5dc7aac6
Merge pull request #13443 from peppy/timing-screen-layout-fixes
...
Fix negative offsets incorrectly wrapping in timing screen
2021-06-11 14:15:39 +09:00
Bartłomiej Dach
375f64ffd1
Check empty string more explicitly in IsRomanised()
...
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
2021-06-11 06:38:53 +02:00
Bartłomiej Dach
7fd26ff3b0
Merge branch 'master' into more-metadata-fields
2021-06-11 06:35:51 +02:00
Dean Herbert
38bf04d7ff
Give more space for time values to allow for negative offsets
2021-06-11 13:25:09 +09:00
Bartłomiej Dach
385554b01a
Merge pull request #13434 from ilsubyeega/patch-2
...
Add `star` keyword to `FilterQueryParser` criteria
2021-06-11 01:10:36 +02:00
Bartłomiej Dach
24c249b17e
Add test coverage
2021-06-10 22:40:49 +02:00
Bartłomiej Dach
417aaacc53
Add test coverage for romanised data transfer
2021-06-10 22:18:39 +02:00
Bartłomiej Dach
e41a5a0fcd
Add romanised author & title fields
2021-06-10 22:17:45 +02:00
ilsubyeega-desu
f65f074131
Add star keyword to FilterQueryParser criteria
2021-06-11 02:46:29 +09:00
Salman Ahmed
2240e2c39c
Refrain from attempting to clear skin sources in disposal
...
`Drawable.Dispose` is usually in an asynchronous context (async disposals stuff) and therefore this could cause a "collection was modified; enumeration opeartion may not execute" exception.
2021-06-10 17:23:16 +03:00
Salman Ahmed
680791301f
Consume new method rather than caching skin sources on top of Player
2021-06-10 16:36:46 +03:00
Salman Ahmed
23d6c366ac
Add method for assigning arbitrary skins to player in test scenes
2021-06-10 16:36:46 +03:00
