1
0
mirror of https://github.com/ppy/osu.git synced 2024-09-22 05:27:23 +08:00
Commit Graph

58 Commits

Author SHA1 Message Date
Dan Balasescu
f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
Dean Herbert
c661f2b059 Ensure ChannelManager has access to API from point of construction
Closes https://github.com/ppy/osu/issues/18451.
2022-06-08 19:15:23 +09:00
Jai Sharma
2f635fa854 Refactor ChatLine and fix DrawableChannel flow padding
Refactors `ChatLine` component to use more sensible override properties
and layout using grid container. Moves creation of username component
into its own method to simplify BDL.

Updates padding of base `DrawableChannel` flow padding.

Removes usage of `ChatOverlayDrawableChannel` since it's overrides are
no longer needed.

Updates usage of `StandAloneChatDisplay` to use new override properties
of `DrawableChannel`.
2022-06-07 22:35:45 +01:00
Dean Herbert
0981d415a1 Select correct channel regardless of load order 2022-05-30 17:57:48 +09:00
Dean Herbert
f65d2db77f Remove "V2" suffix from ChatOverlay components 2022-05-30 17:54:09 +09:00
Jai Sharma
8f596520f3 Remove old chat overlay components 2022-05-29 20:08:43 +01:00
Salman Ahmed
34adc1d410 Add quick test coverage 2022-04-08 19:21:37 +03:00
Salman Ahmed
46e66e66e4 Make opening chat overlay opt-in to add coverage for unloaded chat overlays
Causes `TestHighlightWhileChatNeverOpen` to fail as expected.
2022-03-17 08:19:40 +03:00
Salman Ahmed
a31611bdec Improve channel switching flow in HighlightMessage 2022-03-10 23:07:15 +03:00
Salman Ahmed
e419370830 Add test coverage for highlighting message on left channel 2022-03-10 21:30:02 +03:00
Salman Ahmed
d4de435eb2 Add test case for highlighting while chat overlay is hidden 2022-03-10 02:50:27 +03:00
Salman Ahmed
741702549b Add test coverage for chat overlay message highlighting 2022-03-07 05:10:49 +03:00
Dan Balasescu
488374b4a2 Don't show multiplayer channels in chat overlay 2021-12-16 16:41:47 +09:00
Dean Herbert
1eed2436e6 Clean up unused resolved properties 2021-12-03 18:49:49 +09:00
Dean Herbert
0ecf5f201c Rename User to APIUser and move to correct namespace 2021-11-07 11:26:01 +09:00
Dean Herbert
6944151486 Apply batch fixing of built-in types using var 2021-10-27 13:04:41 +09:00
Bartłomiej Dach
00732822c3
Replace insufficiently specific exception type
Resolves compilation failures for the newly-added Android build-only CI
job caused by inspection CA2201 ("Exception type System.Exception is not
sufficiently specific").
2021-10-24 17:45:39 +02:00
Bartłomiej Dach
12da27cde7
Add test coverage for loading process on channel join 2021-10-05 20:52:40 +02:00
Bartłomiej Dach
3467b1f60c
Retouch chat command test slightly 2021-09-12 13:00:52 +02:00
Davran Dilshat
eeaa8a8380 code quality 2021-09-11 16:47:20 +01:00
Davran Dilshat
605933c467 typo 2021-09-11 16:23:17 +01:00
Davran Dilshat
7924a990a3 add tests for /chat command 2021-09-11 16:22:35 +01:00
Dean Herbert
118e13227a Update existing test to make use of ManualInputManager.Keys 2021-08-03 19:08:59 +09:00
ekrctb
1bac471b49 Adapt to PlatformAction type change 2021-07-21 16:12:53 +09:00
smoogipoo
1b2d00f796 Trigger successes 2021-06-29 20:13:39 +09:00
Bartłomiej Dach
e117f98bfa Rename test steps 2021-06-03 14:31:13 +02:00
Dean Herbert
b917d6d80c Update tests to check for correct platform action keys 2021-06-03 15:34:06 +09:00
Dean Herbert
aa23c4a4b9
Merge branch 'master' into keyboard_shortcuts 2021-05-27 16:30:34 +09:00
Dean Herbert
aeff9bd853 Add return bool to HandleRequest to better trigger failures 2021-03-23 18:17:29 +09:00
Angela Zhang
7d326c7f24 Review changes + added tests 2020-12-20 13:18:00 -06:00
Angela Zhang
45482e8709 Whitespace fixes 2020-12-17 18:43:39 -06:00
Angela Zhang
454c7538c0 CI Style Fixes 2020-12-17 17:59:36 -06:00
Angela Zhang
cbfa292c05 Minor test style fixes 2020-12-17 16:59:19 -06:00
Jess Meng
8bd787dce9 Moved private methods beneath public ones 2020-12-15 20:50:23 -08:00
Jess Meng
7fe7c24ce1 Style fixes for whitespaces 2020-12-14 15:44:40 -08:00
Jess Meng
017e00eb26 More style fixes 2020-12-14 15:27:57 -08:00
Angela Zhang
1af0f79ddf
Adding newline style fixes 2020-12-14 16:58:43 -06:00
Jess Meng
9cb0ed3b8f Fixed formatting for tests 2020-12-14 12:38:59 -08:00
Jess Meng
ccbf6db810 Fixed some formatting and style 2020-12-13 22:11:52 -08:00
Jess Meng
35f403dacd Added tests for ctrl + w and ctrl + t 2020-12-13 22:05:54 -08:00
Joehu
ef3c918a3c Simplify input buttons/keys in tests 2020-11-09 14:18:20 -08:00
Dean Herbert
3c7e5a5b42 Fix ChannelManager not being loaded in tests 2020-06-03 18:00:31 +09:00
smoogipoo
648999a2de Remove all RequiredTypes usages 2020-05-16 18:17:12 +09:00
Dean Herbert
0b728f483f Rename base test class to help avoid incorrect reference 2020-03-23 10:01:33 +09:00
TheWildTree
4153f8d49d Fix edge case making test fail
Forgot that if a PM channel was the last tab, it hid itself upon selecting due to changing its width, which made the last-visible-selected assert fail. Made this particular test only use non-PM channels.
2020-03-16 21:31:22 +01:00
TheWildTree
0f40671e69 Mix normal channel tabs with PM ones 2020-03-16 19:44:03 +01:00
TheWildTree
50c2e65e3c Improve TestSceneChatOverlay 2020-03-16 19:10:42 +01:00
TheWildTree
38d00c7f0a Revert unnecessary changes and actually trim the whitespace 2020-03-13 21:29:10 +01:00
TheWildTree
8d3cab0e16 Trim whitespace 2020-03-13 18:58:32 +01:00
TheWildTree
0bbae094dd Add active tab closing behaviour tests 2020-03-13 18:34:51 +01:00