3347 Commits

• Merge pull request #13517 from ekrctb/initial-entry

  Allow setting `Entry` of `PoolableDrawableWithLifetime` (including `DrawableHitObject`)

  Dean Herbert · 2021-06-19 00:03:41 +09:00
  89c27dcb10
• Remove unused using statement
  Dean Herbert · 2021-06-18 19:39:01 +09:00
  2dadc9d686
• Fix renaming a ruleset DLL causing a startup crash
  Dean Herbert · 2021-06-18 19:32:40 +09:00
  78c5ccda60
• Add xmldoc remark
  smoogipoo · 2021-06-18 19:27:10 +09:00
  42c5a962fb
• Don't set entry immediately
  smoogipoo · 2021-06-18 19:23:37 +09:00
  36d51d5117
• Add exception on Apply() while loading
  smoogipoo · 2021-06-18 19:20:57 +09:00
  36d2199a02
• Merge pull request #13499 from ekrctb/fix-mania-editor-crash

  Rewrite mania selection blueprint to use only `HitObject` (no `DrawableHitObject`) for layout

  Dan Balasescu · 2021-06-18 15:10:28 +09:00
  2cd72a92e8
• Merge branch 'master' into fix-mania-editor-crash
  Dan Balasescu · 2021-06-18 13:49:25 +09:00
  cdc1c60fab
• Move IApplicableToDrawableHitObjects to its own file
  smoogipoo · 2021-06-18 13:06:13 +09:00
  97cd1217a4
• Merge pull request #13523 from ekrctb/applicable-to-dho

  Reduce boilerplate of `IApplicableToDrawableHitObjects` by taking a single DHO instead of an enumerable

  Dan Balasescu · 2021-06-17 19:59:06 +09:00
  6cec1145e3
• Remove redundant NotNull attributes in nullable classes
  Dean Herbert · 2021-06-17 16:07:32 +09:00
  9495f87f04
• Use property instead of backing field consistently
  ekrctb · 2021-06-17 10:31:20 +09:00
  e7954ecb60
• Remove IPlayfieldProvider by caching Playfield
  ekrctb · 2021-06-17 10:15:24 +09:00
  9dcd0bf311
• Merge branch 'master' into fix-mania-editor-crash
  Bartłomiej Dach · 2021-06-16 18:26:33 +02:00
  418dbf3f3e
• Merge branch 'master' into applicable-to-dho
  ekrctb · 2021-06-16 22:04:10 +09:00
  b6a9fa9999
• Merge branch 'master' into refactor-scrolling-hoc-2
  Dan Balasescu · 2021-06-16 19:20:11 +09:00
  6613301588
• Obsolete plural IApplicableToDrawableHitObjects
  ekrctb · 2021-06-16 18:52:16 +09:00
  c59a3ce83f
• Implement IApplicableToDrawableHitObject for mods

  A breaking change in `ModWithVisibilityAdjustment` if the method was overriden.

  ekrctb · 2021-06-16 18:52:01 +09:00
  af80418ee8
• Use singular IApplicableToDrawableHitObject for consumers
  ekrctb · 2021-06-16 18:47:04 +09:00
  67d8e0059f
• Add IApplicableToDrawableHitObject that is taking a single DHO

  Less cumbersome to implement than old version taking an enumerable. The implementation was always using `foreach` for the enumerable.
  The new interface is not used yet.

  ekrctb · 2021-06-16 18:42:28 +09:00
  e69bb67afe
• Allow setting Entry of PoolableDrawableWithLifetime

  It is more convenient than using the constructor because the only limited kind of expression is allowed in a base constructor call.
  Also, the object initializer syntax can be used.

  ekrctb · 2021-06-16 16:00:08 +09:00
  117e94bc94
• Merge branch 'master' into enhance-mod-settings-text-box-visibility
  Dan Balasescu · 2021-06-15 16:09:55 +09:00
  e9d4ee3c87
• Introduce IPlayfieldProvider
  ekrctb · 2021-06-15 14:43:04 +09:00
  ef96ceb4ab
• Use natural anchor for TimeAtPosition and PositionAtTime

  The natural anchor is the end of the scrolling direction (e.g. Bottom for Down scrolling).

  ekrctb · 2021-06-15 13:15:20 +09:00
  bbf0022689
• Improve xmldoc
  Bartłomiej Dach · 2021-06-14 21:54:55 +02:00
  cb1e2e3d97
• Clarify multiple coordinate systems

  - Fix wrong position is set for DHOs for down/right scrolling direction.

  ekrctb · 2021-06-14 13:13:27 +09:00
  660bf50dc7
• Fix TimeAtPosition doc comment
  ekrctb · 2021-06-14 13:13:27 +09:00
  09f1cbde7e
• Simplify flipPositionIfRequired using scrollLength
  ekrctb · 2021-06-14 13:13:27 +09:00
  fdb09ef4d7
• Use Direction enum instead of int

  The property is named `scrollingAxis` to distinguish from `direction`, which is of `ScrollingDirection` type (unfortunate name crash).

  ekrctb · 2021-06-14 13:13:27 +09:00
  8cf4454780
• Rename nested classes
  Pasi4K5 · 2021-06-12 18:37:31 +02:00
  ef9cb2c958
• Move OsuSettingsNumberBox into SettingsNumberBox
  Pasi4K5 · 2021-06-12 17:57:40 +02:00
  b79d57b68c
• Rename classes
  Pasi4K5 · 2021-06-12 17:37:01 +02:00
  c728f673d6
• Move classes into SettingsTextBox
  Pasi4K5 · 2021-06-12 17:34:02 +02:00
  29f3880415
• Add OsuModSettingsTextBox and OsuModSettingsNumberBox
  Pasi4K5 · 2021-06-12 00:34:53 +02:00
  fe39a47797
• Merge branch 'master' into refactor-scrolling-hoc-1
  Dan Balasescu · 2021-06-11 20:35:19 +09:00
  3389c4830b
• Refactor ScrollingHitObjectContainer and expose more useful methods
  ekrctb · 2021-06-11 18:28:48 +09:00
  af3f253b21
• Add missing CurrentSkin null check in DHO disposal
  Bartłomiej Dach · 2021-06-11 09:18:58 +02:00
  296761ade5
• Fix filename not matching type rename
  Dean Herbert · 2021-06-11 14:34:18 +09:00
  562cfe8703
• Show osu!taiko centre/rim colouring in editor timeline

  Closes #13443.

  Dean Herbert · 2021-06-11 14:17:30 +09:00
  bc3b7233ab
• Merge pull request #13378 from Syriiin/diffcalc/refactor/auto-properties

  Refactor DifficultyAttributes to use auto properties over public fields

  Dan Balasescu · 2021-06-10 18:42:11 +09:00
  35d5632355
• Merge branch 'master' into no-unranked-display
  Dan Balasescu · 2021-06-10 17:09:46 +09:00
  a44fd887ee
• Fix incorrect method referenced in xmldco

  Co-authored-by: ekrctb <32995012+ekrctb@users.noreply.github.com>

  Dean Herbert · 2021-06-09 14:20:01 +09:00
  b8df3fff9e
• Replace and obsolete Ranked flag with IsUserPlayable
  Dean Herbert · 2021-06-09 14:17:03 +09:00
  d0e9f8ef90
• Add one missing obsoletion removal date
  Dean Herbert · 2021-06-09 14:11:50 +09:00
  62199a38a8
• Remove more obsoleted members
  Dean Herbert · 2021-06-09 14:10:48 +09:00
  f41e34ae2c
• Remove obsoleted DrawableJudgement methods

  Undated, but change was made on 2020-11-18.

  Dean Herbert · 2021-06-09 14:09:23 +09:00
  a87226ab10
• Refactor DifficultyAttributes to use auto properties over public fields
  Samuel Cattini-Schultz · 2021-06-08 19:43:59 +10:00
  f1bef989b7
• Merge branch 'master' into fix-spectator-frame-conversion
  Dan Balasescu · 2021-06-04 21:17:40 +09:00
  57a38374db
• Merge branch 'master' into factor-out-hoc
  Dan Balasescu · 2021-06-04 15:31:35 +09:00
  b283c48abb
• Merge branch 'master' into fix-spectator-frame-conversion
  Dean Herbert · 2021-06-04 15:06:15 +09:00
  23096c58bb