73895 Commits

This Branch

This Branch

All Branches

• Fix SHOCKING test

  What the actual heck is that magic number stupidity.
  
  I'm not looking into why the test falls over so badly that it apparently
  dies on some main menu logic just because assertions fail, because the
  main menu logic is for hold-to-song-select-v2 and is thus temporary.

  Bartłomiej Dach · 2025-06-13 10:34:14 +02:00
  f4bf2ae7a5
• Fix code quality
  Bartłomiej Dach · 2025-06-13 10:06:44 +02:00
  dc38c190df
• Adjust implementation of star rating filtering in song select to new star rating flooring behaviour

  Required for things to not be broken after the previous change.

  Bartłomiej Dach · 2025-06-13 09:13:20 +02:00
  eda489b911
• Floor star rating to 2 decimal places rather than rounding

  Rounding semi-regularly confuses users who aim for star rating pass / FC
  medals and then feel they have been cheated out of a medal because they
  passed an "X-star beatmap", but the actual star rating of the beatmap is
  slightly under X.
  
  The latest instance of this can be found at
  https://osu.ppy.sh/community/forums/topics/2091333?n=2. The relevant
  beatmap there is https://osu.ppy.sh/beatmapsets/2162554#osu/4746232,
  whose raw star rating is 6.9976070253117344.
  
  The other direction would be to fix the star rating medals instead, but
  I think this is more reasonable given we already do similar things to
  accuracy displays.

  Bartłomiej Dach · 2025-06-13 09:11:06 +02:00
  4fd2a488b7
• Merge pull request #33660 from peppy/more-robust-logo-operations

  Use `IDisposable` flow for common logo tracking/proxy operations for better robustness

  Bartłomiej Dach · 2025-06-12 12:03:17 +02:00
  e258244caf
• Merge pull request #33630 from peppy/leaderboard-always-expand-setting

  Add a skin-level setting to leaderboard to allow disabling automatic collapsing

  Bartłomiej Dach · 2025-06-12 11:16:17 +02:00
  d13676fcc6
• Delete redundant string interpolation
  Bartłomiej Dach · 2025-06-12 11:10:43 +02:00
  ee696e32f0
• Merge pull request #33629 from peppy/ssv2-reveal-background

  Add ability to reveal background when long pressing in empty space

  Bartłomiej Dach · 2025-06-12 11:09:01 +02:00
  66c80ccb16
• Fix incorrect text spacing in skin editor toolbar

  Probably regressed with framework flow changes.

  Dean Herbert · 2025-06-12 17:33:23 +09:00
  ba31cb4786
• Localise new setting
  Dean Herbert · 2025-06-12 17:30:11 +09:00
  612f853baa
• Combine two similar flags into one
  Dean Herbert · 2025-06-12 17:27:23 +09:00
  ebfc3c9ccf
• Always return previous tracking state before taking out a new tracking operation
  Dean Herbert · 2025-06-12 17:13:35 +09:00
  7cdc296c9c
• Fix carousel drags being incorrectly handled as background reveal
  Dean Herbert · 2025-06-12 16:48:29 +09:00
  968b5b0082
• Remove leftover xmldoc
  Bartłomiej Dach · 2025-06-12 09:32:53 +02:00
  8c0e535d41
• Merge pull request #33639 from peppy/ssv2-renames

  Move and rename next/previous "group" selection keybindings to make way for group-specific bindings

  Bartłomiej Dach · 2025-06-12 08:42:11 +02:00
  37e8cc9afc
• Update logo proxy operations to use IDisposable flow
  Dean Herbert · 2025-06-12 15:19:26 +09:00
  a8be9d7b64
• Update logo tracking operations to use IDisposable flow
  Dean Herbert · 2025-06-12 15:18:38 +09:00
  435128ebaa
• Merge pull request #33626 from peppy/offset-control-use-last-valid

  Allow using previous valid score for offset calibration when subsequent retries are too short

  Bartłomiej Dach · 2025-06-12 07:55:35 +02:00
  f1bd63769b
• Merge pull request #33638 from frenzibyte/ssv2-leaderboard-masked-away

  Fix partially displayed leaderboard scores looking wrong when resizing game

  Dean Herbert · 2025-06-12 14:04:51 +09:00
  2db7d34a0b
• Adjust tests based on changed behaviour

  Calibration no longer goes away on missing / invalid scores.

  Dean Herbert · 2025-06-11 22:47:47 +09:00
  90877a079c
• Disable when using touch input
  Dean Herbert · 2025-06-11 22:28:50 +09:00
  fc5ea7f3f2
• Move and rename next/previous "group" selection keybindings to make way for group-specific bindings
  Dean Herbert · 2025-06-11 21:02:52 +09:00
  b9e1b6969e
• Remove outer grid container to avoid masked-away issues
  Salman Alshamrani · 2025-06-11 14:51:21 +03:00
  9a9cbcdd26
• Merge pull request #33632 from peppy/ssv2-back-button-clickability

  Fix corner clicks not activating back button at new song select

  Dan Balasescu · 2025-06-11 19:39:39 +09:00
  2b605c1d01
• Merge pull request #33634 from bdach/playlists-leaderboards

  Add support for showing gameplay leaderboard in playlists and daily challenge

  Dan Balasescu · 2025-06-11 19:25:07 +09:00
  0e37a563d4
• Merge pull request #33628 from peppy/ssv2-add-back-scrollbar-padding

  Add back scrollbar padding in new beatmap carousel

  Bartłomiej Dach · 2025-06-11 11:31:06 +02:00
  7a12a7c9a2
• Add support for showing leaderboard in playlists and daily challenge

  As touched on in https://github.com/ppy/osu/pull/33581.

  Bartłomiej Dach · 2025-06-11 11:21:26 +02:00
  4810c7c847
• Increase hitbox for footer back button

  Based on countless feedback of users wanting to be able to throw their
  mouse into the corner of the screen to go back. It makes sense.

  Dean Herbert · 2025-06-11 18:00:22 +09:00
  70a5474489
• Add setting to leaderboard to allow disabling automatic collapsing

  Was a 2 minute implementation, so why not?
  
  Addresses https://github.com/ppy/osu/discussions/33523.

  Dean Herbert · 2025-06-11 17:36:56 +09:00
  04871fe55a
• Add ability to reveal background when long pressing in empty space

  As touched on in https://github.com/ppy/osu/discussions/33624.
  
  Maybe fine as a bit of an easter egg?

  Dean Herbert · 2025-06-11 17:19:33 +09:00
  edf62baae8
• Add back scrollbar padding in new beatmap carousel

  Closes https://github.com/ppy/osu/issues/33447. Implementation copied
  from previous carousel.

  Dean Herbert · 2025-06-11 16:34:04 +09:00
  cfd73cc900
• Adjust commentary to not suck

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2025-06-11 15:55:08 +09:00
  38ad48bb35
• Merge pull request #33598 from peppy/ssv2-difficulty-traversal-selection

  Allow changing difficulties using up and down arrows when sets are grouped

  Bartłomiej Dach · 2025-06-11 08:34:10 +02:00
  932ba3d590
• Allow using previous valid score for offset calibration when subsequent retries are too short

  As proposed in https://github.com/ppy/osu/discussions/33572.
  
  Note that this won't work if you leave to song select. We could make
  that work but it would require further global faffing and I don't think
  it's worth the effort.

  Dean Herbert · 2025-06-11 15:26:02 +09:00
  cdb2f216f2
• Merge pull request #33625 from Joehuu/version-keyword-release-stream

  Add "version" keyword to release stream setting

  Dan Balasescu · 2025-06-11 14:04:52 +09:00
  4b8ac8a565
• Add "version" keyword to release stream setting
  Joseph Madamba · 2025-06-10 20:35:43 -07:00
  16f7140254
• Merge pull request #33616 from bdach/fix-ticks-not-updating-again

  Fix timeline not updating ticks correctly after arbitrary timing control point changes (again)

  Dean Herbert · 2025-06-10 22:19:39 +09:00
  85eef1bc3a
• Fix incorrect equality check
  Dean Herbert · 2025-06-10 21:58:43 +09:00
  b16cb1ae58
• Merge pull request #33610 from bdach/solo-results-show-local

  Fix results screen not showing local scores on results screen for some beatmap statuses

  Dean Herbert · 2025-06-10 21:50:39 +09:00
  a5ad09385f
• Fix timeline not updating ticks correctly after arbitrary timing control point changes (again)

  Closes https://github.com/ppy/osu/issues/33393.
  
  This is admittedly a half-assed diff. This was apparently "fixed" once
  before, eons ago, in https://github.com/ppy/osu/pull/11032, but I'm not
  sure whether it regressed, or where, because I don't want to bisect four
  years back. (At that time `ControlPointInfo.ControlPointsChanged`
  did not exist yet.)
  
  Also there's the part where changes to control points do not undo or
  redo (see https://github.com/ppy/osu/issues/31942), but I'm not touching
  that *either*, because if I start touching that, then I will get yelled
  at for not reviewing the 2.5k line PR that rewrites the entirety of
  change handling in editor instead
  (https://github.com/ppy/osu/pull/30314). I will attempt to get through
  that mental block sometime within the year. Please do not rush me.
  
  The cheap cop-out argument is that hooking this up to `ControlPointInfo`
  specifically is probably "more efficient" anyway.

  Bartłomiej Dach · 2025-06-10 14:44:23 +02:00
  f5aeedc7e1
• Do not attempt to add displayed score to list of sorted scores more than once

  This is a very dodgy fix, but it fixes an edge case that has so far - to
  my knowledge - not been reported by users in the wild, only by me trying
  to break things, so my hope is that we can do this and move on for now.

  Bartłomiej Dach · 2025-06-10 12:32:03 +02:00
  c84988a2ec
• Merge pull request #33607 from peppy/ssv2-show-full-mod-details-footer

  SongSelectV2: Show full mod details in footer

  Bartłomiej Dach · 2025-06-10 11:21:50 +02:00
  97e6187f0d
• Merge pull request #33608 from peppy/update-velopack

  Update velopack to fix macOS update overheads

  Dan Balasescu · 2025-06-10 18:07:38 +09:00
  14674772e6
• Fix results screen not showing local scores on results screen for some beatmap statuses

  Closes https://github.com/ppy/osu/issues/33609.
  
  Case of leftover code that should have been removed.
  
  This condition is still active in the online leaderboards path via
  
  	https://github.com/ppy/osu/blob/4dcc928c7e46e020c62f4d60e7b859ba18c9142f/osu.Game/Online/Leaderboards/LeaderboardManager.cs#L91-L95
  
  Not sure trying to add test coverage is a productive use of time? Will
  do on request though.

  Bartłomiej Dach · 2025-06-10 10:51:30 +02:00
  de57daeb3c
• Fix tooltip not being displayed around edges of text content
  Dean Herbert · 2025-06-10 17:17:48 +09:00
  599b4c8236
• Merge pull request #33606 from peppy/add-confirmation-for-block

  Add confirmation step before blocking a user

  Bartłomiej Dach · 2025-06-10 09:10:26 +02:00
  4dcc928c7e
• Update velopack to fix macOS update overheads

  Closes https://github.com/ppy/osu/issues/33091.
  
  I figure we can push this out on tachyon for testing.

  Dean Herbert · 2025-06-10 16:07:47 +09:00
  bf2a77ac22
• Merge pull request #33605 from peppy/ssv2-remove-update-button-shear

  Remove shear on update button to match non-sheared panel design

  Bartłomiej Dach · 2025-06-10 08:54:52 +02:00
  f59df15bf8
• SongSelectV2: Show full mod details in footer

  User feedback is that it's no longer possible to see the applied rate
  adjust change when it's non-default without hovering. This fixes that
  issue.
  
  I've adjusted the visuals a bit so you can still get a hint at which
  mods are displayed, even when they are overflowing.

  Dean Herbert · 2025-06-10 15:34:03 +09:00
  f16a7309f8
• Add confirmation step before blocking a user

  Closes https://github.com/ppy/osu/issues/33585.

  Dean Herbert · 2025-06-10 15:06:30 +09:00
  6383d8cc23