Dean Herbert
f2cecad83b
Add failing test coverage showing carousel deletions don't keep scroll position
2022-01-27 16:52:02 +09:00
Dean Herbert
449e9bcf5c
Ensure beatmap carousel scroll position is maintained during deletion operations
2022-01-27 16:52:02 +09:00
Dean Herbert
0a45aa80cb
Remove unnecessary double-schedule in UpdateBeatmapSet
2022-01-27 16:52:02 +09:00
Dan Balasescu
54d18bd7ac
Merge pull request #16642 from peppy/ruleset-private-info-set
...
Make `Ruleset.RulesetInfo` get only
2022-01-27 16:41:52 +09:00
Dan Balasescu
81ba1558de
Merge pull request #16643 from peppy/ruleset-silly-ctor
...
Remove pointless constructor in `RulesetInfo`
2022-01-27 16:41:38 +09:00
Dan Balasescu
9ff2b9eb95
Merge pull request #16640 from peppy/realm-migration-always-delete
...
Improve realm migration UX to give users a recovery path on error
2022-01-27 15:43:14 +09:00
Dean Herbert
714177cce1
Remove pointless constructor in RulesetInfo
2022-01-27 15:37:27 +09:00
Dean Herbert
e67b1fe0ec
Make Ruleset.RulesetInfo get only
2022-01-27 15:36:35 +09:00
Dan Balasescu
cc0a8db76a
Merge pull request #16639 from peppy/ef-db-delete-retry
...
Add more attempts to delete EF database
2022-01-27 15:31:40 +09:00
Dean Herbert
67ccb87992
Add exception message to discussion template url
2022-01-27 14:56:04 +09:00
Dean Herbert
fb081384e1
Add safety against zip creation potentially failing (probably can't but still)
2022-01-27 14:55:52 +09:00
Dean Herbert
465e7d29fe
Avoid showing the external link warning
2022-01-27 14:53:11 +09:00
Dean Herbert
31abb372e5
Automatically zip and show the backup archive to the user
2022-01-27 14:52:58 +09:00
Dean Herbert
08948f60f3
Move backups to "backups" subfolder to make them easier to find
2022-01-27 14:39:13 +09:00
Dean Herbert
b745252962
Show notification when migration fails to give users a recovery path
2022-01-27 14:39:11 +09:00
Dean Herbert
deb5d75b5f
Change migration process to always delete old EF database
...
It is already backed up, so this is probably fine.
2022-01-27 14:33:46 +09:00
Dean Herbert
587c0f965c
Add more attempts to delete EF database
...
Just noticed in passing. Probably best we do this since it was known to
fail on windows in some rare cases.
2022-01-27 14:32:21 +09:00
Bartłomiej Dach
de5ac7ad83
Merge pull request #16632 from LumpBloom7/Third-party-ruleset-filter-fix
...
Fix ruleset filters not working correctly on song select
2022-01-26 19:24:06 +01:00
Bartłomiej Dach
df9658641c
Merge branch 'master' into Third-party-ruleset-filter-fix
2022-01-26 18:54:20 +01:00
Bartłomiej Dach
b7aa26bc5f
Merge pull request #16633 from peppy/fix-collection-migration
...
Block collection loading until realm migration has completed
2022-01-26 18:12:19 +01:00
Dean Herbert
f70e10e8a4
Fix ruleset filter matching using OnlineID instead of ShortName
2022-01-27 01:25:57 +09:00
Dean Herbert
0c2ed2f9a7
Add failing test coverage of incorrect filter ruleset matching
2022-01-27 01:25:57 +09:00
Dean Herbert
f21e3d0d86
Block collection loading until realm migration has completed
2022-01-27 00:34:51 +09:00
Derrick Timmermans
6ec9c5c21a
Use default custom ruleset ID
2022-01-26 16:23:00 +01:00
Derrick Timmermans
e712fab299
Add test for custom ruleset conversion filtering
2022-01-26 16:14:07 +01:00
Derrick Timmermans
873d367615
Fix custom rulesets not being able to convert maps
2022-01-26 15:51:39 +01:00
Dan Balasescu
bab337591f
Merge pull request #16630 from peppy/fix-null-mod-json-parse-fail
...
Fix some score imports failing due to null string attempted to be parsed as json
2022-01-26 23:15:23 +09:00
Dean Herbert
70acc4d0bd
Merge pull request #16631 from frenzibyte/make-test-abstract
...
Mark `EditorSavingTestScene` as abstract to not appear in visual test browser
2022-01-26 23:10:09 +09:00
Salman Ahmed
7f34085baa
Mark EditorSavingTestScene as abstract
2022-01-26 17:04:30 +03:00
Dean Herbert
378173cc66
Fix some score imports failing due to null string attempted to be parsed as json
2022-01-26 22:46:29 +09:00
Dan Balasescu
cf9ee43b17
Merge pull request #16608 from peppy/playlist-overlay-optimisations
...
Optimise `PlaylistOverlay` and reduce startup overhead of `MusicController`
2022-01-26 20:28:33 +09:00
Dan Balasescu
a07fce55d4
Merge pull request #16606 from peppy/fix-out-of-order-events-on-block-fail
...
Fix notification reset events potentially arriving out of order if a block operation times out
2022-01-26 20:28:21 +09:00
Dan Balasescu
0dd2de3e1e
Merge pull request #16628 from peppy/fix-realm-ruleset-ordering
...
Fix custom rulesets being displayed before official ones
2022-01-26 19:19:01 +09:00
Dan Balasescu
94d3e2c90c
Merge branch 'master' into fix-out-of-order-events-on-block-fail
2022-01-26 19:08:55 +09:00
Dan Balasescu
b3f2392358
Resolve compilation error due to removed method
2022-01-26 19:04:18 +09:00
Dean Herbert
abe2cccaae
Fix completely invalid method of testing realm migration
2022-01-26 19:03:26 +09:00
Dan Balasescu
cdca1285ab
Merge branch 'master' into playlist-overlay-optimisations
2022-01-26 19:01:33 +09:00
Dan Balasescu
b1a23486c5
Merge pull request #16626 from peppy/fix-skin-section-realm-usage
...
Refactor `SkinSection` to avoid unnecessary realm queries
2022-01-26 19:01:15 +09:00
Dan Balasescu
f3924522a2
Merge pull request #16627 from peppy/fix-ruleset-import-failure
...
Fix realm migration failures with presence of databased EF rulesets that don't exist on disk
2022-01-26 18:59:20 +09:00
Dean Herbert
57e624d8e7
Fix custom rulesets being displayed before official ones
2022-01-26 18:46:32 +09:00
Dean Herbert
473c4d00ca
Fix grouped difficulty icons using incorrect lookup for ruleset grouping
2022-01-26 18:38:44 +09:00
Dean Herbert
45636ce04b
Remove collection ToLive helper method to avoid confusion
2022-01-26 18:26:37 +09:00
Dean Herbert
3aa681005b
Skip importing scores which have no matching realm ruleset
...
There's no real way to recover these unless we want to start importing
rulesets into realm. And that seems counter productive. This can only
happen if users don't have the dll present any more, and it was removed
far before realm was tracking rulesets (else it would have an
`Available=0` entry in realm to match).
2022-01-26 18:04:54 +09:00
Dean Herbert
f2d48d088d
Fix realm migration failures with presence of databased EF rulesets that don't exist on disk
2022-01-26 17:57:03 +09:00
Dean Herbert
d1a2256262
Refactor SkinSection to avoid unnecessary realm queries
2022-01-26 17:48:11 +09:00
Dean Herbert
885fb92aad
Move final empty result set sending to post-compact
2022-01-26 17:21:57 +09:00
Dean Herbert
791ea0308f
Add flag to guard against deadlocks during blocking operations
2022-01-26 17:09:28 +09:00
Dan Balasescu
4a51bab9ac
Merge pull request #16622 from peppy/fix-results-score-switch-crash
...
Fix crash at results screen when viewing another score panel after playing
2022-01-26 16:59:39 +09:00
Dean Herbert
11f0f3c17d
Revert "Move final result set firing to before the update realm is disposed"
...
This reverts commit 24bcba6418
2022-01-26 16:21:24 +09:00
Dean Herbert
24bcba6418
Move final result set firing to before the update realm is disposed
...
Without this, if any registered callback attempts to access
`RealmAccess.Realm` when handling the empty set callback, it will
deadlock the game.
2022-01-26 15:57:06 +09:00
