Bartłomiej Dach
6baa099906
Fix broken delay
2024-02-14 10:12:01 +01:00
Bartłomiej Dach
7f76ff1f5d
Merge pull request #27145 from tsunyoku/legacy-relax-replays-key-presses
...
Create key-presses when watching legacy Relax replays
2024-02-14 10:06:06 +01:00
Dan Balasescu
3b8203a3ad
Merge pull request #27167 from smoogipoo/fix-inspection
...
Prefer collection initializer over collection expression syntax
2024-02-14 17:58:40 +09:00
Dan Balasescu
2981ebe3d5
Fix inspection
2024-02-14 17:13:44 +09:00
Salman Ahmed
02de9122d4
Remove behaviour of flipping catcher plate on direction change
2024-02-14 07:17:05 +03:00
Salman Ahmed
c24af5bfeb
Add test coverage
2024-02-14 04:17:55 +03:00
Salman Ahmed
4d3b605e04
Add support for displaying "mapper" badges in comments
2024-02-14 04:17:55 +03:00
Salman Ahmed
72c6134dbf
Include commentable object metadata in comments
2024-02-14 04:16:36 +03:00
Salman Ahmed
c4e358044a
Add API models for comment page metadata
2024-02-14 04:16:36 +03:00
Salman Ahmed
5267e0abf7
Move comment author line to separate component
2024-02-14 04:16:36 +03:00
Salman Ahmed
35649d137c
Ignore soft-deleted beatmaps when trying to present from notification
2024-02-14 02:04:20 +03:00
Salman Ahmed
a96a66bc9e
Add failing test case
2024-02-14 02:04:20 +03:00
Salman Ahmed
9b17020707
Adjust "Floating Fruits" in line with layout changes
2024-02-14 01:34:55 +03:00
Salman Ahmed
62f5251b6e
Rewrite osu!catch playfield layout containers and apply masking around vertical boundaries
2024-02-14 01:34:55 +03:00
Bartłomiej Dach
eae43f5fd9
Consume SoloStatisticsWatcher updates in toolbar button
2024-02-13 14:28:24 +01:00
Bartłomiej Dach
14052ae1cc
Implement transient stats display on user toolbar button
2024-02-13 14:28:24 +01:00
Bartłomiej Dach
21b9fb95e2
Move SoloStatisticsWatcher to OsuGame
...
Doesn't feel like it needs to be in base, and it being in base was
causing problems elsewhere before.
2024-02-13 14:28:24 +01:00
Bartłomiej Dach
da4ebd0681
Refactor SoloStatisticsWatcher to no longer require explicit subscription callbacks
2024-02-13 13:49:01 +01:00
Dean Herbert
f7a223f328
Merge pull request #27053 from frenzibyte/unranked-pp-placeholder
...
Add support for displaying "unranked PP" placeholder
2024-02-13 18:59:55 +08:00
Bartłomiej Dach
22e9c4a3b5
Use private interface rather than weird inheritance
2024-02-13 10:20:06 +01:00
Dan Balasescu
833997bf1d
Merge pull request #27143 from bdach/more-stringent-metadata-checks
...
Use more stringent checks when applying online metadata
2024-02-13 17:10:52 +09:00
James Wilson
5101979ac0
only use LegacyReplayPressHandler on legacy replays
2024-02-13 00:34:06 +00:00
Dan Balasescu
60e0eea9bc
Merge pull request #27112 from Stoppedpuma/alias-author-creator
...
Add aliases "author" and "mapper" for creator results
2024-02-13 08:35:49 +09:00
Dan Balasescu
d3e005d4a2
Merge pull request #27116 from tsunyoku/only-compute-flashlight-when-necessary
...
Only compute flashlight in osu! difficulty calculations when required
2024-02-13 08:25:59 +09:00
Salman Ahmed
2d65dfbf09
Fix Rider EAP whoopsie
2024-02-12 22:10:36 +03:00
Salman Ahmed
5bebe9fe0d
Add test case for profile scores made on loved beatmaps
2024-02-12 21:33:18 +03:00
Salman Ahmed
4f0f07d55a
Remove placeholder classes and inline everything
2024-02-12 21:30:10 +03:00
tsunyoku
cc733ea809
add inline comment for supposedly backwards ternary
2024-02-12 18:00:05 +00:00
tsunyoku
2a02566283
refactor down and wasLeft management into respective PressHandler classes
2024-02-12 17:45:00 +00:00
Bartłomiej Dach
5d81d83fb2
Merge branch 'master' into alias-author-creator
2024-02-12 18:02:42 +01:00
Bartłomiej Dach
96711eb185
Add test coverage
2024-02-12 18:02:34 +01:00
tsunyoku
581ae2f679
handle key presses when watching legacy relax replays
2024-02-12 12:51:35 +00:00
cdwcgt
1944a12634
allow ModMuted to ranked when setting adjusted
2024-02-12 21:18:31 +09:00
Bartłomiej Dach
e5e0b0e385
Add test coverage for correct setting of beatmap set status
2024-02-12 12:08:51 +01:00
Bartłomiej Dach
138fea8c38
Only apply set-level metadata after all difficulties have been processed
2024-02-12 12:08:51 +01:00
Bartłomiej Dach
133e61a1b2
Add another test for even more failure
2024-02-12 12:08:51 +01:00
Bartłomiej Dach
87702b3312
Only check online matching when determining whether to save online metadata
...
After https://github.com/ppy/osu/pull/23362 I'm not sure the
`LocallyModified` check is doing anything useful. It was confusing me
really hard when trying to parse this logic, and it can misbehave (as
`None` will also pass the check).
2024-02-12 12:07:20 +01:00
Bartłomiej Dach
4f0ae4197a
Refuse to apply online metadata in the most dodgy scenarios
2024-02-12 11:43:41 +01:00
Bartłomiej Dach
834db989f7
Add more test coverage for more failure
2024-02-12 11:43:41 +01:00
Bartłomiej Dach
80b14f1aae
Add test coverage for beatmap confusion scenarios
2024-02-12 11:43:15 +01:00
Salman Ahmed
2ae616a88e
Combine other cases of displaying dash in scores PP
2024-02-12 12:29:33 +03:00
Bartłomiej Dach
36005a5449
Fix selected legacy skins crashing on zero-length hold notes
...
Closes https://github.com/ppy/osu/issues/27134 .
2024-02-12 08:33:08 +01:00
Stoppedpuma
ca0819cf7a
Alias "mapper" as well
2024-02-11 20:28:16 +01:00
Dean Herbert
7bc571dd51
Merge pull request #27132 from EVAST9919/beatmap-panel-texture-alloc
...
Fix huge allocation overhead during beatmap texture creation in song-select screen
2024-02-12 01:43:31 +08:00
Andrei Zavatski
5e692345de
Don't convert pixel data to array
2024-02-11 17:44:54 +03:00
Dean Herbert
33d4e8f821
Merge pull request #23822 from bdach/refactor-metadata-lookup-sources
...
Refactor metadata lookup flows
2024-02-11 20:37:45 +08:00
Dean Herbert
1df38b54a1
Merge branch 'master' into refactor-metadata-lookup-sources
2024-02-11 20:10:41 +08:00
Dean Herbert
7dba21fdac
Move init method to bottom of file
2024-02-11 20:05:58 +08:00
Dan Balasescu
2ab318771e
Merge pull request #27117 from tsunyoku/remove-linq-from-difficulty-hit-object
...
Replace linq usage in `Previous` and `Next` on `DifficultyHitObject` with more direct computation
2024-02-11 18:13:58 +09:00
Dean Herbert
b0420f7ed9
Merge pull request #27115 from bdach/contributing-guidelines-do-not-release-ever
...
Add note to never run release config to contributing guidelines
2024-02-10 23:45:24 +08:00
