5638 Commits

• add backwards-compatible ctor that allows creating context from a given working and playable single beatmap

  more productive than adjusting every single test

  Hivie · 2025-08-11 15:40:25 +01:00
  f0ca3304b8
• initial pass on updated verifier context usage across most checks
  Hivie · 2025-08-11 14:57:14 +01:00
  fd6cf680b9
• rework and improve BeatmapVerifierContext strtucture

  - uses ` VerifiedBeatmap` record for combining working and playable beatmaps
  - much better data access with all beatmapset diffs

  Hivie · 2025-08-11 14:56:35 +01:00
  cfb9649993
• handle single difficulty case more efficiently
  Hivie · 2025-08-09 14:14:51 +01:00
  eba31ab203
• Merge branch 'ppy:master' into verify/refactor-verifier-context
  Hivie · 2025-08-09 13:48:29 +01:00
  1c9e30429f
• add working beatmapset difficulties to verifier context
  Hivie · 2025-08-09 13:13:47 +01:00
  2559c7ac8b
• pass on BeatmapManager directly
  Hivie · 2025-08-09 11:59:20 +01:00
  172a48f1ac
• Merge branch 'master' into verify/check-inconsistent-settings
  Bartłomiej Dach · 2025-08-07 06:57:32 +02:00
  39ad5ecd79
• refactor verifier context to use a static factory method for creating instances with beatmap resolution
  Hivie · 2025-08-07 01:52:50 +01:00
  c5f4feb725
• Use strongly-typed equality comparer rather than using object equality comparer

  `EqualityComparer<object>.Default()` will be slow, will fall back to
  `object.Equals()` which may do the right thing, the wrong thing, or be
  useless due to using reference equality semantics.
  
  In practice in this call site it likely doesn't matter anyway but I'd
  rather be future-proof than not.

  Bartłomiej Dach · 2025-08-06 18:26:41 +02:00
  c2a85032a6
• only check widescreen bool when storyboard is present

  matches MV

  Hivie · 2025-08-06 14:57:42 +01:00
  92fda5c2b9
• move storyboard presence check to shared utils
  Hivie · 2025-08-06 14:55:20 +01:00
  9b53d340af
• refactor comparison and use actual object type for field selectors
  Hivie · 2025-08-06 14:04:18 +01:00
  7f886f7534
• fix tests
  Hivie · 2025-08-06 13:06:59 +01:00
  899719e874
• mark timing checks as set-level
  Hivie · 2025-08-06 11:42:57 +01:00
  af8b133019
• use current beatmap as reference

  to be consistent with other checks that follow similar logic

  Hivie · 2025-08-06 11:42:40 +01:00
  f2953652a1
• add check for inconsistent settings
  Hivie · 2025-08-06 11:29:22 +01:00
  3cd6734c10
• use already-existing framework extension method
  Hivie · 2025-08-06 08:42:19 +01:00
  2127b6ca4e
• cleaner definition

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Hivie · 2025-08-06 08:40:34 +01:00
  82f619a58a
• refactor and reduce duplication
  Hivie · 2025-08-06 07:42:40 +01:00
  03b6f35946
• add check for missing genre/language tags
  Hivie · 2025-08-05 23:02:48 +01:00
  f5c6c086ad
• Merge pull request #34465 from Hiviexd/verify/check-inconsistent-timing

  Add verify check for inconsistent timing control points

  Bartłomiej Dach · 2025-08-05 10:34:47 +02:00
  427dc2b31e
• Merge pull request #34467 from Hiviexd/verify/implement-scopes

  Distinguish between set-level and difficulty-specific checks in verify screen

  Bartłomiej Dach · 2025-08-05 10:31:22 +02:00
  da710ad558
• Bring back localisations
  Bartłomiej Dach · 2025-08-05 08:23:47 +02:00
  c1c43fab17
• Use casing of "beatmap set" consistent with the rest of the code base
  Bartłomiej Dach · 2025-08-05 08:18:30 +02:00
  ee5a5cda11
• remove unnecessary localisations
  Hivie · 2025-08-04 22:07:41 +01:00
  2c5aa73ccb
• apply review

  - improve timing tolerance const name and documentation
  - simplify matching logic in `FindMatchingTimingPoint`

  Hivie · 2025-08-04 15:21:43 +01:00
  a7f0ae09bb
• define general checks with a bool in CheckMetadata instead of an interface
  Hivie · 2025-08-04 14:12:59 +01:00
  ed301ec114
• rename scopes
  Hivie · 2025-08-04 14:02:40 +01:00
  8a2053bf61
• mark various set-level checks as general checks
  Hivie · 2025-08-01 21:42:31 +01:00
  0d2618082d
• add VerifyChecksScope enum
  Hivie · 2025-08-01 21:40:33 +01:00
  8e73c57470
• add class for general checks
  Hivie · 2025-08-01 21:39:46 +01:00
  7f8b6981b2
• move methods to TimingCheckUtils

  so they can be reused for future timing-related checks

  Hivie · 2025-08-01 18:37:54 +01:00
  0fcef7b0ee
• add check for inconsistent timing
  Hivie · 2025-08-01 16:01:28 +01:00
  b4dc394127
• Show effect of beatmap attributes on gameplay metrics in osu!
  Bartłomiej Dach · 2025-08-01 11:07:48 +02:00
  655733c06d
• Allow showing additional metrics when hovering over beatmap attributes
  Bartłomiej Dach · 2025-08-01 11:06:40 +02:00
  c68cbc5360
• Fix code quality
  Bartłomiej Dach · 2025-07-30 15:00:55 +02:00
  640fe5752d
• Rename property to reduce confusion

  Caused an actual bug in one of the replaced usages.

  Bartłomiej Dach · 2025-07-30 14:06:38 +02:00
  cd2c5075df
• Refactor beatmap attribute methods

  This change refactors `GetAdjustedDisplayDifficulty()` and
  `GetBeatmapAttributesToDisplay()` in two ways:
  
  - Both methods now accept `IBeatmapInfo` instead of
    `IBeatmapDifficultyInfo`. This is done in order to make mania key
    count display to work, wherein `IBeatmapDifficultyInfo` is not enough
    to calculate the final key count.
  
  - `GetAdjustedDisplayDifficulty()` now applies all
    `IApplicableToDifficulty` mods itself. I did this after noticing that
    every real consumer of this method had to do that themselves for very
    little reason.

  Bartłomiej Dach · 2025-07-30 14:06:34 +02:00
  7c4dd812b6
• Add new ruleset method responsible for displaying beatmap attributes consistently everywhere

  The intention is to use this in every place that wishes to display
  beatmap attributes (and also remove a bunch of local hack-arounds for
  mania, etc.)

  Bartłomiej Dach · 2025-07-30 13:41:19 +02:00
  e2a454ae00
• Merge pull request #34371 from Hiviexd/verify/check-almost-concurrent-objects

  Account for almost concurrent case in concurrent objects check

  Bartłomiej Dach · 2025-07-28 15:03:26 +02:00
  34dfb2f9ea
• apply review
  Hivie · 2025-07-28 12:36:18 +01:00
  e781ad737b
• apply review
  Hivie · 2025-07-28 12:24:24 +01:00
  8466d64c69
• refactor issue templates to be more unified
  Hivie · 2025-07-24 13:25:15 +01:00
  c0ba8bc997
• Account for almost concurrent case in concurrent objects check
  Hivie · 2025-07-24 13:12:24 +01:00
  806d3160f8
• add verify check for inconsistent metadata
  Hivie · 2025-07-24 12:20:45 +01:00
  ee27be1868
• Merge pull request #34181 from Hiviexd/verify/check-lowest-diff-drain

  Add verify check for lowest diff drain/play time requirements

  Bartłomiej Dach · 2025-07-22 08:38:59 +02:00
  c408d60fbe
• oops
  Hivie · 2025-07-21 13:21:30 +01:00
  209a75c4df
• adjust wording
  Hivie · 2025-07-21 13:18:25 +01:00
  9bab2444ea
• fix one tiny miniscule english error i encountered by editing a beatmap
  Shin Morisawa · 2025-07-20 20:50:20 +09:00
  9572c2ba67