Dean Herbert
eee3b6eaf3
Refactor to avoid dual-boolean mess
2024-11-15 14:57:11 +09:00
Dean Herbert
fd39a8a78f
Fix occasional flash when quick exiting / retrying from player
...
The gist of the issue is that `fadeOut` was being called *twice* in the
quick exit/retry scenarios, causing weirdness with transforms.
I've restructured things to ensure it's only called once.
2024-11-15 14:57:11 +09:00
Dean Herbert
9851a73459
Add missing expire call
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-11-15 14:56:39 +09:00
Dean Herbert
3ac3eb829b
Adjust transition further to avoid brief "jumpscare" display of metadata
2024-11-15 14:56:39 +09:00
Dean Herbert
5a1ddfdccb
Fix test failure due to restart happening too fast
2024-11-15 14:56:38 +09:00
Dean Herbert
c7b9bd8a75
Make quick restart even faster
2024-11-15 14:56:38 +09:00
Dan Balasescu
251737ccd3
Fix the other test class too
2024-11-15 14:56:33 +09:00
Dan Balasescu
2e1d08a3ab
Update test
2024-11-15 14:56:33 +09:00
Dan Balasescu
5e522afdfe
Remove unused params
2024-11-15 14:56:33 +09:00
Dan Balasescu
80a2dbf799
Add IHasLegacyHitObjectType to ConvertHitObject
2024-11-15 14:56:33 +09:00
Dan Balasescu
304bc6c9c7
Merge implementations of ConvertHitObjectParser
...
Having these be separate implementations sounded awesome at the time,
but it only ever led to confusion. There's no practical difference if,
for example, catch sees hitobjects with `IHasPosition` instead of
`IHasXPosition`.
2024-11-15 14:56:32 +09:00
Nathen
7001fef050
More correct but not too important
2024-11-15 14:56:25 +09:00
Nathen
b2fa41489d
Be doubly careful
2024-11-15 14:56:25 +09:00
Nathen
a3044d9763
Fix NaN PP values when SR is 0
2024-11-15 14:56:24 +09:00
Dean Herbert
7eb0113bce
Fix crash when resetting offset after a play with no hit events
...
Closes https://github.com/ppy/osu/issues/30573 .
2024-11-15 14:56:13 +09:00
Dean Herbert
383b4a5c3e
Add failing test showing crash when adjusting offset with no HitEvents
2024-11-15 14:56:10 +09:00
Bartłomiej Dach
c25215d2cf
Merge pull request #30579 from peppy/fix-rank-display-song-select
...
Fix top rank display not showing up on beatmaps with many difficulties
2024-11-12 12:26:26 +01:00
Dan Balasescu
678d14aa60
Merge pull request #30534 from Lawtrohux/difficult-strain
...
Globalise `CountDifficultStrains` within StrainSkill
2024-11-12 14:50:18 +09:00
Dean Herbert
8c5785fdf6
Make math more logical
2024-11-11 22:57:26 +09:00
Dean Herbert
ee4d58544d
Update framework (and other common packages)
2024-11-11 21:58:13 +09:00
Bartłomiej Dach
bca42e9d24
Merge pull request #30580 from peppy/song-select-less-semi-opaque
...
Reduce semi-opaque layers at song select
2024-11-11 12:23:17 +01:00
Dan Balasescu
f746999d58
Merge pull request #30544 from Finadoggie/clamp-slider
2024-11-11 19:22:34 +09:00
Bartłomiej Dach
b430ac2214
Merge branch 'master' into song-select-less-semi-opaque
2024-11-11 11:04:48 +01:00
Bartłomiej Dach
d29dd2c223
Remove unused using directives
2024-11-11 11:04:43 +01:00
Dean Herbert
8605639e67
Merge pull request #28382 from Hecatia-Lapislazuli/move-already-placed-objects-when-adjusting-offset-bpm
...
Implemented ability to adjust already-placed objects when changing timing offsets
2024-11-11 18:56:11 +09:00
Bartłomiej Dach
c37e4877e2
Move setting back to timing panel
2024-11-11 10:08:26 +01:00
Dean Herbert
f84ee3996f
Reduce semi-opaque layers at song select
...
I made these changes while working on
https://github.com/ppy/osu/pull/30579 . Basically, it's hard to fix the
ranks not loading while underneath the footer, and the transparency both
looks bad, and is going away in the redesign.
I've chosen values here that are moving *in the direction* of the new
design without overhauling everything.
- I know that there's still some transparency. I did this because it
helps keep all current elements / colours contrasting without too much
effort.
- I completely removed the transparency adjustments on the beatmap
panels. This always looked bad due to being applied per-layer, and I
don't think it added much.
2024-11-11 17:57:23 +09:00
Bartłomiej Dach
0cddb93dda
Move setting to user config
2024-11-11 09:57:17 +01:00
Bartłomiej Dach
a6cdf6df07
Merge branch 'master' into move-already-placed-objects-when-adjusting-offset-bpm
2024-11-11 09:50:00 +01:00
Dean Herbert
e8b69581b7
Fix top rank display not showing up on beatmaps with many difficulties
2024-11-11 17:49:34 +09:00
Dean Herbert
f8ac54d61c
Fix weird local variable typo
2024-11-11 16:59:02 +09:00
Dean Herbert
322df72cce
Merge pull request #30425 from bdach/multiplayer-song-select-wyd
...
Fix multiplayer song select not correctly applying filter sometimes
2024-11-11 14:54:48 +09:00
Dean Herbert
caedbdeccf
Merge pull request #30545 from bdach/fix-restore-storage-not-restoring-storage
...
Fix retry button on storage unavailable dialog not reopening realm if retry succeeds
2024-11-11 14:30:50 +09:00
Dan Balasescu
91d9c0a7e8
Adjust job name
2024-11-11 13:44:11 +09:00
Dan Balasescu
0b570c4e15
Enforce concurrency by using single job
...
I've yet again re-confirmed by doubts about using concurrency groups.
It's just not flexible enough. In this case, it cancels any _future_
jobs.
2024-11-11 13:40:17 +09:00
Dan Balasescu
394ff88a62
Fix empty JSON sent on non-workflow_dispatch events
2024-11-11 13:11:21 +09:00
Dan Balasescu
c1686fb687
Don't fail grep if no matches
2024-11-11 13:02:26 +09:00
Dan Balasescu
a3b8c4d127
Fix wrong cleaned up directory
2024-11-11 12:49:23 +09:00
Dan Balasescu
2767054286
Set -euo pipefail in diffcalc workflows
2024-11-11 12:49:23 +09:00
Dean Herbert
d39a46f861
Merge pull request #30508 from bdach/taiko-strong-bug
...
Fix drum rolls losing width on strong state toggle in editor
2024-11-11 12:16:51 +09:00
Dean Herbert
f897ab5a6e
Merge pull request #30566 from ppy/improve-diffcalc-workflow
...
Split diffcalc workflow to add concurrency group
2024-11-11 12:11:38 +09:00
Dean Herbert
4aa3516058
Merge pull request #30572 from Joehuu/fix-break-overlay-grades
...
Fix break overlay grades not using localised string
2024-11-10 21:13:01 +09:00
Joseph Madamba
9acfb3c900
Fix break overlay grades not using localised string
2024-11-09 16:45:18 -08:00
Dan Balasescu
5e8df623d4
Rename workflow
2024-11-09 23:49:30 +09:00
Dan Balasescu
6183daa95f
Split diffcalc workflow to add concurrency group
2024-11-09 19:59:20 +09:00
Dean Herbert
e20163652e
Merge pull request #30560 from smoogipoo/fix-nvapi
...
Fix incorrectly translated NVAPI ABI
2024-11-09 17:23:21 +09:00
Dan Balasescu
8d7b19d6cf
Fix incorrectly translated NVAPI ABI
2024-11-09 15:11:47 +09:00
Dan Balasescu
df0d51cbbc
Merge pull request #30547 from bdach/extended-nvapi-logging
...
Add extended logging to NVAPI operations
2024-11-08 19:32:51 +09:00
Bartłomiej Dach
d8fc7b1803
Add extended logging to NVAPI operations
...
To help diagnose https://github.com/ppy/osu/issues/30546 .
2024-11-08 10:29:13 +01:00
Bartłomiej Dach
091d02b3a8
Fix retry button on storage unavailable dialog not reopening realm if retry succeeds
...
Related: https://github.com/ppy/osu/issues/30539
When starting up the game with a data location that points to an
unavailable external device, a new realm file is created in the default
location. Eventually a popup is shown that informs the user that the
external storage is unavailable, and the user has an option to try the
storage again. The button that invokes said option would check said
storage correctly, but would not do anything about realm, which means
the previously opened empty realm that is placed in the default location
would remain open, which means the retry essentially doesn't work
because the user's stuff isn't there after the retry.
To fix this, take out a `BlockAllOperations()`, which will flush all
open realms, and re-open the realm on the external location if the
custom storage restore succeeds.
2024-11-08 09:28:14 +01:00
