37515 Commits

This Branch

This Branch

All Branches

• Merge pull request #12125 from bdach/rollback-ef

  Revert EF Core to version 2.2

  Dean Herbert · 2021-03-21 23:30:43 +09:00
  ee7370b21a
• Revert EF Core to version 2.2

  This reverts commit f3faad74d5, reversing
  changes made to 712e7bc7bf.
  
  Several issues arose after migrating to 5.0, including, but possibly not
  limited to, performance regressions in song select, as well as failures
  when attempting to save beatmaps after metadata changes in the editor.

  Bartłomiej Dach · 2021-03-21 11:05:15 +01:00
  a16c0641b2
• Merge pull request #12100 from bdach/invalid-thread-mutation-tablet

  Fix transform mutations from invalid thread on tablet disconnection/reconnection

  Dean Herbert · 2021-03-20 21:30:12 +09:00
  0bb6fbdd38
• Fix typo in identifier
  Bartłomiej Dach · 2021-03-20 12:37:51 +01:00
  86b569f5f7
• Schedule adding transforms on tablet changes

  Fixes `InvalidThreadForMutationException`s that pop up when
  disconnecting/reconnecting tablets during the game's operation. In those
  cases the value change callback executes from  an OpenTabletDriver
  thread.

  Bartłomiej Dach · 2021-03-20 12:37:48 +01:00
  d28bed6ed2
• Merge pull request #11824 from peppy/fix-unsafe-skinnable-sample-play

  Fix playing skinned samples being unsafe during skin changes

  Dean Herbert · 2021-03-20 11:29:34 +09:00
  2021.320.0 b9b351311a
• Fix back to front initialisation order
  Dean Herbert · 2021-03-20 10:51:58 +09:00
  ca943a897a
• Merge pull request #12090 from bdach/overlapping-object-selection

  Fix selection blueprint misbehaving with overlapping objects

  Dean Herbert · 2021-03-20 10:46:29 +09:00
  e630c1be50
• Ensure selected blueprints are given selection priority
  Bartłomiej Dach · 2021-03-19 22:44:33 +01:00
  dd48b68f8a
• Add failing test scene
  Bartłomiej Dach · 2021-03-19 22:44:33 +01:00
  8e0536e1e2
• Mark control point visualiser as possibly-null
  Bartłomiej Dach · 2021-03-19 22:44:31 +01:00
  e67c759eef
• Fix control point visualiser crashing after deselections

  `SliderSelectionBlueprint.OnDeselected()` would expire the
  `ControlPointVisualiser` on deselection, leading to its removal from the
  blueprint and eventual disposal, but still kept a separate reference to
  said visualiser in another field.
  
  This could lead to that stale reference to a disposed child getting read
  in `ReceivePositionalInputAt()`, crashing quite a ways down over at the
  framework side on futilely trying to compute the bounding box of a
  drawable with no parent.

  Bartłomiej Dach · 2021-03-19 21:40:22 +01:00
  9634560d4b
• Merge pull request #12077 from peppy/tablet-configuration

  Add tablet configuration section

  Dan Balasescu · 2021-03-19 21:49:32 +09:00
  d54e9ab481
• Merge pull request #12073 from peppy/fix-crash-toggle-overlay-before-loaded

  Avoid potential crash if an overlay is toggled before it has been loaded

  Dan Balasescu · 2021-03-19 21:38:47 +09:00
  5a6ff53837
• Merge pull request #12080 from peppy/add-25-playback-editor

  Change editor speed adjust to adjust frequency (and restore 25% option)

  Dan Balasescu · 2021-03-19 21:04:12 +09:00
  e72205eea2
• Merge pull request #12078 from peppy/make-ticks-more-visible

  Adjust timeline ticks to be more visible

  Dan Balasescu · 2021-03-19 20:54:21 +09:00
  c4d7c70841
• Fix disposal rather than performing some weird hack
  Dean Herbert · 2021-03-19 20:30:52 +09:00
  68aaf90702
• Merge branch 'master' into fix-unsafe-skinnable-sample-play
  Dean Herbert · 2021-03-19 20:29:44 +09:00
  f59327cc3e
• Rename incorrect variable
  Dean Herbert · 2021-03-19 20:25:21 +09:00
  b2d8db3a92
• Ensure aspect ratio slider gets an initial value
  Dean Herbert · 2021-03-19 20:15:29 +09:00
  63cbac3bd0
• Add checkbox to optionally disable tablet handling
  Dean Herbert · 2021-03-19 20:13:51 +09:00
  6f32c302eb
• Merge branch 'master' into tablet-configuration
  Dan Balasescu · 2021-03-19 20:09:25 +09:00
  4da9089b00
• Rewrite code to account for non-loaded edge case
  Dean Herbert · 2021-03-19 20:09:12 +09:00
  095b7f8668
• Add back the default json converter locally to ensure it's actually used
  Dean Herbert · 2021-03-19 20:07:13 +09:00
  4795170c60
• Increase maximum usable aspect ratio to account for ultrawide monitors
  Dean Herbert · 2021-03-19 20:05:18 +09:00
  86b229b1c9
• Change editor speed adjust to adjust frequency
  Dean Herbert · 2021-03-19 20:01:45 +09:00
  8955071703
• Merge pull request #12071 from peppy/visually-distinguish-slider-node-types

  Give each type of slider path type a unique colour to help visually distinguish them

  Dan Balasescu · 2021-03-19 19:53:10 +09:00
  413754ede3
• Adjust timeline ticks to be more visible
  Dean Herbert · 2021-03-19 19:45:00 +09:00
  9be7981e0d
• Fix regression meaning SkinnableSound initialisation may never happen
  Dean Herbert · 2021-03-19 19:22:50 +09:00
  c0c8b3e46c
• Always hide other overlays, even if the new one is not loaded
  Dean Herbert · 2021-03-19 19:09:39 +09:00
  bd1e2da1c2
• Merge pull request #12072 from peppy/include-default-skin-in-random-rotation

  Include the bundled skins when selecting a random skin

  Dan Balasescu · 2021-03-19 19:08:42 +09:00
  0736679016
• Merge branch 'master' into tablet-configuration
  Dean Herbert · 2021-03-19 19:06:58 +09:00
  baf4e4e8f6
• Remove no longer relevant comment
  Dean Herbert · 2021-03-19 19:01:32 +09:00
  fefb007805
• Move bindings to LoadComplete to avoid cross-thread issues
  Dean Herbert · 2021-03-19 19:01:32 +09:00
  1e82033c84
• Remove local implementation of Vector2Converter

  This has been moved to framework in
  https://github.com/ppy/osu-framework/pull/4285.

  Dean Herbert · 2021-03-19 19:01:32 +09:00
  b1c4ac9f42
• Only update tablet values on commit
  Dean Herbert · 2021-03-19 19:01:32 +09:00
  c624aa9397
• Add arbitrary value to fix FP contains check failures
  Dean Herbert · 2021-03-19 19:01:32 +09:00
  6285dcd1a1
• Add centre crosshair
  Dean Herbert · 2021-03-19 19:01:32 +09:00
  e8c20bdcb1
• Show aspect ratio for current usable area
  Dean Herbert · 2021-03-19 19:01:32 +09:00
  fb7d095e4a
• Update to use new bindables and centered area offset
  Dean Herbert · 2021-03-19 19:01:32 +09:00
  196f95ae54
• Fix margins and spacing between sub flowed items
  Dean Herbert · 2021-03-19 19:01:32 +09:00
  9d0c8902a6
• Fix initial tablet size not being initialised
  Dean Herbert · 2021-03-19 19:01:32 +09:00
  d422a65900
• Add test coverage and better UI handling of no tablet connected scenario
  Dean Herbert · 2021-03-19 19:01:32 +09:00
  9a6a0f3df5
• Remove min/max from test scene to fix weirdness when switching test sizings
  Dean Herbert · 2021-03-19 19:01:31 +09:00
  a8e319a320
• Tidy up draw hierarchy and bindable logic
  Dean Herbert · 2021-03-19 19:01:31 +09:00
  bba25a0182
• Fix remaining feedback loops
  Dean Herbert · 2021-03-19 19:01:31 +09:00
  932745e5c4
• Simplify aspect ratio application, add window conforming and direct adjustment
  Dean Herbert · 2021-03-19 19:01:31 +09:00
  e3bed4c97d
• Add aspect ratio display and limiting
  Dean Herbert · 2021-03-19 19:01:31 +09:00
  43359553c1
• Tidy up visual appearance of settings and add a reset button
  Dean Herbert · 2021-03-19 19:01:31 +09:00
  9b70f0ee1f
• Fix bounds check becoming false when using full area
  Dean Herbert · 2021-03-19 19:01:31 +09:00
  2dc2cb04c3