49087 Commits

This Branch

This Branch

All Branches

• Merge pull request #16961 from peppy/timeline-load-wait-failure

  Fix `TestSceneEditorSaving` not waiting for timeline load

  Dan Balasescu · 2022-02-22 16:12:32 +09:00
  ebdffb3cd9
• Fix TestSceneEditorSaving not waiting for timeline load

  As seen at
  https://github.com/ppy/osu/runs/5276431764?check_suite_focus=true.

  Dean Herbert · 2022-02-22 15:41:08 +09:00
  347a2346b9
• Merge pull request #16945 from peppy/three-column-playlist

  Update playlist room display to a three column layout

  Dan Balasescu · 2022-02-22 12:21:56 +09:00
  a676acd80d
• Merge pull request #16943 from peppy/spotlights-on-top
  Dean Herbert · 2022-02-22 10:08:59 +09:00
  c2af1526aa
• Merge branch 'master' into spotlights-on-top
  Bartłomiej Dach · 2022-02-21 23:42:02 +01:00
  d71e511413
• Merge branch 'master' into three-column-playlist
  Bartłomiej Dach · 2022-02-21 23:40:21 +01:00
  959f0330e0
• Merge pull request #16894 from dekrain/leaderboard-score-timeref

  Add text displaying recent score time on the leaderboard

  Bartłomiej Dach · 2022-02-21 21:16:31 +01:00
  a5af89d143
• Merge branch 'master' into leaderboard-score-timeref
  Bartłomiej Dach · 2022-02-21 20:50:00 +01:00
  e3ae52360e
• Merge pull request #16938 from smoogipoo/classic-score-hitobject-factor

  Scale classic score by hitobject count instead of max combo

  Dean Herbert · 2022-02-22 00:40:56 +09:00
  897f0ecd5f
• Fix test failures due to order change
  Dean Herbert · 2022-02-21 19:48:39 +09:00
  98c008b95f
• Update playlist room display to a three column layout

  Similar to the changes made to multiplayer.

  Dean Herbert · 2022-02-21 19:46:33 +09:00
  655b23f408
• Merge pull request #16939 from peppy/fix-intro-import-failure-ruleset-test-projects

  Add safeties to skip attempted import of the intro beatmap when osu! ruleset not present

  Dan Balasescu · 2022-02-21 18:24:56 +09:00
  0cfb85f3bb
• Merge pull request #16942 from peppy/copy-spotlight-category

  Allow room category to be copied even if `Spotlight`

  Dan Balasescu · 2022-02-21 18:21:21 +09:00
  33592b3e9e
• Update tests to match new behaviour
  Dan Balasescu · 2022-02-21 18:19:55 +09:00
  46b408be75
• Ensure spotlights always show at the top of the lounge listing

  As proposed at https://github.com/ppy/osu/discussions/16936. Spotlights
  are intended to have focus, so let's make sure they are the first thing
  the user sees for the time being.

  Dean Herbert · 2022-02-21 18:01:46 +09:00
  02a8500500
• Add test coverage of spotlights being at the top of the listing
  Dean Herbert · 2022-02-21 18:01:46 +09:00
  ab8b502709
• Allow room category to be copied even if Spotlight

  I remember that this conditional copy was added to support making copies
  of spotlight rooms without carrying across the `Spotlight` type, but in
  testing this is already handled web side to the point that it's not
  required.
  
  The rationale for allowing the copy is that this method is used for
  tests, where it was not being copied correctly from the input as
  expected (used at
  https://github.com/ppy/osu/blob/bdc3b76df0b58406796e2b08db13be7f2140fa7e/osu.Game/Tests/Visual/OnlinePlay/TestRoomManager.cs#L38).

  Dean Herbert · 2022-02-21 17:47:56 +09:00
  1737128334
• Ensure to not multiply by 0
  Dan Balasescu · 2022-02-21 17:19:35 +09:00
  c466d6df94
• Gracefully handle undefined DateTimeOffset values

  Only seems to happen in tests, but best to safeguard against this
  regardless.

  Dean Herbert · 2022-02-21 16:35:40 +09:00
  2f6e65a9a2
• Add safeties to skip attempted import of the intro beatmap when osu! ruleset not present

  In general running this import will not cause any critical failures, but
  the import itself *will* fail – and more loudly with the upcoming
  changes to `RulesetStore` (https://github.com/ppy/osu/pull/16890). Due
  to it being a loud failure, it will cause the notification overlay to
  display a parsing error, which can interrupt the flow of some tests.
  
  See test failure at
  https://github.com/ppy/osu/runs/5268848949?check_suite_focus=true as an
  example (video coverage at
  https://github.com/ppy/osu/pull/16890#issuecomment-1046542243).

  Dean Herbert · 2022-02-21 16:21:38 +09:00
  656c58567d
• Remove unused utils class
  Dean Herbert · 2022-02-21 13:43:30 +09:00
  3d0caa44c8
• Move to extension method and revert logic to match previous implementation
  Dean Herbert · 2022-02-21 13:42:26 +09:00
  fc1877b6fa
• Scale classic score by hitobject count
  Dan Balasescu · 2022-02-21 13:31:03 +09:00
  c3b365cf6b
• Add xmldoc and clean up ScoreboardTimeUtils extension methods a touch
  Dean Herbert · 2022-02-21 13:30:58 +09:00
  79408f6afc
• Remove unused using statement
  Dean Herbert · 2022-02-21 13:17:19 +09:00
  2ded7d281b
• Merge branch 'master' into leaderboard-score-timeref
  Dean Herbert · 2022-02-21 12:11:10 +09:00
  abe1a3990a
• Merge pull request #16933 from bdach/mod-overlay/basic-colour-theme

  Add all colour constants for "basic" colour theme to `OsuColour`

  Dean Herbert · 2022-02-21 11:12:34 +09:00
  85e2f68a64
• Remove static OverlayColourProviders
  Bartłomiej Dach · 2022-02-20 21:09:08 +01:00
  36a00c1ee2
• Remove all references to static OverlayColourProviders
  Bartłomiej Dach · 2022-02-20 21:09:08 +01:00
  ce0db9d4db
• Add Colour0 to OverlayColourProvider
  Bartłomiej Dach · 2022-02-20 21:09:08 +01:00
  79ba37bbab
• Add comments about OverlayColourProvider vs OsuColour distinction
  Bartłomiej Dach · 2022-02-20 21:08:58 +01:00
  2592f0900d
• Add all colour constants for "basic" colour theme to OsuColour
  Bartłomiej Dach · 2022-02-20 21:00:49 +01:00
  e20ae5b871
• Revert highlighting recent scores
  dekrain · 2022-02-19 21:23:35 +01:00
  262751a98a
• Fix CI issues
  dekrain · 2022-02-19 21:18:26 +01:00
  31b7ce053d
• Add colour highlighting recent scores
  dekrain · 2022-02-19 20:47:30 +01:00
  0d83c5a39a
• Merge scoreboard and leaderboard implementations together
  dekrain · 2022-02-19 20:47:02 +01:00
  15ed9ec4fa
• Merge pull request #16910 from peppy/fix-storyboard-background-replacement

  Fix storyboard background replacement logic not working for beatmaps with multiple backgrounds

  Dan Balasescu · 2022-02-18 19:08:52 +09:00
  65ffcefdf9
• Merge pull request #16907 from uzervlad/copy-screenshots

  Copy screenshots to clipboard

  Dean Herbert · 2022-02-18 16:31:33 +09:00
  c287b169f1
• Fix storyboard background replacement logic not working for beatmaps with multiple backgrounds

  In the case where the background image of individual difficulties is
  different, querying the beatmap *set*'s metadata as we were will cause
  issues.
  
  I haven't added test coverage for this but can if required. Can be
  manually tested using https://osu.ppy.sh/beatmapsets/1595773#osu/3377474
  (specifically the highest difficulty).
  
  Closes https://github.com/ppy/osu/discussions/16873.

  Dean Herbert · 2022-02-18 16:24:19 +09:00
  e49da2948d
• Align the bar to be on baseline of score components

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  dekrain · 2022-02-17 21:26:59 +01:00
  1abbb9ab39
• Update ScreenshotManager.cs
  OctopuSSX · 2022-02-17 20:43:36 +03:00
  08317b4265
• Merge pull request #16895 from bdach/better-new-difficulty-naming

  Name newly created difficulties in a better way

  Dean Herbert · 2022-02-17 21:54:09 +09:00
  2022.217.0 d7ef0e4174
• Merge pull request #16903 from peppy/fix-leaderboard-display

  Fix beatmap overlay leaderboards and links not working

  Dean Herbert · 2022-02-17 21:52:17 +09:00
  48dc2cbe72
• Fix incorrect mappings
  Dean Herbert · 2022-02-17 21:12:51 +09:00
  9d0023c750
• Fix beatmap overlay leaderboards and links not working

  Completely aware that this isn't how it should be done, but would like
  to get this out in a hotfix release today. Maybe changes opinions on
  https://github.com/ppy/osu/pull/16890 structure?

  Dean Herbert · 2022-02-17 21:05:00 +09:00
  3d5ed24e20
• Merge branch 'master' into better-new-difficulty-naming
  Dean Herbert · 2022-02-17 19:21:33 +09:00
  bbc4ea1203
• Merge pull request #16898 from smoogipoo/fix-mania-pp-score-multiplier

  Fix mania PP calculator applying incorrect score multiplier

  Dean Herbert · 2022-02-17 19:21:08 +09:00
  13b6cfb5ed
• Add tests for timerefs
  dekrain · 2022-02-17 10:38:29 +01:00
  f4d1e6f600
• Move the date next to the flag icon
  dekrain · 2022-02-17 10:12:35 +01:00
  7bd731ae08
• Merge pull request #16880 from smoogipoo/remove-playlistitem-beatmap

  Remove beatmap bindable from PlaylistItem

  Dean Herbert · 2022-02-17 17:47:00 +09:00
  4889750959