Dean Herbert
4f9c3fde07
Move alpha adjustment back to LegacySliderBody to correctly handle default legacy skin
2021-09-01 15:10:56 +09:00
Dean Herbert
7a447f5128
Mark SankingSliderBody as abstract
2021-09-01 15:10:24 +09:00
Dean Herbert
3f93aa1507
Fix traceable sliders incorrectly being opaque
...
Closes https://github.com/ppy/osu/issues/14449 .
Regressed in https://github.com/ppy/osu/pull/14205 .
2021-08-31 20:13:54 +09:00
Endrik Tombak
ef367c6547
Move implementation to be legacy only
2021-08-16 22:52:19 +03:00
smoogipoo
7cc0a2a76f
Refactor to fix InterpolateMovements=false
2021-08-13 12:10:33 +09:00
smoogipoo
5241029513
Use new FadeExponent shader uniform
2021-08-13 10:27:26 +09:00
TheOmyNomy
1069f9d501
Always add cursor trail for legacy cursor with disjoint trail
2021-08-13 00:13:03 +10:00
smoogipoo
f86ef54e93
Fix incorrect legacy slider body alpha
2021-08-10 17:38:51 +09:00
TheOmyNomy
24accdcab0
Add LegacyUtils class with non linear colour interpolation method
2021-08-09 18:56:47 +10:00
TheOmyNomy
140d29d537
Use helper methods instead of local valueAt() method
2021-08-08 23:54:35 +10:00
TheOmyNomy
9e805dcd44
Fix legacy slider body colour interpolation
2021-08-08 21:27:32 +10:00
Bartłomiej Dach
8e102280b7
Revert & disable case with two contradicting inspections
...
Leaving the `false` default value without the suppression triggers
`RedundantArgumentDefaultValue`, while removing it triggers
`BaseMethodCallWithDefaultParameter`.
Disable the former, because a single redundant parameter is less bad
than silent breakage if the default value of `propagateChildren` in the
base method ever changes.
2021-07-05 20:21:44 +02:00
PercyDan54
e1c646b9b2
Remove redundant arguments
2021-07-05 23:52:39 +08:00
Dean Herbert
ec71deec51
Remove some mentions of "lazer"
...
I am aware there are more throughout the codebase but intentionally left
the remaining mentioned for one reason or another. The intention here is
to mainly change user-facing versioning to change the positioning of the
"lazer" term (to be where we would expect "cuttingedge" or "beta" to
be).
2021-07-04 12:41:27 +09:00
Dean Herbert
1b0aadcc6f
Merge branch 'master' into transformers-per-skin
2021-06-22 16:03:15 +09:00
Salman Ahmed
999bf27eae
Remove unnecessary abstraction of ApproachCircle property
2021-06-21 12:07:00 +03:00
Salman Ahmed
ba15f7c19b
Move ApproachCircle out of the scale container and revert relevant changes
2021-06-21 10:47:38 +03:00
Salman Ahmed
036b745425
Remove no longer needed LegacySpinnerApproachCircle
2021-06-21 08:41:10 +03:00
Salman Ahmed
42edbe4fb9
Move ApproachCircle implementation into per-style
2021-06-21 08:40:38 +03:00
Salman Ahmed
68e28f4903
Implement IHasApproachCircle in DrawableHitCircle as well
2021-06-21 07:35:07 +03:00
Salman Ahmed
01478d780d
Generalize IHasSpinnerApproachCircle from being spinner-specifc
2021-06-21 03:43:11 +03:00
Salman Ahmed
72155a7c52
Replace if pattern-matching check with switch cases instead
2021-06-21 03:37:50 +03:00
Salman Ahmed
c3217fd8b1
Remove leftover approach circle skin component
2021-06-19 20:10:32 +03:00
Salman Ahmed
c04b09520d
Replace spinner approach circle proxying logic with hooking up to OnSkinChange in mod
2021-06-19 20:06:28 +03:00
Salman Ahmed
d6b9436151
Proxy spinner approach circle before the spinner overlay components
2021-06-18 20:34:25 +03:00
Salman Ahmed
843c8bd7a4
Move spinner approach circle to its own SkinnableDrawable
2021-06-18 20:33:50 +03:00
Salman Ahmed
c9458fd9ce
Hide spinner approach circle in "Hidden" mod
2021-06-18 06:23:54 +03:00
Salman Ahmed
9d9892e99e
Add legacy spinner approach circle implementation
2021-06-17 04:58:18 +03:00
Dean Herbert
4b45d8318e
Merge branch 'master' into transformers-per-skin
2021-06-16 16:37:28 +09:00
Salman Ahmed
52145c9237
Assign skinnable colour to spinner-background with correct default
2021-06-15 16:17:05 +03:00
Salman Ahmed
a85a592f70
Add lookup for spinner background colour
2021-06-15 16:16:25 +03:00
Salman Ahmed
fbb856d84b
Call base when overriding lookup methods
...
Rather than arbitrarily accessing `Skin` here and there.
2021-06-11 12:44:44 +03:00
Salman Ahmed
cf40282f1f
Convert LegacySkinTransformers to accept raw ISkins rather than a full ISkinSource
2021-06-09 22:49:31 +03:00
ekrctb
5418e895ae
Remove useless ClearTransforms
...
The transforms are cleared by DHO before `ApplyCustomUpdateState` is invoked.
2021-06-09 16:50:13 +09:00
ekrctb
610cdaea98
Fix circle piece animation is sometimes not playing when a replay is rewound
2021-06-09 16:14:55 +09:00
ekrctb
555ab8fccd
Fix event not unregistered on dispose
2021-06-09 12:35:14 +09:00
ekrctb
4707918c6a
Fix hit circle animation when a replay is rewound
2021-06-09 10:53:52 +09:00
Dean Herbert
88b87b98a8
Fix slider ball layer sources
2021-06-08 12:10:14 +09:00
Dean Herbert
9ebafb1ec0
Fix cursor trail logic
2021-06-06 22:26:27 +09:00
Dean Herbert
06275a6a7d
Merge branch 'master' into legacy-skin-default-fallback
2021-06-04 16:00:30 +09:00
Dean Herbert
f62a2747f6
Add legacy implementation
2021-06-04 14:51:35 +09:00
Dean Herbert
5953674737
Tidy up constants
2021-06-04 14:14:51 +09:00
Dean Herbert
ff70f99da2
Merge branch 'master' into kiai
2021-06-04 13:50:12 +09:00
Dan Balasescu
c065f761c7
Merge branch 'master' into legacy-skin-default-fallback
2021-06-02 19:08:52 +09:00
ekrctb
c06ff3c623
Remove defunct Animate calls
2021-06-02 11:46:28 +09:00
ekrctb
b82190e157
Fix hit circle animation reset when skin is changed
...
The transforms applied in `Animate` call was not applied because the piece is recreated.
2021-06-02 11:32:24 +09:00
Dean Herbert
33577cbad5
Fix multiple issues with default lookups
2021-05-31 21:29:47 +09:00
Dean Herbert
88ed95e012
Add FindProvider lookup function
2021-05-31 21:29:47 +09:00
Dean Herbert
17574833fb
Update other transformers with similar refactored logic
2021-05-30 19:15:59 +09:00
Salman Ahmed
fbc316ea1d
Fix legacy skin transformers potentially ignoring source implementations
2021-05-29 21:23:22 +03:00
