Dean Herbert
e8c0e27cc0
Adjust in line with upstream changes
2024-12-11 18:17:59 +09:00
Tim Schumacher
e920cfa187
Move rate-changing TODO to a common place in CalculateRateWithMods
2024-12-02 23:49:51 +01:00
Tim Schumacher
164b809c89
Document ready button enable state with some comments
2024-11-30 23:02:22 +01:00
Tim Schumacher
f4e155bfa6
Account for rate changing mods when disabling the "Ready" button
2024-11-30 16:01:32 +01:00
Bartłomiej Dach
c93c549b05
Fix ready button not disabling on playlist close
2024-11-28 14:17:31 +01:00
Bartłomiej Dach
9926ffd326
Make button a little narrower
2024-11-28 14:06:12 +01:00
Bartłomiej Dach
ac2c4e81c7
Use switch
2024-11-28 14:04:39 +01:00
Bartłomiej Dach
2e6f43a75d
Merge branch 'master' into close-playlists
2024-11-28 14:01:36 +01:00
Dean Herbert
70eee8882a
Remove unnecessary null check
2024-11-28 15:42:37 +09:00
Salman Alshamrani
dfbccc2144
Knock some sense into the playlists results screen implementation
...
As we're moving towards using the `/playlist/<id>/scores/<id>` endpoint,
the existing playlists results screen classes needed some restructuring.
2024-11-27 01:20:43 -05:00
Salman Alshamrani
9083daf363
Fix epic code failure
...
I wasn't feeling well last night.
2024-11-26 20:04:36 -05:00
Salman Alshamrani
c1416f9920
Bring back user-based endpoint for viewing result screen from playlists lounge
2024-11-26 01:10:12 -05:00
Salman Alshamrani
d150aeef2b
Use score-based endpoint everywhere
2024-11-26 01:01:59 -05:00
Bartłomiej Dach
cfc38df889
Add close button to playlists footer
2024-11-22 09:57:56 +01:00
Bartłomiej Dach
3b2f43012e
Merge branch 'master' into close-playlists
2024-11-22 09:02:41 +01:00
Dan Balasescu
6870c99eb2
Enable NRT for multiplayer and playlists
2024-11-21 20:32:09 +09:00
Bartłomiej Dach
a679f0736e
Add ability to close playlists within grace period after creation
2024-11-20 12:36:12 +01:00
Dean Herbert
03de518484
Fix missing updateRoomPlaylist
call
2024-11-20 16:56:22 +09:00
Dan Balasescu
bfbae9458a
Remove OnlinePlayComposite
2024-11-15 15:59:28 +09:00
Dan Balasescu
34c0f72dd6
Make Room.Playlist
non-bindable
2024-11-15 15:51:01 +09:00
Dan Balasescu
dc5337d771
Make Room.UserScore
non-bindable
2024-11-15 14:42:46 +09:00
Dan Balasescu
6c84e425f8
Make Room.MaxAttempts
non-bindable
2024-11-15 14:42:46 +09:00
Dan Balasescu
0ceaafe731
Make Room.Duration
& Room.StartDate
& Room.EndDate
non-bindable
2024-11-15 14:42:45 +09:00
Dan Balasescu
b8bae30b66
Make Room.ParticipantCount
& Room.MaxParticipants
non-bindable
2024-11-15 14:42:45 +09:00
Dan Balasescu
7e3e5208f0
Make Room.Availability
non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
81e4cb348f
Make Room.Type
non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
6160df1586
Make Room.Name
non-bindable
2024-11-15 14:29:15 +09:00
Dan Balasescu
5b2568d18b
Fix cases where the bindable is resolved directly
2024-11-13 16:38:49 +09:00
Dan Balasescu
99762da7b8
Make RoomID non-bindable
...
Most important changes are to `RoomSubScreen` and `PlaylistsRoomSubScreen`, because those are the only two cases that now bind to the event instead.
2024-11-13 16:28:54 +09:00
Dean Herbert
9323f89357
Fix "Beatmap not downloaded" tooltip hint not showing in daily challenge
2024-07-27 02:06:56 +09:00
Salman Ahmed
9d5fbb8b4f
Fix target score selection abruptly discarded after opening results screen
2024-07-25 09:01:43 +03:00
Bartłomiej Dach
d5158d1035
Fix incorrect changes around success callback refactor
2024-07-08 13:36:30 +02:00
Bartłomiej Dach
b29e535ca5
Add results screen for displaying arbitrary daily challenge scores
...
At this point its primary usage is the daily challenge event feed, but
the leaderboard will be using this too shortly.
Because the playlists results screen that exists in `master` is
hard-coupled to showing the *local user's* best result on a given
playlist by way of hard-coupling itself to the relevant API request,
allowing show of *arbitrary* score by ID requires a whole bunch of
subclassery as things stand. Oh well.
Class naming is... best effort, due to the above.
2024-07-04 13:45:24 +02:00
Bartłomiej Dach
0d2a47167c
Fix crash on calculating playlist duration when rate-changing mods are present
...
Regressed in https://github.com/ppy/osu/pull/28399 .
To reproduce, enter a playlist that has an item with a rate-changing mod
(rather than create it yourself).
This is happening because `APIRuleset` has `CreateInstance()`
unimplemented:
b4cefe0cc2/osu.Game/Online/API/Requests/Responses/APIBeatmap.cs (L159)
and only triggers when the playlist items in question originate from
web.
This is why it is bad to have interface implementations throw outside of
maybe mock implementations for tests. `CreateInstance()` is a scourge
elsewhere in general, we need way less of it in the codebase (because
while convenient, it's also problematic to implement in online contexts,
and also expensive because reflection).
2024-06-25 11:28:10 +02:00
Bartłomiej Dach
a4f8ed2a0e
Add button to access daily challenge playlist from main menu
2024-05-17 11:15:52 +02:00
Bartłomiej Dach
da953b34a7
Apply nullability annotations to ResultsScreen
& inheritors
2024-04-25 10:58:28 +02:00
Bartłomiej Dach
1e53503608
Show user statistics after completing a playlists / multiplayer score
2024-02-22 20:35:50 +01:00
Bartłomiej Dach
0074bdc5a1
Change ResultsScreen
constructor boolean params to init-only properties
2024-02-22 20:15:03 +01:00
Andrei Zavatski
2543a48ac8
Apply padding to GridContainers directly
2024-02-20 23:18:37 +03:00
Dean Herbert
fb24c66342
Mark ResultsScreen.Score
as nullable
...
Is nullable in playlist results at very least.
2024-01-29 16:43:26 +09:00
Joseph Madamba
9d87ff2986
Improve supporter-only duration notice and fix max duration of non-supporter
...
See 3c54229256/.env.example (L230)
. Might have more duration options in the future.
2023-07-26 01:37:55 -07:00
Joseph Madamba
30e0e00c52
Rename selectedAvailableDuration
to hasValidDuration
2023-07-25 22:57:01 -07:00
Joseph Madamba
0bd34a4f13
Always show supporter-only playlist durations
2023-07-25 21:14:21 -07:00
Dean Herbert
0ab0c52ad5
Automated pass
2023-06-24 01:00:03 +09:00
Dean Herbert
ce41ef6e5d
Move OrderByTotalScore()
to an extension method
2023-06-16 15:24:30 +09:00
Dan Balasescu
c33e4fe75e
Remove unnecessary override
2023-05-18 20:10:28 +09:00
Dan Balasescu
3c3c812ed6
Initial implementation of ScoreV2
2023-05-09 19:33:33 +09:00
Joseph Madamba
5dfd4180c8
Fix playlist selecting random item when not allowed after deleting
2023-01-03 11:10:02 -08:00
Dean Herbert
27c497145f
Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0
2022-12-16 18:16:26 +09:00
Bartłomiej Dach
894ef15e79
Merge branch 'master' into update-framework
2022-11-26 16:19:36 +01:00