164 Commits

• Fix code quality inspection
  Bartłomiej Dach · 2024-05-01 15:21:39 +02:00
  f0eef32913
• Fix some lines still getting forgotten about
  Dean Herbert · 2024-05-01 17:33:03 +08:00
  44091b1f35
• Don't skip lines in beatmap decoding

  Was added in cc76c58f5f without any
  specific reasoning. Likely not required (and will fix some storyboard
  elements inside `.osu` files from not being correctly saved).

  Dean Herbert · 2024-04-30 16:42:15 +08:00
  ba9f4e4baf
• Preserve storyboard events when saving a beatmap in the editor

  Until we have full encoding support for storyboards, this stop-gap
  measure ensures that storyboards don't just disappear from existence.

  Dean Herbert · 2024-04-30 00:01:56 +08:00
  fd3f4a9e7b
• Update R# + fix inspections
  Dan Balasescu · 2024-02-02 21:00:28 +09:00
  b44f77cee1
• Fix first object after break not starting a new combo
  Dan Balasescu · 2023-11-22 17:22:48 +09:00
  cb4568c4a1
• Fix insufficient leniency when querying sample points
  Bartłomiej Dach · 2023-10-20 10:26:16 +02:00
  c89081589c
• Fix beatmaps with no preview point set getting incorrect default

  Note that this will require a re-import to fix existing beatmaps
  becuse.. it's stored to realm. Probably not worth worrying about for
  now.

  Dean Herbert · 2023-10-10 19:13:16 +09:00
  2781846147
• Delete outdated warning disables
  Bartłomiej Dach · 2023-09-07 18:47:01 +02:00
  2bb869732e
• Remove all usage of LegacyDifficultyControlPoint
  Dean Herbert · 2023-09-07 17:41:57 +09:00
  b34a36f6ce
• Rename SliderVelocity to SliderVelocityMultiplier to distinguish from Velocity
  Dean Herbert · 2023-09-06 19:01:08 +09:00
  1a37543d28
• Apply NRT to osu.Game.Betamaps.Formats namespace
  Dean Herbert · 2023-08-16 19:37:24 +09:00
  49fc9655d2
• Merge branch 'master' into sample-set-controls
  Dean Herbert · 2023-05-24 14:03:04 +09:00
  298989ffd2
• Add clamping to SliderMultiplier and SliderTickRate at parsing time
  Dean Herbert · 2023-05-09 20:53:20 +09:00
  ca5e8b290f
• Rename slider multiplier variable back for now
  Dean Herbert · 2023-05-09 16:58:19 +09:00
  944da06c10
• Rename SliderMultiplier to BaseSliderVelocity
  Dean Herbert · 2023-05-08 13:13:09 +09:00
  f7d44c3013
• Split out default and sample application
  Dean Herbert · 2023-05-03 13:30:45 +09:00
  48fd99818e
• Refactor applyLegacyInfoAndDefaults for legibility
  Dean Herbert · 2023-05-03 13:26:50 +09:00
  cca15f930c
• Move pragma disable to top of LegacyBeatmapDecoder

  Makes more sense as it's used multiple times in the class.

  Dean Herbert · 2023-05-03 13:19:14 +09:00
  588a4e6196
• Merge remote-tracking branch 'upstream/master' into sample-control-points
  OliBomby · 2023-04-30 19:47:03 +02:00
  608fa3cc73
• fixed sample control point applying
  OliBomby · 2023-04-26 14:32:12 +02:00
  1b4f4372d5
• Remove IContext & add IHasGenerateTicks
  OliBomby · 2023-04-26 13:10:57 +02:00
  6c70948681
• remove ApplyLegacyInfo method
  OliBomby · 2023-04-25 12:52:21 +02:00
  891b87a5ff
• Add LegacyContext
  OliBomby · 2023-04-25 12:12:46 +02:00
  ea1e6e9798
• made the SampleControlPoint and DifficultyControlPoint obsolete
  OliBomby · 2023-04-25 11:34:09 +02:00
  a4c6850ab2
• Switched to lowercase
  Haspamelodica · 2023-04-21 02:35:28 +02:00
  e90660c1a4
• Fixed video importing bug #23259
  Haspamelodica · 2023-04-21 02:10:24 +02:00
  b62de5514c
• Gracefully handle beatmaps specifying images using the video storyboard type
  Dean Herbert · 2023-03-13 18:24:16 +09:00
  da947d8661
• Move OmitFirstBarLine to TimingControlPoint
  Dean Herbert · 2023-02-28 19:29:31 +09:00
  044b0604b2
• Fix typo
  Berkan Diler · 2022-12-26 20:38:35 +01:00
  fcbb21c75e
• Use generic Enum methods
  Berkan Diler · 2022-12-26 20:36:39 +01:00
  c7ca4bbba5
• Merge branch 'master' into fix-17143
  Dan Balasescu · 2022-10-25 13:44:58 +09:00
  6177df2a24
• Fix huge oversight causing test failures
  Dean Herbert · 2022-10-19 23:54:12 +09:00
  677b8d09f8
• Add and consume sample bank constants
  Dean Herbert · 2022-10-19 20:47:58 +09:00
  579d5b51eb
• Fix some older beatmaps having missing backgrounds

  Closes https://github.com/ppy/osu/issues/20824.
  
  Note that this will require a reimport of beatmaps as it is baked into the database. Probably not worth making a migration for at this point in time.

  Dean Herbert · 2022-10-19 16:01:10 +09:00
  59e2478b0e
• Move check to LegacyDifficultyControlPoint
  Dan Balasescu · 2022-10-13 15:05:15 +09:00
  338115ff6a
• Document why beatLength can be NaN
  Khang · 2022-08-24 02:10:19 -04:00
  c9f364d6a0
• Move GenerateTicks to LegacyDifficultyControlPoint and remove support for NaN slider velocity support for other rulesets (at least for now)
  Khang · 2022-08-23 14:07:18 -04:00
  c1ced85b5e
• Treat NaN slider velocity timing points as 1.0x but without slider ticks
  Khang · 2022-08-22 21:58:38 -04:00
  9f08c474ca
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Fix slider velocity wrongly decoded as scrolling speed in osu!catch
  ekrctb · 2022-05-08 21:49:42 +09:00
  dcf0d5a9d5
• Use a constant for the early version timing offset
  Dean Herbert · 2022-03-24 16:43:41 +09:00
  a7554dcdf7
• Use internal instead of protected internal
  Dean Herbert · 2022-02-18 17:06:04 +09:00
  a029e418cf
• Automatically use an AssemblyRulesetStore if no custom store is registered
  Dean Herbert · 2022-02-18 16:52:34 +09:00
  420e2c538f
• Register an AssemblyRulesetStore in tests which don't use OsuGameBase
  Dean Herbert · 2022-02-16 17:21:57 +09:00
  5477af08c5
• Add static RulesetStore to LegacyBeatmapDecoder
  Dean Herbert · 2022-02-16 17:13:54 +09:00
  13086541f0
• Fix approach rate not being transferred from OD on older beatmaps
  Dean Herbert · 2022-01-28 18:53:28 +09:00
  142a67e163
• Change some BeatmapInfo defaults in a backwards compatible manner
  Bartłomiej Dach · 2022-01-27 21:49:37 +01:00
  1b8136e3e0
• Update all usages of RulesetID and Ruleset.ID to use Ruleset.OnlineID
  Dean Herbert · 2022-01-27 15:38:03 +09:00
  5288eedd31
• Replace TimeSignatures enum with struct for storage of arbitrary meter
  Bartłomiej Dach · 2022-01-22 20:50:31 +01:00
  735414bc49