1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-11 21:07:33 +08:00
Commit Graph

68568 Commits

Author SHA1 Message Date
Dean Herbert
a6b442814d
Merge pull request #29185 from bdach/online-metadata-logging
Add logging when starting and stopping watch operations in online metadata client
2024-07-29 21:05:46 +09:00
Dean Herbert
7afcd72872
Fix potentially too many scores displaying in breakdown while in gameplay 2024-07-29 20:58:42 +09:00
Dean Herbert
05056f0e8a
Remove no longer required AlwaysPresent definition
This also reverts commit 7fedfd368c as
no-longer-necessary.
2024-07-29 20:43:56 +09:00
Dean Herbert
5a1002c1a0
Ensure score breakdown doesn't spam scores when not visible 2024-07-29 20:43:50 +09:00
Dean Herbert
76cd2df699
Add ability to test daily challenge carousel items when hidden 2024-07-29 20:43:47 +09:00
Dean Herbert
5bc02cc1c6
Fix background alternating not updating on message removal 2024-07-29 20:25:55 +09:00
Dean Herbert
997b3eb498
Fix typos and visuals 2024-07-29 20:24:51 +09:00
Bartłomiej Dach
8b96b0b9e4
Add logging when starting and stopping watch operations in online metadata client
For future use with debugging issues like
https://github.com/ppy/osu/issues/29138, hopefully.
2024-07-29 13:19:01 +02:00
jkh675
d51a53b051 Preventing the mod icon being squashed up 2024-07-29 19:08:14 +08:00
Dean Herbert
11265538c4
Reset online status on logout 2024-07-29 20:06:30 +09:00
Dean Herbert
c142adf926
Fix online status not persisting correctly
Regressed at some point.

I don't see much reason not to link the bindable directly with config.
It seems to work as you'd expect. Tested with logout (resets to
"Online") and connection failure (persists).

Closes https://github.com/ppy/osu/issues/29173.
2024-07-29 20:06:27 +09:00
Bartłomiej Dach
f1a84a5111
Fix mods persisting after watching replay from daily challenge screen
Closes https://github.com/ppy/osu/issues/29133.

Hope I can be forgiven for no tests. I had a brief try but writing them
is going to take hours.
2024-07-29 12:52:30 +02:00
jkh675
8f86681110 Replace OsuSpriteText with TextFlowContainer 2024-07-29 18:29:44 +08:00
jkh675
90fdf5599f Revert changes 2024-07-29 18:14:07 +08:00
Bartłomiej Dach
cebd38c6eb
Merge pull request #29163 from Joehuu/copy-lb-mods-daily
Add ability to copy leaderboard mods in daily challenge
2024-07-29 12:09:27 +02:00
Bartłomiej Dach
9b96bd1d73
Force exit to main menu when presenting scores from within playlists / multiplayer
- Closes https://github.com/ppy/osu/issues/29152
- Partially reverts https://github.com/ppy/osu/pull/29097
- Reopens https://github.com/ppy/osu/issues/26666

When testing I failed to predict that in multiplayer there can be a
different beatmap in the playlist queue. If this is the case,
`PresentScore()` will exit out to `Multiplayer`, whose `RoomSubScreen`
will update the selected item - and thus, the global beatmap - to the
next item in queue, at which point trying to play games with "not
touching the global beatmap bindable if we don't need to" fail to work,
because the bindable *must* be touched for correct operation, yet it
cannot (because `OnlinePlayScreen`s disable it).

I'm not sure what the fix is here:

- making replay player somehow independent of the global beatmap?
- not exiting out to multiplayer, but instead doing the present from the
  results screen itself? if so, then how to ensure the screen stack
  can't overflow to infinity?

so I'm just reverting the broken part. The daily challenge part is left
in because as is it should not cause issues.
2024-07-29 12:07:45 +02:00
jkh675
5ec46a79b4 Only create a new drawable object when the background is needed 2024-07-29 17:50:23 +08:00
Bartłomiej Dach
2ff0a89b4f
Convert into auto-property even more 2024-07-29 10:59:21 +02:00
Bartłomiej Dach
861b546562
Add vague test coverage 2024-07-29 10:58:05 +02:00
Bartłomiej Dach
54c904d439
Convert into auto-property 2024-07-29 10:40:29 +02:00
Bartłomiej Dach
aa7f6f81ef
Merge pull request #29127 from Joehuu/add-negative-horizontal-padding-daily
Fix daily challenge background clipping when settings/notifications is opened
2024-07-29 10:28:48 +02:00
Bartłomiej Dach
efd1919bfe
Merge pull request #29159 from frenzibyte/fix-daily-challenge-hover
Fix score breakdown tooltips appearing in other feeds
2024-07-29 10:14:32 +02:00
jkh675
63757a77a5 Extract update background method 2024-07-29 13:39:08 +08:00
Shreyas Kadambi
ae61df0abe Add back accidentally removed test 2024-07-28 11:47:00 -04:00
Shreyas Kadambi
dec6b190f2 Add optional 'suffix' to timestamp 2024-07-28 11:31:36 -04:00
Shreyas Kadambi
1c9c3c92fd Add tests for expected timestamp format 2024-07-28 11:30:42 -04:00
normalid
4e65944609 Make the tooltips width be dyanmic with the content, so the long text wont occurs wierd line break 2024-07-28 16:26:18 +08:00
normalid
5db0e36404 Use the TruncatingSpriteText in ModPresetTooltip 2024-07-28 16:18:43 +08:00
normalid
e58bdbb8a9 Improve unit test 2024-07-28 15:08:36 +08:00
Joseph Madamba
f6eb9037df Add ability to copy leaderboard mods in daily challenge 2024-07-27 23:55:56 -07:00
Salman Ahmed
7fedfd368c Fix score breakdown tooltips appearing in other feeds 2024-07-28 07:22:58 +03:00
Salman Ahmed
82fbd5b045 Rename file 2024-07-28 06:40:16 +03:00
Salman Ahmed
6bdb1107c1 Add shadow over tooltip 2024-07-28 06:35:00 +03:00
Salman Ahmed
31787757ef Provide colour scheme as part of tooltip data to handle reusing tooltip with different profile hues 2024-07-28 06:21:23 +03:00
Salman Ahmed
e82c54a31c Integrate daily challenge streak display with user profile overlay 2024-07-28 05:58:30 +03:00
Salman Ahmed
17f5d58be2 Add daily challenge streak display and tooltip 2024-07-28 05:58:27 +03:00
Salman Ahmed
0c89210bd7 Add API models for daily challenge statistics 2024-07-28 05:24:05 +03:00
normalid
4e44a6e7f8 Clean up code 2024-07-27 18:55:17 +08:00
normalid
73a98b45e9 FIx code quality 2024-07-27 18:48:45 +08:00
normalid
7f4bfb25a9 Implement unit test 2024-07-27 18:24:32 +08:00
Caiyi Shyu
77d64e0c3d replace with ReceivePositionalInputAt 2024-07-27 17:59:38 +08:00
normalid
c2711d0c4e Implement chatline background altering 2024-07-27 17:25:44 +08:00
Caiyi Shyu
fc842868a9 fix code quality 2024-07-27 16:24:20 +08:00
Caiyi Shyu
b97d96fcb0 Fix panel collapse when hovering dropdown menu 2024-07-27 15:15:14 +08:00
Joseph Madamba
d55e861b90 Fix daily challenge background clipping when settings/notifications is opened 2024-07-26 16:55:15 -07:00
Dean Herbert
565107205c
Merge pull request #29097 from bdach/dont-exit-to-menu-when-presenting-score-in-online
Don't force exit to main menu when presenting scores from within online screens
2024-07-27 02:46:58 +09:00
Dean Herbert
f2a38056b1
Merge pull request #29115 from peppy/fix-download-tooltip-text
Fix "Beatmap not downloaded" tooltip hint not showing in online play
2024-07-27 02:46:22 +09:00
Dean Herbert
9323f89357
Fix "Beatmap not downloaded" tooltip hint not showing in daily challenge 2024-07-27 02:06:56 +09:00
Caiyi Shyu
bd017aea38
fix TestPreexistingSelection failing 2024-07-26 23:58:52 +08:00
Bartłomiej Dach
834ad3524a
Merge pull request #29112 from peppy/adjust-event-feed
Adjust weight and text in event feed output
2024-07-26 17:01:13 +02:00