57109 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Dean Herbert	e53b4321ff	Ensure two day separators are not added in a row	2022-11-21 14:01:10 +09:00
Dean Herbert	fa7b45dfb1	Fix chat day separator not being added on pending message resolution ... Closes #21316.	2022-11-21 13:52:14 +09:00
Dean Herbert	dfa92b3de9	Merge pull request #21326 from bdach/fix-phantom-beatmap-sets ... Fix phantom beatmap sets appearing on carousel after delete/update	2022-11-21 13:25:14 +09:00
Dean Herbert	92aea22cd3	Merge pull request #21340 from vegguid/MetadataLanguage-FirstSetup ... Added PreferOriginalMetadataLanguage to FirstRunSetup	2022-11-21 12:16:56 +09:00
Dean Herbert	85167d8de6	Merge pull request #21343 from goodtrailer/nonsquare-smoke ... Add support for nonsquare smoke textures	2022-11-21 12:06:49 +09:00
Alden Wu	815cd56f13	Add support for nonsquare smoke textures	2022-11-20 16:50:15 -08:00
vegguid	a431b793b9	Added PreferOriginalMetadataLanguage to FirstRunSetup	2022-11-20 23:18:19 +01:00
Bartłomiej Dach	1269afd0c5	Merge pull request #21307 from frenzibyte/disable-scroll-speed-on-osu ... Hide scroll speed control from effects section on rulesets which don't support it	2022-11-20 16:17:55 +01:00
Bartłomiej Dach	0f382590e6	Remove unnecessary #nullable disable	2022-11-20 15:31:51 +01:00
Salman Ahmed	793d5b117e	Fix timing screen test scene not creating editor beatmap properly	2022-11-20 15:20:35 +03:00
Bartłomiej Dach	7b274083d3	Fix phantom beatmap sets appearing on carousel after delete/update ... Regressed in c40c70509e. As it turns out, `item.Item.Filtered.Value` is not the only condition that should be checked to determine if a carousel item should be hidden or not - `item.Item.State.Value != CarouselItemState.Collapsed` should also be true. This was even available as the `item.Item.Visible` convenience property, which is used in this commit. Failing to check `item.Item.State.Value` led to setting non-zero alpha on collapsed carousel items, leading to phantom beatmap sets appearing, as the alpha was set in the entire carousel's `Update()` method, thus firing every frame.	2022-11-20 10:08:34 +01:00
Bartłomiej Dach	b3667821eb	Add failing test case	2022-11-20 10:07:32 +01:00
Salman Ahmed	4b0ba86bd0	Identify scrolling rulesets using temporary DrawableRuleset instances	2022-11-20 04:12:52 +03:00
Salman Ahmed	58296bd4f0	Introduce IDrawableScrollingRuleset for editor consumption	2022-11-20 04:11:10 +03:00
Bartłomiej Dach	9724c6bb53	Merge pull request #21205 from Samaoo/fix-tablet-aspect-ratio-values ... Fix incorrect rounding of tablet aspect ratio values	2022-11-19 15:08:53 +01:00
Bartłomiej Dach	0c671a2a82	Merge branch 'master' into fix-tablet-aspect-ratio-values	2022-11-19 14:32:24 +01:00
Bartłomiej Dach	8bde669de1	Merge pull request #21266 from peppy/editor-test-play-dont-retain-test-time ... When returning to the editor after test play, use the original editor time rather than the point of exit	2022-11-19 12:41:25 +01:00
Bartłomiej Dach	c05c1625f2	Merge branch 'master' into editor-test-play-dont-retain-test-time	2022-11-19 12:09:04 +01:00
Salman Ahmed	60c424837b	Merge branch 'master' into disable-scroll-speed-on-osu	2022-11-19 12:13:45 +03:00
Salman Ahmed	2e3af97892	Remove unused using	2022-11-19 12:13:36 +03:00
Dean Herbert	130f776427	Merge pull request #21267 from peppy/catch-file-enumeration-errors ... Catch and gracefully handle file/directory enumeration failures during stable import	2022-11-19 15:38:40 +09:00
Dean Herbert	866b8b640a	Merge pull request #21310 from frenzibyte/fix-present-beatmap-test ... Fix intermittent present beatmap test failures	2022-11-19 15:38:07 +09:00
Dean Herbert	5fda702267	Merge pull request #21306 from frenzibyte/fix-editor-seeking-state ... Fix editor not always playing hitsounds with clock offsets applied	2022-11-19 15:08:53 +09:00
Salman Ahmed	ca67689a36	Fix intermittent present beatmap test failures	2022-11-19 07:44:43 +03:00
Salman Ahmed	290369db47	Hide scroll speed slider on rulesets which don't support it	2022-11-19 06:42:27 +03:00
Salman Ahmed	016de2f5a0	Fix editor not always playing hitsounds with clock offsets applied	2022-11-19 05:15:22 +03:00
Dean Herbert	4648e7bee0	Merge pull request #21299 from frenzibyte/perform-from-runner-load-state ... Fix "perform from screen" invoking action on non-loaded screens	2022-11-19 09:55:21 +09:00
Bartłomiej Dach	d587f29351	Update tests to reflect desired behaviour	2022-11-18 21:03:30 +01:00
Salman Ahmed	8943819ee7	Add test coverage	2022-11-18 17:49:03 +03:00
Salman Ahmed	1be8c6bd9c	Fix "perform from screen" not considering screen load state	2022-11-18 17:23:10 +03:00
Dean Herbert	b86b45b6d2	Fix excess string interpolation	2022-11-18 21:13:21 +09:00
Dean Herbert	da0de7c39e	Merge pull request #21191 from Piggey/gameplay-leaderboard-fix ... Display - symbol when tracked in-game leaderboard score is below 50	2022-11-18 20:23:21 +09:00
Dawid Sośnia	9ad484a0f4	Merge branch 'ppy:master' into gameplay-leaderboard-fix	2022-11-18 12:11:22 +01:00
Dan Balasescu	e4fc14faee	Merge pull request #21270 from peppy/auto-advance-bindings ... Auto-advance binding for ruleset key bindings	2022-11-18 16:19:54 +09:00
Dan Balasescu	9d33a6568e	Merge pull request #21292 from peppy/fix-binding-two-keys-single-binding ... Fix being able to bind two non-modifier keys to the same binding	2022-11-18 16:19:38 +09:00
Dan Balasescu	d8e99d811d	Merge pull request #21293 from frenzibyte/fix-timeline-extent-scrolling ... Fix timeline potentially scrolling at extents while not dragging	2022-11-18 16:19:30 +09:00
Dean Herbert	7c08cff297	Make new test more resilient to false passes	2022-11-18 16:10:32 +09:00
Dean Herbert	d59befc9d3	Fix initial visual state of positions before sort runs	2022-11-18 16:08:27 +09:00
Dean Herbert	0a520c979e	Update test to split out per-type tests	2022-11-18 16:03:40 +09:00
Dean Herbert	aff218dfd5	Redirect through validity function rather than overriding Sort	2022-11-18 16:03:40 +09:00
Dean Herbert	20af8217f4	Tidy up bindable flow	2022-11-18 15:50:41 +09:00
Dean Herbert	e4f522aad1	Fix inspections / typos	2022-11-18 15:47:37 +09:00
Dean Herbert	d17c091d63	Move constant to a better location	2022-11-18 15:47:31 +09:00
Salman Ahmed	e2aca8dc90	Suppress nullable warning for now	2022-11-18 09:46:50 +03:00
Dean Herbert	3faa7f5f74	Merge branch 'master' into gameplay-leaderboard-fix	2022-11-18 15:44:30 +09:00
Salman Ahmed	90cd386323	Fix timeline potentially scrolling at extents while not dragging	2022-11-18 09:43:16 +03:00
Dean Herbert	bab5be8dee	Merge pull request #21290 from smoogipoo/multiplayer-test-debug ... Add some debugging for multiplayer test failures	2022-11-18 15:39:33 +09:00
Dean Herbert	e658efbefa	Fix being able to bind two non-modifier keys to the same binding	2022-11-18 15:34:41 +09:00
Dean Herbert	cb8275ee75	Add failing test coverage to TestSceneKeyBindingPanel for multiple non-modifiers being bound	2022-11-18 15:34:41 +09:00
Dean Herbert	45f5849301	Add more test coverage to TestSceneKeyBindingPanel	2022-11-18 15:33:14 +09:00