Dean Herbert
e4b296e16e
Use OptIn serialisation on SkinInfo to avoid writing unnecessary information
2021-12-03 16:36:27 +09:00
Dean Herbert
cdf2fa9930
Serialise and deserialise SkinInfo.InstantiationInfo to allow for more correct imports
...
Until now, skins were always imported using the `LegacySkin`
instantiation type. For cases where a user has edited the lazer or
classic default (via the new skin editor), which would result in
incorrect fallback paths after exporting and importing the edited skin.
2021-12-02 18:05:16 +09:00
Dean Herbert
b976848774
Add failing test coverage of exporting default skin importing with incorrect type
2021-12-02 18:05:16 +09:00
Dean Herbert
0e82e9355b
Ensure skin is saved immediately after becoming mutable
...
Without doing this, the JSON content is not written to the file. A user
assumption is that as soon as a skin shows up in the skin list as
exportable, it should export correctly, so it makes sense that it should
be in a sane state even if the user has not made any changes in the skin
editor yet.
Going forward, we might move more of the json serialisation logic out,
and run for consistency as part of the import process. This seems like
the simplest way to guarantee things for now, though.
2021-12-02 17:42:17 +09:00
Dean Herbert
fe99d4e984
Standardise parameter naming across all file IO methods
2021-12-02 17:19:53 +09:00
Dean Herbert
ae3038ead4
Overwrite existing files if AddFile is called with an existing filename
2021-12-02 17:18:06 +09:00
Dean Herbert
ec700e9142
Remove unused using statement
2021-12-02 14:01:57 +09:00
Dean Herbert
e855a49833
Add test coverage of default skin edit and export
2021-12-02 14:01:18 +09:00
Dean Herbert
0a14acfd83
Fix incorrect conditional on export/mutate feasability of skin
2021-12-02 13:41:58 +09:00
Dean Herbert
65f0a80c97
Merge branch 'master' into realm-integration/skins-rebase
2021-12-02 13:37:20 +09:00
Dean Herbert
c82195390f
Update usage of SubscribeForNotifications
2021-12-02 13:24:16 +09:00
Bartłomiej Dach
8bef50cbba
Revert "Refactor migration precondition to read better"
...
Realm cannot translate `.All()` LINQ queries.
This reverts commit 0e0e8c25e8
2021-12-01 19:39:44 +01:00
Dan Balasescu
85c31232ac
Merge pull request #15885 from peppy/realm-subscribe-helper-methods
...
Add extension methods to add extra safety to realm subscriptions
2021-12-01 21:05:41 +09:00
Dan Balasescu
685bdd522e
Replace 'skin' in comments with 'instance'
2021-12-01 20:17:38 +09:00
Dan Balasescu
c225f8f84c
Merge branch 'master' into realm-subscribe-helper-methods
2021-12-01 20:15:21 +09:00
Dan Balasescu
af704dfe5b
Merge pull request #15878 from peppy/beatmap-lookup-cache
...
Cache beatmap metadata lookups used by multiplayer
2021-12-01 20:13:21 +09:00
Dean Herbert
bf5a186a2b
Add early abort to avoid sending empty lookup requests
2021-12-01 17:47:16 +09:00
Dean Herbert
81f82c24c3
Use new API endpoint to do batch lookups
2021-12-01 17:45:41 +09:00
Dean Herbert
a89e18de42
Merge pull request #15868 from smoogipoo/refactor-test
...
Refactor difficulty adjustment mod combinations test
2021-12-01 15:43:08 +09:00
Dean Herbert
09817ff161
Add missing returns additional documentation to main method call
2021-12-01 15:27:10 +09:00
Dean Herbert
a439209535
Add BannedSymbols rules for SubscribeForNotifications variants we use
2021-12-01 15:23:28 +09:00
Dean Herbert
4306420922
Add extension methods to add extra safety to realm subscriptions
...
Also adjusts the naming and documentation to make it (hopefully) easier
to understand what this method/process implies.
2021-12-01 15:09:53 +09:00
Dean Herbert
ea66cd6c5e
Add xmldoc and make realm ongoing transaction file op methods protected instead of public
2021-12-01 12:55:21 +09:00
Dean Herbert
8ce7467e97
Fix ordering of skins in dropdown being reverse of expected
2021-12-01 12:50:47 +09:00
Dean Herbert
0e0e8c25e8
Refactor migration precondition to read better
2021-12-01 12:48:49 +09:00
Dean Herbert
370135d484
Remove outdated TODO
2021-12-01 12:47:32 +09:00
Dean Herbert
fb2310f826
Specify config file default as DEFAULT_SKIN's guid
2021-12-01 12:45:47 +09:00
Dean Herbert
d78c18d03f
Remove excess brackets
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-12-01 12:44:25 +09:00
Dan Balasescu
0479027f64
Apply assertion fix from review
2021-12-01 11:29:02 +09:00
Dan Balasescu
7d0135063e
Merge pull request #15875 from peppy/fix-match-type-propagation
...
Fix match type not being propagated correctly to other users' settings
2021-12-01 11:23:28 +09:00
Dean Herbert
65054986ba
Merge pull request #15881 from peppy/fix-toast-mutation
2021-12-01 08:48:31 +09:00
Bartłomiej Dach
de034b4d9c
Fix test failures due to wrong asserts & uninitialised playlist
...
* The "create room" button was disabled headless due to not specifying
the imported beatmap. In visual tests it seems to work due to
selecting from the local database randomly.
* The test asserts are brought in line with expectations.
2021-11-30 20:57:08 +01:00
Bartłomiej Dach
b74b09eb3a
Add extra until step to make cause of potential failures more obvious
2021-11-30 20:56:11 +01:00
Bartłomiej Dach
faba2aa916
Merge branch 'master' into fix-toast-mutation
2021-11-30 19:32:17 +01:00
Bartłomiej Dach
c2afd7bbdc
Merge pull request #15882 from peppy/fix-invalid-screen-exist-multiplayer-test
...
Fix double screen exit in multiplayer song select tests potentially causing failure
2021-11-30 19:24:44 +01:00
Dean Herbert
dda7142f48
Fix double screen exit in multiplayer song select tests potentially causing failure
2021-12-01 02:06:40 +09:00
Dean Herbert
03e1305b3f
Fix toast display potentially causing a child mutation before load complete
2021-12-01 01:55:17 +09:00
Dean Herbert
6507acab01
Merge pull request #15880 from frenzibyte/ios-ci
2021-12-01 01:45:45 +09:00
Salman Ahmed
d18417aa27
Enable build-only iOS CI
2021-11-30 18:41:04 +03:00
Dean Herbert
0fae10500a
Fix failing tests
2021-11-30 20:09:45 +09:00
Dean Herbert
ef3d0ee0db
Merge branch 'master' into realm-integration/skins-rebase
2021-11-30 19:59:59 +09:00
Dan Balasescu
857e559f87
Merge pull request #15877 from peppy/log-response-sizes
...
Log output API request response sizes
2021-11-30 19:58:29 +09:00
Dan Balasescu
a944dd247c
Merge pull request #15851 from peppy/realm-integration/live-queryable-fix
...
Apply fixes to `RealmLive<T>` to more correctly support querying data within `PerformRead`
2021-11-30 19:49:18 +09:00
Dean Herbert
01bc330d1c
Rename method to match new purpose
2021-11-30 19:42:46 +09:00
Dean Herbert
f58c5cd9c0
Update MultiplayerClient to use BeatmapLookupCache
2021-11-30 19:36:25 +09:00
Dean Herbert
87883f1fe4
Add BeatmapLookupCache
2021-11-30 19:28:45 +09:00
Dean Herbert
23e297d414
Log output response sizes
...
Visibility is the first step towards action. Or something.
2021-11-30 19:09:13 +09:00
Dan Balasescu
8fdb9ab4e5
Merge branch 'master' into realm-integration/live-queryable-fix
2021-11-30 18:54:14 +09:00
Dan Balasescu
f849ff67d5
Merge pull request #15853 from peppy/realm-nested-context-creation-deadlock-fix
...
Fix potential deadlock on nested context creation requests
2021-11-30 18:53:57 +09:00
Dan Balasescu
daa7135381
Merge branch 'master' into realm-nested-context-creation-deadlock-fix
2021-11-30 18:01:00 +09:00
