73533 Commits

This Branch

This Branch

All Branches

• reverse group order
  WitherFlower · 2025-05-27 20:35:07 +02:00
  e2db76897e
• add grouping support for ranked and submitted date
  WitherFlower · 2025-05-27 18:49:59 +02:00
  e6f933c1c0
• Merge pull request #33289 from peppy/song-select-v2-presentation

  SongSelectV2: Add support for presenting beatmaps

  Bartłomiej Dach · 2025-05-27 13:16:35 +02:00
  6f1d7a546b
• Finalise selection before entering edit / play modes
  Dean Herbert · 2025-05-27 19:33:12 +09:00
  533e0513ad
• Add support for presenting beatmaps at song select v2
  Dean Herbert · 2025-05-27 19:33:11 +09:00
  7290f912d9
• Merge pull request #33287 from peppy/fix-selection

  SongSelectV2: Fix carousel not correctly handling traversal when current selection is filtered away

  Bartłomiej Dach · 2025-05-27 12:33:04 +02:00
  e5ba517f9c
• Fix carousel not correctly handling traversal when current selection is filtered away

  Closes https://github.com/ppy/osu/issues/33215.

  Dean Herbert · 2025-05-27 18:32:56 +09:00
  046db53857
• Update test helper methods to use non-reference comparison

  This isn't strictly required, but there should be no gaurantee or
  requirement that the references are equal in these checks, so it's best
  change them as such.

  Dean Herbert · 2025-05-27 18:32:56 +09:00
  8ccd6a4e4a
• Add failing tests showing traversal failure after selection is filtered
  Dean Herbert · 2025-05-27 18:32:56 +09:00
  0a07aef594
• Merge pull request #33285 from peppy/change-statistics-order

  SongSelectV2: Change difficulty information order to match stable

  Bartłomiej Dach · 2025-05-27 11:27:04 +02:00
  423a92b27c
• Merge pull request #33284 from peppy/fix-filter-performance-shit

  Fix filtering performance being abysmal due to implementation failure

  Bartłomiej Dach · 2025-05-27 11:18:30 +02:00
  5afe81532d
• Merge pull request #33281 from peppy/fix-switching-difficulty-split-modes

  Fix panels not updating visually when changing between difficulty sort modes

  Bartłomiej Dach · 2025-05-27 10:59:44 +02:00
  790a2f8f37
• Merge pull request #33279 from peppy/song-select-v2-reset-scroll

  SongSelectV2: Scroll to selection when mouse moves to left area

  Bartłomiej Dach · 2025-05-27 10:50:12 +02:00
  f34980ba54
• Merge pull request #33248 from chris-ehmann/fix-distance-snapping-to-stacks

  Use stacked position when determining distance snap

  Bartłomiej Dach · 2025-05-27 10:49:54 +02:00
  c7304fca48
• SongSelectV2: Change difficulty information order to match stable

  Addresses concerns at https://github.com/ppy/osu/discussions/33282.

  Dean Herbert · 2025-05-27 17:30:11 +09:00
  af7b5897e0
• Fix panels not updating visually when changing between difficulty sort modes

  I'm going with the simplest approach for this for now. If there's a
  discrepancy, clear all panels and start from scratch.
  
  Closes #33204.

  Dean Herbert · 2025-05-27 17:21:15 +09:00
  907d680188
• Fix filtering performance being abysmal due to implementation failure

  I only briefly skimmed this code during implementation becuse I assumed
  it was doing what was already proven in old song select.
  
  Turns out it was not. And it was iterating and LINQing its way to death
  (multiple seconds for <1000 beatmaps).

  Dean Herbert · 2025-05-27 17:00:10 +09:00
  d9c1d1b127
• Establish public constant for stacking lenience
  Bartłomiej Dach · 2025-05-27 09:31:14 +02:00
  f28674502f
• Add inline comment explaining depth adjustment
  Dean Herbert · 2025-05-27 16:24:28 +09:00
  cc206fad11
• Merge pull request #33268 from peppy/song-select-v2-logo-fix

  SongSelectV2: Fix multiple issues with osu! logo animations

  Bartłomiej Dach · 2025-05-27 09:00:59 +02:00
  fb5a8a2454
• Add reset scroll support when moving cursour out of carousel
  Dean Herbert · 2025-05-27 15:53:32 +09:00
  32044d745a
• Expose ability to scroll to selected in Carousel (and handle screen-wide input to allow scrolling outside of bounds)
  Dean Herbert · 2025-05-27 15:53:32 +09:00
  a50ee3b3d2
• Add test coverage of volume changing while at song select

  This passes without changes in this pull request. But I'm just copying
  across from https://github.com/ppy/osu/pull/33225 to stay in theme?

  Dean Herbert · 2025-05-27 15:53:31 +09:00
  7d8dc1bd0a
• Merge pull request #33277 from peppy/fix-score-scroll-animation

  Fix leaderboard wedge transition looking bad when user is scrolled down

  Bartłomiej Dach · 2025-05-27 08:42:07 +02:00
  1b70722333
• Merge pull request #33274 from peppy/fix-context-panels

  Fix context menus not showing for standalone panels

  Bartłomiej Dach · 2025-05-27 08:32:31 +02:00
  3962521433
• Fix leaderboard wedge transition looking bad when user is scrolled down

  Closes https://github.com/ppy/osu/issues/33227.

  Dean Herbert · 2025-05-27 14:39:25 +09:00
  070b0c0e7f
• Merge pull request #33266 from bdach/score-correct-processing-status

  Fix profile score display logic not matching website

  Dean Herbert · 2025-05-27 13:47:52 +09:00
  900cef8f20
• Adjust selected panel visuals to look better on standalone panels
  Dean Herbert · 2025-05-27 12:36:01 +09:00
  bf22160098
• Fix context menus not showing for standalone panels

  Closes https://github.com/ppy/osu/issues/33270.

  Dean Herbert · 2025-05-27 12:30:36 +09:00
  b7d862d63d
• Change actualDistance to use StackedEndPosition to match StackedPosition

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Chris · 2025-05-26 11:30:04 -07:00
  e92205b3eb
• Fix logo animations being interrupted incorrectly
  Dean Herbert · 2025-05-27 02:19:50 +09:00
  eea5a2f893
• Fix logo transitions with song select v2
  Dean Herbert · 2025-05-27 02:19:50 +09:00
  68d557b4ad
• Simplify logo tracking logic since we never have more than one logo
  Dean Herbert · 2025-05-27 02:18:25 +09:00
  4335b51edc
• Add missing current screen check

  I don't understand why stuff that was present in v1 wasn't carried
  across to v2 rather than waiting until stuff breaks a second time to fix
  it.

  Dean Herbert · 2025-05-27 02:16:56 +09:00
  d765b7e233
• Add comments around convoluted code that needs to be refactored
  Dean Herbert · 2025-05-27 02:16:48 +09:00
  b3ed1729c2
• Remove unused dependency
  Dean Herbert · 2025-05-27 02:11:43 +09:00
  e1334868e8
• Fix mod and beatmap options toggle keys not working
  Dean Herbert · 2025-05-27 01:44:06 +09:00
  bb6bdec361
• Fix backgroud blur getting stuck when returning to song select v2
  Dean Herbert · 2025-05-27 01:44:01 +09:00
  daaa90d902
• Fix placeholder animation flickering to wrong position for one frame
  Dean Herbert · 2025-05-27 00:33:25 +09:00
  be55cadc95
• Merge pull request #33241 from bdach/participant-list-transform-spam

  Implement list virtualisation in multiplayer participants list

  Dean Herbert · 2025-05-26 23:58:27 +09:00
  7cc89dfd4e
• Merge pull request #33264 from peppy/song-select-v2-hookup

  SongSelectV2: Hook up screen to carousel and move selection logic up one level

  Dean Herbert · 2025-05-26 23:49:54 +09:00
  dc09d170f3
• Merge pull request #33259 from LumpBloom7/ruleset-agnostic-concurrent-check

  Make concurrent object check ruleset specific

  Bartłomiej Dach · 2025-05-26 14:33:41 +02:00
  f043a95dbd
• Merge branch 'master' into song-select-v2-hookup
  Bartłomiej Dach · 2025-05-26 14:09:05 +02:00
  590194b525
• Fix grammar in comment
  Bartłomiej Dach · 2025-05-26 14:08:56 +02:00
  72bd8b2203
• Add TODO marking incompatible logic

  Chances are this will not be materially noticed anyway because I'm not
  even sure that unranked mod scores *can* show up on leaderboards.

  Bartłomiej Dach · 2025-05-26 13:22:18 +02:00
  bedac98e06
• Adjust tests in line with new logic
  Bartłomiej Dach · 2025-05-26 13:22:18 +02:00
  d8546d909d
• Fix profile score display logic not matching website

  Reported via e-mails.
  
  The web-side change that wasn't ported here is
  https://github.com/ppy/osu-web/pull/11151. I wanted to port it at the
  time but then ran into issues because this logic should *ideally* also
  be applied to the beatmap set overlay leaderboards, but those are
  hard-glued to `ScoreInfo`, cannot be easily weaned off it to use
  `SoloScoreInfo` instead, and I did not want to make `ScoreInfo` even
  more of a mess than it already is.
  
  This time I'm just ignoring it and adding a TODO instead because I have
  no confidence I will get review eyes on any refactor of the beatmap set
  overlay. All I'll say that such refactors would have potentially
  beneficial effects on results screens too which also (ab)use
  `ScoreInfo`.

  Bartłomiej Dach · 2025-05-26 13:11:41 +02:00
  90bc8865c9
• Merge pull request #33263 from bdach/extensive-bss-logging

  Add even more logging to beatmap submission process

  Dean Herbert · 2025-05-26 19:52:32 +09:00
  998972fc85
• Ensure protected beatmap is reselected on entering screen
  Dean Herbert · 2025-05-26 19:32:32 +09:00
  5212c27a71
• Fix beatmap background not being used at new song select
  Dean Herbert · 2025-05-26 19:32:32 +09:00
  d0a1b40a84