h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-06-01 23:40:39 +08:00
Code Issues Releases Wiki Activity

Update test helper methods to use non-reference comparison

Browse Source 
This isn't strictly required, but there should be no gaurantee or
requirement that the references are equal in these checks, so it's best
change them as such.
This commit is contained in:
Dean Herbert
2025-05-27 18:16:45 +09:00
Unverified
parent 0a07aef594
commit 8ccd6a4e4a
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game.Tests/Visual/SongSelectV2/BeatmapCarouselTestScene.cs
+6 -2
View File
@@ -220,7 +220,8 @@ namespace osu.Game.Tests.Visual.SongSelectV2
// offset by one because the group itself is included in the items list.
CarouselItem item = groupingFilter.GroupItems[g].ElementAt(panel + 1);
return ReferenceEquals(Carousel.CurrentSelection, item.Model);
return (Carousel.CurrentSelection as BeatmapInfo)?
.Equals(item.Model as BeatmapInfo) == true;
});
}
@@ -229,7 +230,10 @@ namespace osu.Game.Tests.Visual.SongSelectV2
AddUntilStep($"selected is set{set}{(diff.HasValue ? $" diff{diff.Value}" : "")}", () =>
{
if (diff != null)
return ReferenceEquals(Carousel.CurrentSelection, BeatmapSets[set].Beatmaps[diff.Value]);
{
return (Carousel.CurrentSelection as BeatmapInfo)?
.Equals(BeatmapSets[set].Beatmaps[diff.Value]) == true;
}
return BeatmapSets[set].Beatmaps.Contains(Carousel.CurrentSelection);
});