40927 Commits

Author	SHA1	Message	Date
Dean Herbert	e003462f7d	Fix beatmap updates causing one extra carousel selection	2023-12-20 19:15:02 +09:00
Dean Herbert	64f62e7d90	Fix song select running updates when screen is not active ... Who would have guessed that `Schedule` calls were there for a reason! I've tidied things up. Most of the changes I've made here are not required – the schedule is the main thing here. The reason the sound was playing is because one-too-many schedules was removed causing beatmap updates to update carousel specifics while still at the player loader screen. Note that the selection sound still plays on returning to song select, but this is not a regression. I'm looking at fixing this in a separate PR because I'm in a good place as far as understanding the logic right now and it would be a waste to leave it broken. Closes https://github.com/ppy/osu/issues/25875.	2023-12-20 17:31:09 +09:00
Dean Herbert	831c273b45	Merge pull request #25887 from smoogipoo/restore-taiko-accuracy ... Restore taiko accuracy to ScoreV2 values	2023-12-20 17:29:40 +09:00
Dan Balasescu	188c463c9c	Merge pull request #25934 from peppy/adjust-classic-mod-multiplier ... Adjust "classic" mod multiplier to 0.96x	2023-12-20 17:11:09 +09:00
Bartłomiej Dach	9a5027e556	Merge pull request #25900 from peppy/editor-from-any-carousel ... Allow choosing "Edit" from any beatmap carousel item	2023-12-20 08:35:42 +01:00
Dean Herbert	98efff0bd6	Merge pull request #25917 from rushiiMachine/remove-relax-mod-exclusions ... Allow failing with "relax" and "autopilot" mods	2023-12-20 15:48:21 +09:00
Dean Herbert	14d2d0d215	Remove ModBlockFail ... Was only being used by `NoFail` now.	2023-12-20 14:50:45 +09:00
Dan Balasescu	3818977a36	Merge pull request #25898 from peppy/song-select-stats ... Update song select to always show difficulty stats	2023-12-20 14:39:35 +09:00
Dean Herbert	d7603e8021	Adjust "classic" mod multiplier to 0.96x ... Following discussions on discord, this seems like the most agreed upon value. Increasing this is important so that imported legacy scores don't lose too much value.	2023-12-20 14:33:14 +09:00
Dean Herbert	85e5d74a16	Apply proposed changes	2023-12-20 12:42:06 +09:00
rushiiMachine	1b004dbebc	Allow Relax to fail and remove failable mod exclusions ... Allows the Relax mod to fail, and remove NF/PF/SD mod exclusion ref: https://github.com/ppy/osu/discussions/13229	2023-12-19 12:33:00 -08:00
OliBomby	c167f10ad5	fix crash from dragging near zero-length repeating object in timeline	2023-12-19 21:20:45 +01:00
OliBomby	ec578e1d9f	fix near-zero length sliders n stuff being placeable	2023-12-19 21:20:21 +01:00
Bartłomiej Dach	1ebb6262fd	Merge pull request #25895 from peppy/fix-beatmap-statsitics-reprocessing ... Fix some beatmaps being reprocessed each startup	2023-12-19 18:05:40 +01:00
Bartłomiej Dach	64b0534fb8	Merge pull request #25857 from peppy/fix-mod-settings-keyboard-adjust ... Fix mod search textbox having focus while settings are visible	2023-12-19 15:44:17 +01:00
Bartłomiej Dach	e306cc35ba	Merge branch 'master' into fix-song-select-realm-refresh-performance	2023-12-19 14:14:46 +01:00
Dean Herbert	bbfdd6892d	Allow choosing "Edit" from any beatmap carousel item	2023-12-19 19:58:49 +09:00
Dean Herbert	c556475c2c	Revert to using a more manual approach to holding focus	2023-12-19 19:46:30 +09:00
Dean Herbert	502e3edac3	Add missing invalidation call	2023-12-19 19:39:48 +09:00
Dean Herbert	2c5ca9c1c8	Change default song select tab display to local leaderboard	2023-12-19 19:31:05 +09:00
Dean Herbert	3b848e8503	Tidy up visual look	2023-12-19 19:28:02 +09:00
Dean Herbert	07bb0805e9	Move advanced stats to a more permanent location on song select	2023-12-19 19:10:43 +09:00
Dean Herbert	0a64d631e2	Add support for dual-column advanced stats	2023-12-19 19:09:47 +09:00
Dean Herbert	f09c6b8c1b	Change default values of new object counts to -1 to identify non-processed values	2023-12-19 18:20:02 +09:00
Dean Herbert	8f5d21dc70	Actually fix realm selection retention regression	2023-12-19 18:10:55 +09:00
Dean Herbert	7e9c1b2acb	Use sender's realm (because we can)	2023-12-19 17:27:52 +09:00
Bartłomiej Dach	7c05d66bd7	Add more detail to exception	2023-12-19 08:57:18 +01:00
Dean Herbert	44efa2c540	Fix incorrect ordering of items at song select when certain sort modes are used	2023-12-19 15:09:03 +09:00
Dan Balasescu	c1b55c7fac	Add ScoreProcessor methods to override numeric result	2023-12-19 13:50:31 +09:00
Susko3	cc800a18b2	Fix opening log files from notification not presenting the correct file	2023-12-18 21:11:00 +01:00
Bartłomiej Dach	8e8d9b2cd9	Merge pull request #25832 from peppy/more-background-processing-progress-notifications ... Show more comprehensive background processing progress notifications	2023-12-18 20:05:47 +01:00
Bartłomiej Dach	b8bcf7a097	Merge pull request #25856 from peppy/fix-keybaord-adjust-nc-dc ... Fix keyboard precision of nightcore/daycore adjustments being incorrect	2023-12-18 19:54:17 +01:00
Dean Herbert	9594ae7802	Update framework	2023-12-19 03:22:22 +09:00
Dean Herbert	51f4c7254c	Fix mod search textbox having focus while settings are visible ... Stopped arrow key adjust on slider bars from working. Also just felt wrong that you could type into an off-screen textbox.	2023-12-19 01:32:34 +09:00
Dean Herbert	374425ea75	Fix keyboard precision of nightcore/daycore adjustments being incorrect ... Closes https://github.com/ppy/osu/issues/25854.	2023-12-19 01:07:33 +09:00
Dean Herbert	c466775f78	Merge pull request #25821 from bdach/fix-collection-dropdown-crash ... Fix collections dropdown crashing during storage migration	2023-12-19 01:01:23 +09:00
Dean Herbert	c88c25e77f	Merge pull request #25848 from 65-7a/dropdown-search-padding ... Fix padding on dropdown search bar	2023-12-19 00:36:14 +09:00
Dean Herbert	9aaaa12809	Don't show progress notifications when there are too few items to be worthwhile	2023-12-19 00:01:09 +09:00
Dean Herbert	d81cabc063	Revert "Improve performance of attemptSelection using new cached count and LastSelected" ... This reverts commit 25df42630e.	2023-12-18 22:46:02 +09:00
Dean Herbert	25e3a8e82e	Fix a few of silly issues	2023-12-18 22:45:58 +09:00
65-7a	17f1f8bb43	Fix padding on dropdown search bar	2023-12-19 00:28:23 +11:00
Bartłomiej Dach	eeeb5aa3d4	Fix crash when creating collections named "All beatmaps" or "Manage collections..." ... Closes https://github.com/ppy/osu/issues/25834 The name fallback that was there previously since https://github.com/ppy/osu/pull/11892 was half broken. This way should be a lot less prone to failure.	2023-12-18 12:52:39 +01:00
Dean Herbert	25df42630e	Improve performance of attemptSelection using new cached count and LastSelected	2023-12-18 20:47:08 +09:00
Dean Herbert	5755fa214a	Cache non-filtered beatmap counts to massively improve count performance	2023-12-18 20:44:08 +09:00
Dean Herbert	034c5cd654	Debounce count updates for good measure	2023-12-18 20:43:23 +09:00
Dean Herbert	6fa1f5ef9b	Simplify invalidation logic ... The only case where this was checking is guaranteed by realm to only be called once.	2023-12-18 20:31:02 +09:00
Dean Herbert	87b7699fcc	Avoid calling invalidation logic per beatmap set updated ... Realm will batch the updates. We don't want to do expensive operations per set when we don't need to.	2023-12-18 20:31:02 +09:00
Dean Herbert	32cc3f9ef7	Combine multiple similar invalidation logic into single event	2023-12-18 20:31:02 +09:00
Dean Herbert	03ac2c3094	Remove some excessive logging	2023-12-18 19:20:57 +09:00
Dean Herbert	62444c3d04	Fix song select's carousel scroll position getting reset on background processing ... This only happened for users using absolute right-click scroll.	2023-12-18 19:17:59 +09:00