Dean Herbert
b5f615882f
Ensure the "Change Difficulty" menu uses up-to-date difficulty names
...
Closes https://github.com/ppy/osu/issues/29391 .
2024-08-15 17:25:30 +09:00
Salman Ahmed
7427237873
Try make code look better
2024-08-15 17:03:08 +09:00
Salman Ahmed
358572ebb3
Update code order to match everything else
2024-08-15 16:57:29 +09:00
Salman Ahmed
a421231aad
Fix beatmap skin on mania breaking HUD apart
2024-08-15 16:55:05 +09:00
Salman Ahmed
49c71f7863
Fix beatmap skin always overriding ruleset HUD components
2024-08-15 16:47:10 +09:00
Dean Herbert
4b279ecaa8
Fix mistake
2024-08-15 16:44:15 +09:00
Dean Herbert
26da2c0637
Update MultiplayerClient test output with new knowledge
2024-08-15 16:16:48 +09:00
Salman Ahmed
66adddbfb8
Actually bring back position-flipping logic and disable "closest" anchor
2024-08-15 15:50:32 +09:00
Dean Herbert
9dc496d6a7
Merge pull request #29415 from Joehuu/difficulty-name-content
...
Implement song select v2 difficulty name content component
2024-08-15 15:20:52 +09:00
Salman Ahmed
3a4546d62d
Remove x symbol from argon mania combo counter
2024-08-15 15:08:35 +09:00
Salman Ahmed
ff1ab2bb0e
Remove position-flipping logic from mania combo counters for now
...
We need a general method to do this amicably, such as an HUD target that flips the position of its children when the direction is flipped. Something to consider later.
2024-08-15 15:02:18 +09:00
Dan Balasescu
70cfac0eb8
Merge pull request #29426 from peppy/fix-dot-misalign
...
Fix some characters ('.', ',') being misaligned in legacy counters
2024-08-15 14:19:53 +09:00
Dean Herbert
054366b25d
Use zero baseline for legacy sprite text display
2024-08-15 13:07:42 +09:00
Dan Balasescu
8bfb5cedc4
Merge pull request #29406 from peppy/fix-skin-change-crash
...
Fix crash on changing skins when classic mod is enabled and game is rewound
2024-08-15 01:04:32 +09:00
Dan Balasescu
a6aa35a9b8
Merge pull request #29417 from peppy/remove-main-menu-challenge-tooltip
...
Remove daily challenge tooltip from main menu
2024-08-14 22:30:56 +09:00
Dean Herbert
e603888130
Update remaining tests to use new base class (and tidy up V2 suffixes)
2024-08-14 21:09:28 +09:00
Dean Herbert
1665d9a93e
Fix failing test setup
2024-08-14 21:01:35 +09:00
Dean Herbert
28ab65243d
Remove daily challenge tooltip from main menu
...
Now that we have a nice intro screen for the daily challenge, it's
generally thought that we want to "spoil" the beatmap until the intro is
shown.
Also I was never a huge fan of having a tooltip on a main menu button..
just feels a bit odd.
2024-08-14 20:45:27 +09:00
Dean Herbert
58d9a4adba
Merge pull request #29414 from smoogipoo/fix-daily-challenge-2
...
Add localisation for daily challenge day/week units
2024-08-14 18:45:12 +09:00
Joseph Madamba
6f2bc7e6f1
Use Content override instead
2024-08-14 00:44:03 -07:00
Joseph Madamba
11bd0c9a61
Inline single-frame layout issue comment instead
2024-08-14 00:41:43 -07:00
Dean Herbert
2174510544
Move other V2 tests to new test namespace
2024-08-14 15:51:07 +09:00
Joseph Madamba
c24f1444f9
Directly resolve IBindable<WorkingBeatmap> by making a local variant of DifficultyNameContent
2024-08-13 23:26:18 -07:00
Joseph Madamba
f8796e3192
Move resizing width and background logic to SongSelectComponentsTestScene
2024-08-13 23:26:17 -07:00
Joseph Madamba
2b41f71fd0
Workaround single-frame layout issues with {Link|Text|Fill}FlowContainers
2024-08-13 23:26:17 -07:00
Joseph Madamba
625c6fc7eb
Implement song select v2 difficulty name content component
2024-08-13 23:26:17 -07:00
Joseph Madamba
46d41cb590
Add base song select components test scene
2024-08-13 23:26:17 -07:00
Dean Herbert
7c142bcedf
Fix incorrect anchor handling in ArgonManiaComboCounter
2024-08-14 15:12:23 +09:00
Dean Herbert
e465049050
Merge branch 'master' into mania-combo-counter
2024-08-14 15:12:00 +09:00
Dan Balasescu
f882ad4a53
Add localisation for daily challenge day/week units
2024-08-14 15:10:55 +09:00
Dan Balasescu
6840f4bca4
Merge pull request #29412 from peppy/file-io-test-failure
2024-08-14 13:06:14 +09:00
Dean Herbert
dd9705b660
Fix file access test failure by forcing retries
...
See https://github.com/ppy/osu/actions/runs/10369630825/job/28708248682 .
2024-08-14 12:26:21 +09:00
Dean Herbert
78ef436ea0
Update test debug output to test second scenario
2024-08-14 12:23:47 +09:00
Dean Herbert
1b29b9bbb8
Merge pull request #29403 from smoogipoo/fix-catch-missing-objects
...
Fix fruit positions getting mangled when exploded from the plate
2024-08-14 00:59:56 +09:00
Dean Herbert
2221c4891f
Remove legacy non-pooled pathway to DrawableJudgement
2024-08-13 21:03:00 +09:00
Dean Herbert
bb0c9e2497
Add log output when judgements aren't being pooled
2024-08-13 20:57:23 +09:00
Dean Herbert
d74ac57092
Never call prepareDrawables from unsafe context
...
I can't mentally figure out *what* is causing the issue here, but in the
case where `prepareDrawables` is called from
`JudgementBody.OnSkinChanged` (only happens in a non-pooled scenario),
things go very wrong.
I think a smell test is enough for anyone to agree that the flow was
very bad. Removing this call doesn't seem to cause any issues.
`runAnimation` should always be called in `PrepareForUse` (both pooled
and non-pooled scenarios) so things should still always be in a correct
state.
Closes #29398 .
2024-08-13 20:57:20 +09:00
Dan Balasescu
3753f65139
Merge pull request #29404 from frenzibyte/fix-user-profile-ux
...
Fix user profile overlay colour resetting when selecting another ruleset
2024-08-13 20:00:57 +09:00
Dan Balasescu
69c5e6a799
Remove unused property causing CI inspection
...
I don't see this in my Rider locally. I suppose we can remove it, though
it was intentionally added so that the struct mirrors the interface.
2024-08-13 19:52:14 +09:00
Salman Ahmed
7acc1772cb
Add test coverage
2024-08-13 13:07:21 +03:00
Salman Ahmed
c9b2a5bb9c
Fix user profile overlay colour resetting when changing rulesets
2024-08-13 13:03:31 +03:00
Dan Balasescu
fbfe3a4887
Fix fruit positions getting mangled when exploded
2024-08-13 18:42:09 +09:00
Dan Balasescu
93c1a27f22
Add failing test
2024-08-13 18:34:28 +09:00
Dan Balasescu
50601544b3
Merge pull request #29402 from peppy/fix-recommender-test
...
Fix occasional test failures in `TestSceneBetmapRecommendations`
2024-08-13 18:25:01 +09:00
Dean Herbert
14a00621f8
Fix occasional test failures in TestSceneBetmapRecommendations
...
The game was being constructed befor the API was setup, which could mean
depending on test execution ordering and speed, the recommendations
array would not be filled.
Easy to reproduce by `[Solo]`ing `TestCorrectStarRatingIsUsed`.
See https://github.com/ppy/osu/runs/28689915929#r0s0 .
2024-08-13 17:28:16 +09:00
Dan Balasescu
513a666847
Merge pull request #29401 from CloneWith/patch/wiki-locale
...
Automatically use in-game language for wiki pages
2024-08-13 17:18:29 +09:00
Dan Balasescu
58354e3e68
Fix another test
...
The last two PRs didn't interact well together.
2024-08-13 17:18:11 +09:00
Dean Herbert
4f37643780
Revert "Make ManiaAction start at 1"
...
This reverts commit 952a73b005
2024-08-13 16:38:56 +09:00
Dan Balasescu
3f02869bcc
Enable NRT while we're here
2024-08-13 16:08:06 +09:00
Dean Herbert
952a73b005
Make ManiaAction start at 1
2024-08-13 15:51:33 +09:00
