Jonas Brandstötter
dcd3e5194e
Group HitResults with the same name into one column in beatmap ranking
...
Closes #29911
2024-10-12 22:53:08 +02:00
Bartłomiej Dach
baa64d1486
Migrate MusicController to Live<T> to fix broken migrations instead
2024-10-09 11:59:04 +02:00
Bartłomiej Dach
081d87fe6d
Revert 'Fix any and all migration attempts dying on MusicController'
...
This reverts commit 310eec69fc
2024-10-09 11:55:59 +02:00
Dean Herbert
270c4c4f12
Merge pull request #30151 from bdach/migration-is-completely-fucked
...
Fix several breakages with migration operation
2024-10-09 14:24:34 +09:00
Dean Herbert
d836dba982
Rename and xmldoc RealmResetEmptySet
2024-10-09 14:18:34 +09:00
Dean Herbert
48dacd1c15
Remove unused property
2024-10-09 13:45:35 +09:00
Dean Herbert
7ccb770009
Update framework
2024-10-09 12:36:51 +09:00
Bartłomiej Dach
b811b9baf6
Fix DetachedBeatmapStore special condition for detecting resets from blocking all operations failing on empty databases
...
See https://discord.com/channels/188630481301012481/188630652340404224/1293309912591368244 .
2024-10-08 23:16:17 +02:00
Bartłomiej Dach
1633cbdb66
Fix OsuGameBase.Migrate() eating exception messages for breakfast
...
Whomst've thought this was an ok thing to do? How did this pass review?
Let's leave these as rhetorical questions right now. Huge chances are
I'd implicate myself with at least one of them.
2024-10-08 23:16:17 +02:00
Bartłomiej Dach
310eec69fc
Fix any and all migration attempts dying on MusicController
...
I'm not sure why this was "fine" for as long as it apparently was,
but what `MusicController` was doing was completely incorrect and
playing with fire (accessing raw managed realm objects), which went
wrong somewhere around - admittedly -
https://github.com/ppy/osu/pull/29917 , likely because that one started
*storing* these raw managed realm objects to fields, and you know what
will happen to those after you do a migration and recycle realms.
To attempt to circumvent this, (ab)use `DetachedBeatmapStore` instead.
Which does necessitate moving it to `OsuGameBase`, but it's the simplest
way out I can see. I guess the alternative would be to faff around with
`Live<T>` but it's ugly and I'm attempting to fix this relatively quick
right now.
2024-10-08 23:16:10 +02:00
Dean Herbert
b1be31cd6a
Switch back to last tool after using grid tool, rather than always select tool
2024-10-08 17:34:51 +09:00
Dean Herbert
682023e130
Merge branch 'master' into grids-4
2024-10-08 16:26:42 +09:00
Dean Herbert
b658d9a681
Merge pull request #30073 from peppy/updates-outside-of-gameplay-only-2
...
Avoid updates (and update notifications) from appearing in more gameplay cases
2024-10-08 15:17:09 +09:00
OliBomby
076c8dec5a
Revert "Use new place grid icon"
...
This reverts commit db10202642
2024-10-07 19:06:32 +02:00
Dean Herbert
a02cda6528
Update resources
2024-10-08 01:51:56 +09:00
OliBomby
db10202642
Use new place grid icon
2024-10-07 16:51:53 +02:00
Bartłomiej Dach
84d6467e48
Merge branch 'master' into taikostatacc
2024-10-07 14:15:29 +02:00
OliBomby
7b998219d7
move grid placement tool to left toolbox
2024-10-07 12:04:14 +02:00
Dan Balasescu
aee5f0ebf5
Fix incorrect condition
2024-10-07 19:01:25 +09:00
OliBomby
d7526be243
Merge remote-tracking branch 'upstream/master' into grids-4
2024-10-07 11:56:35 +02:00
Bartłomiej Dach
f30ac5d996
Merge branch 'master' into no-combo-scaling
2024-10-07 11:50:58 +02:00
Dan Balasescu
6e659e156e
Refactoring for correctness
2024-10-07 17:50:23 +09:00
OliBomby
0a7d2395d2
fix tooltip in SettingsButton
2024-10-07 10:43:24 +02:00
Dan Balasescu
8dece70097
Merge branch 'master' into updates-outside-of-gameplay-only-2
2024-10-07 17:41:42 +09:00
Dean Herbert
11fc811e2f
Fix delete dialogs having generic "Caution" header text
...
Regressed in https://github.com/ppy/osu/pull/28363 .
2024-10-07 16:46:53 +09:00
Dean Herbert
75f15ccaba
Maybe fix compilation? Fuck knows if this is correct.
2024-10-07 16:04:24 +09:00
Dean Herbert
1ab02b93b3
Merge branch 'master' into grids-4
2024-10-07 15:42:23 +09:00
Dean Herbert
5c826be652
Merge pull request #29860 from bdach/fix-nudging
...
Only allow seek to next/previous object via keybinding if there is no selection
2024-10-07 15:36:19 +09:00
Dan Balasescu
944f8f5f67
Merge pull request #30078 from CloneWith/update/progresshover
...
Add progress tooltip for ArgonSongProgressBar
2024-10-07 15:20:50 +09:00
Dean Herbert
6e4eed657c
Fix weird mouse position handling and don't return true to event
2024-10-07 14:32:31 +09:00
Dean Herbert
b5cc45bdda
Simplify format code (and adjust formatting slightly)
2024-10-07 14:26:42 +09:00
Bartłomiej Dach
1854e1c2f9
Merge branch 'master' into form-slider-bar-transfer-value-on-commit
2024-10-07 07:21:23 +02:00
Dean Herbert
2bcbaed5b8
Update framework
2024-10-07 14:11:31 +09:00
Dean Herbert
5859021003
Merge pull request #30113 from bdach/fix-separator-jank
...
Fix improper handling of decimal separator in "form" number boxes / sliders
2024-10-07 13:42:02 +09:00
Dan Balasescu
72ac2eeb1d
Update osu!framework package
2024-10-06 07:54:56 +09:00
OliBomby
ae8abc7f35
fix readybutton and favouritebutton
2024-10-05 21:46:00 +02:00
OliBomby
cc29e8c16d
introduce tooltip to rounded button with subclass instead
2024-10-05 15:16:29 +02:00
OliBomby
ad734b1a13
Revert "Use new keyword instead of overriding TooltipText to remove setter"
...
This reverts commit 80dffa905a
2024-10-05 15:10:36 +02:00
CloneWith
d7ba4ce7f2
Refactor progress tooltip updating method
...
* Rewrite calculating logic
* Remove useless variables
2024-10-04 23:30:50 +08:00
Bartłomiej Dach
7816c41b94
Only transfer difficulty slider values on commit
...
Closes https://github.com/ppy/osu/issues/30112 .
2024-10-04 14:08:46 +02:00
Bartłomiej Dach
86c3e3e987
Replace FormSliderBar.Instantaneous with TransferValueOnCommit
...
Rather than control the propagation of the value between the slider and
the textbox, add a property that controls the propagation of the value
between the bindables inside the form control to external bindables.
This will help alleviate issues where the external bindable update
incurs overheads due to having heavy change callbacks attached.
2024-10-04 14:07:16 +02:00
Bartłomiej Dach
31aea86eab
Merge pull request #30110 from peppy/new-colour-better-ux
...
When adding a new combo colour, use the last colour as a starting point
2024-10-04 13:19:01 +02:00
Bartłomiej Dach
45a6a743a2
Fix improper handling of decimal separator in "form" number boxes / sliders
...
Spotted in passing in
https://discord.com/channels/188630481301012481/1097318920991559880/1291693852981329981 .
2024-10-04 13:12:25 +02:00
Bartłomiej Dach
96b6780e0c
Merge pull request #30101 from bdach/menu-padding-left
...
Do not add checkbox padding to the left of menu items if no item actually needs it
2024-10-04 12:22:35 +02:00
Dean Herbert
4fc0aae486
Merge pull request #30108 from bdach/default-combo-colours-in-editor
...
Initialise colours section with default combo colours if none present
2024-10-04 18:57:25 +09:00
Dean Herbert
ff2777a3b9
When adding a new combo colour, use the last colour as a starting point
...
Also opens the popover automatically because you always want to edit it.
2024-10-04 18:44:33 +09:00
Bartłomiej Dach
e136568a18
Remove linq usage to kill allocations
2024-10-04 11:25:21 +02:00
Bartłomiej Dach
61103cc712
Remove redundant initialiser
2024-10-04 11:18:09 +02:00
Bartłomiej Dach
7cd724f342
Move setup screen background preview to appropriate form control
...
See
https://discord.com/channels/188630481301012481/188630652340404224/1291361342971707463 .
2024-10-04 11:09:14 +02:00
CloneWith
fd5655455a
Adjust tooltip text format
2024-10-04 16:56:16 +08:00
