47904 Commits

This Branch

This Branch

All Branches

• Remove incorrect test assertion
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  dc9ea4adeb
• Fix incorrect realm access after new beatmap import
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  8c3dc4333d
• Allow RealmArchiveModelManager file operations to be performed on detached instances
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  64a47ff850
• Fix custom import process in TestSceneDrawableRoomPlaylist not working with realm
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  dd19487eb8
• Fix another case of test ruleset without overriding ShortName primary key
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  6613a7e4ae
• Fix TestScenePlaySongSelect failure due to detach clone depth
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  cd88ccab4f
• Fix incorrect realm factory isolation in TestScenePlaySongSelect
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  9e2ca583a3
• Add back caching in WorkingBeatmapCache
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  2ce80cc030
• Fix BeatmapDifficulty cloning regression
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  286994a808
• This file should have been deleted in a previous commit (rebase failure)
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  b5975eee33
• Fix one missed instance of GetResultSafely
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  58f8aae731
• Update null allowances across beatmaps and scores
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  f451560203
• Ensure BeatmapInfo Difficulty and Metadata is non-null
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  6033a825ed
• Fix edge cases in online availability tracker and combine query code
  Dean Herbert · 2022-01-12 17:49:10 +09:00
  a7958b1d31
• Use better method to ensure online availability tracker is in a clean state
  Dean Herbert · 2022-01-12 17:49:10 +09:00
  ca7e11057c
• Fix more incorrect test access to ILive
  Dean Herbert · 2022-01-12 17:49:10 +09:00
  ac3b7aa893
• Fix OnlinePlayBeatmapAvailabilityTracker not correctly tracking beatmap import changes
  Dean Herbert · 2022-01-12 17:49:10 +09:00
  c15efaeff2
• Fix donwload trackers not considering deleted scores
  Dean Herbert · 2022-01-12 17:49:10 +09:00
  b531cd0207
• Detach rather than consume live when presenting a beatmap
  Dean Herbert · 2022-01-12 17:49:10 +09:00
  902dc0eaec
• Fix a couple of minor issues with TestSceneBeatmapRecommendations
  Dean Herbert · 2022-01-12 17:49:10 +09:00
  8e79898e26
• Add RulesetInfo hashcode implementation and tidy up equality
  Dean Herbert · 2022-01-12 17:49:10 +09:00
  5cbd731864
• Bind ruleset to toolbar later for safety
  Dean Herbert · 2022-01-12 17:49:10 +09:00
  c33e163178
• Add missing "non-null" elements missing from some tests
  Dean Herbert · 2022-01-12 17:49:10 +09:00
  605898ec53
• Fix protected beatmaps showing up in the song select carousel
  Dean Herbert · 2022-01-12 17:49:10 +09:00
  02d0ca2741
• Remove unnecessary DI dependencies from cache test
  Dean Herbert · 2022-01-12 17:49:10 +09:00
  4b690703b3
• Fix beatmap carousel test failures
  Dean Herbert · 2022-01-12 17:49:10 +09:00
  41d90cd0b5
• Add note about BeatmapMetadata.Author being weird
  Dean Herbert · 2022-01-12 17:49:10 +09:00
  a0f8debafe
• Fix multiple tests with incorrect access to beatmap imports
  Dean Herbert · 2022-01-12 17:49:10 +09:00
  8ecfb9172e
• Fix incorrect conditional for deciding whether scores can be deleted from UI
  Dean Herbert · 2022-01-12 17:49:10 +09:00
  f4a1fa85a1
• Add support for persisting score's mods to realm
  Dean Herbert · 2022-01-12 17:49:10 +09:00
  ae8f522c20
• Remove test coverage of scores being deleted when beatmaps are

  This is not supported in realm for now. Probably best suited to a
  separate pass, similar to files, using backlink count.

  Dean Herbert · 2022-01-12 17:49:10 +09:00
  af5d3af664
• Reimplmeent IsAvailableLocally as an abstract method
  Dean Herbert · 2022-01-12 17:49:10 +09:00
  d8e75a9de4
• Update handling of ruleset nullability when handling a game-wide change
  Dean Herbert · 2022-01-12 17:49:10 +09:00
  47390d7ec3
• Fix unsupported realm operations in multiple tests
  Dean Herbert · 2022-01-12 17:49:10 +09:00
  43c7b0d2c8
• Fix ScoreInfo oversights causing automapper to fail

  Parameter in ctor *has* to be named `realmUser` else automapper will try
  to map to the `User` property.

  Dean Herbert · 2022-01-12 17:48:49 +09:00
  ba62d2c756
• Detach score during import tests to ensure original object doesn't get managed
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  33b5fa3473
• Fix many instances of User being null in score import tests
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  463a185605
• Remove assertion of ScoreInfo.Combo being database persisted
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  d19a9a0ba3
• Mention safety failures of Beatmap/Score constructors
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  83ccbc1d13
• Fix BeatmapInfo.Clone potentially not cloning if already detached
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  c831e9107a
• Ensure Score created by GameplayState has a valid ruleset
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  5dd0bb1218
• Improve legibility of RulesetInfo.Equals
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  82259ee072
• Fix TestScenePresentScore sharing metadata/difficulty across multiple beatmaps
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  fa7dddcf3c
• Add missing Ruleset in ReplayRecorder tests
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  6251713796
• Fix incorrect access to ILive in BeatmapSkinResources tests
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  7e7784b78a
• Fix incorrect BeatmapInfo.ToString implementation
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  e5af673b01
• Update FilterMatchingTest and filter code to use ruleset's OnlineID
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  f2f1adb792
• Remove incorrect test fixture specification
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  ba4ef0926f
• Fix OnlineAvailabilityTracker referencing a value in query that could potentially be null
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  a3c70ccdfc
• Reattach detached items on delete/undelete
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  b619ff1264