383 Commits

Author	SHA1	Message	Date
Gabe Livengood	dc75d55f72	allow modfailcondition to arbitrarily trigger fail	2022-06-08 14:02:15 -04:00
Dan Balasescu	6351f652a2	Fix combo starting at 0 when spectating	2022-06-06 17:56:25 +09:00
Dan Balasescu	a638392e81	Rename member	2022-06-02 16:35:50 +09:00
Dan Balasescu	055845d4f5	Throw exception on access before ApplyBeatmap()	2022-06-02 16:34:45 +09:00
Dan Balasescu	e551e48697	Use ScoreInfo overload in more places	2022-06-02 11:01:46 +09:00
Dan Balasescu	425390e13b	Refactor to reduce nested conditions	2022-06-01 09:54:47 +09:00
Dan Balasescu	50c3dfca31	Apply code reviews	2022-06-01 09:54:47 +09:00
Dan Balasescu	1e0ee1b214	Expose MaximumScoringValues for user consumption	2022-05-31 19:49:37 +09:00
Dan Balasescu	93240073a6	Rename field + rewrite xmldoc a bit	2022-05-31 19:40:07 +09:00
Dan Balasescu	28d8799e11	Add overloads to + document + expose ExtractScoringValues	2022-05-31 19:40:07 +09:00
Dan Balasescu	d6d56ee22d	Fix unintentional truncation	2022-05-31 19:40:07 +09:00
Dan Balasescu	44ca350822	Reset minimal scoring values from frames	2022-05-31 19:40:07 +09:00
Dan Balasescu	20988be6bb	Fix incorrect value	2022-05-31 19:40:07 +09:00
Dan Balasescu	6ccdb61853	Use new ComputeScore() overload in more cases	2022-05-31 19:40:02 +09:00
Dan Balasescu	2289812801	Add method to compute score from ScoringValues	2022-05-31 19:39:53 +09:00
Dan Balasescu	a809a19eec	Remove getBonusScore()	2022-05-31 19:39:42 +09:00
Dan Balasescu	d0e3e50ca7	Extract score statistics directly into ScoringValues	2022-05-31 19:39:42 +09:00
Dan Balasescu	af0f934e1a	Move raw ScoreProcessor values into ScoringValues struct	2022-05-31 19:39:38 +09:00
Dan Balasescu	132c94c1b5	Remove Ruleset parameter from ResetFromReplayFrame()	2022-05-31 17:16:23 +09:00
Dan Balasescu	5ad9692467	Adjust minimum health targets to match osu-stable	2022-05-17 19:24:51 +09:00
Salman Ahmed	cccc9d7d39	Rename method to better reflect what it's doing	2022-04-27 00:03:48 +03:00
Salman Ahmed	31f64b1381	Fix HealthProcessor fail conditions not handling multiple invocations	2022-04-26 23:27:03 +03:00
Salman Ahmed	7d32490198	Change score accuracy grading logic to be inclusive	2022-04-26 04:55:27 +03:00
Salman Ahmed	8078a8c1f8	Simplify IncreasesCombo/BreaksCombo helper method implementation	2022-03-18 17:18:42 +03:00
Salman Ahmed	5ec2d86c09	Update ScoreProcessor to use new defined helper methods	2022-03-18 15:22:53 +03:00
Salman Ahmed	fc576b1369	Separate increase/break combo helper methods from AffectsCombo	2022-03-18 15:22:01 +03:00
Dan Balasescu	3a6d254d1f	Add safeguards around incorrect ruleset sources	2022-03-15 09:20:32 +09:00
Dan Balasescu	028750936c	Apply review suggestions	2022-03-14 17:10:37 +09:00
Dan Balasescu	3fff7f4b7e	Require ScoreProcessor to receive ruleset	2022-03-14 15:51:10 +09:00
Dan Balasescu	9cc7f70872	Nullable annotate classes	2022-03-14 15:38:00 +09:00
Dan Balasescu	cf91353009	Merge branch 'master' into scoreprocessor-rework	2022-03-10 16:14:28 +09:00
Dan Balasescu	c36badab4b	Add per-ruleset score multipliers for classic scoring	2022-03-10 10:26:09 +09:00
Dan Balasescu	6fd8b4d891	Safeguard method against invalid invocation	2022-03-08 22:30:44 +09:00
Dan Balasescu	f1c40bd9ed	Rework GetScore() method signatures + implementations ... Rename legacy-facing overload to mention as much	2022-03-08 22:30:44 +09:00
Dan Balasescu	a8e99f1a95	Calculate classic score using total basic hitobject count	2022-03-08 21:49:41 +09:00
Dan Balasescu	5b6b8d1fa9	Remove GetStandardisedScore() proxy method	2022-03-08 21:49:41 +09:00
Dan Balasescu	6654977a7b	Add GetScore() overload with total hitobject count	2022-03-08 21:49:41 +09:00
Dan Balasescu	2c382bd1d9	Rename GetImmediateScore() as overload of GetScore()	2022-03-08 21:49:40 +09:00
Dan Balasescu	a352a140bc	Merge pull request #17157 from peppy/fix-statistics-json-serialisation ... Fix incorrect serialisation of submitted scores	2022-03-08 20:20:31 +09:00
Dan Balasescu	a172fc6cb8	Add IsBasic() and IsTick() extensions on HitResult	2022-03-08 18:19:12 +09:00
Dean Herbert	589a40ca2d	Add EnumMember naming to HitResult to allow for correct json serialisation	2022-03-08 17:58:37 +09:00
Dean Herbert	7215f3f66b	Fix CalculateAverageHitError throwing if there are zero HitEvents	2022-03-01 18:44:15 +09:00
Dean Herbert	159db38f8a	Add missing xmldoc	2022-02-28 19:14:43 +09:00
Dean Herbert	a41e1c80f1	Show hit error on results screen ... Leading up to implementation of "local offset", this feels like a good thing to have visible first and foremost.	2022-02-28 19:11:06 +09:00
Dan Balasescu	c466d6df94	Ensure to not multiply by 0	2022-02-21 17:19:35 +09:00
Dan Balasescu	c3b365cf6b	Scale classic score by hitobject count	2022-02-21 13:31:03 +09:00
Dean Herbert	7307e68e9c	Revert "Merge pull request #16889 from smoogipoo/remove-mod-multiplier" ... This reverts commit 252b945d3b, reversing changes made to a1b39a96cf.	2022-02-17 13:26:12 +09:00
Dan Balasescu	5dd9771c5f	Remove mod multipliers from being applied to scores	2022-02-16 16:27:27 +09:00
Dean Herbert	0f83f77d2b	Add xmldoc for new ResetFromReplayFrame method	2022-02-01 16:52:53 +09:00
Dan Balasescu	c50577e25f	Apply suggestion from review ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2022-02-01 10:48:41 +09:00