Dan Balasescu
f1c40bd9ed
Rework GetScore() method signatures + implementations
...
Rename legacy-facing overload to mention as much
2022-03-08 22:30:44 +09:00
Dan Balasescu
a8e99f1a95
Calculate classic score using total basic hitobject count
2022-03-08 21:49:41 +09:00
Dan Balasescu
5b6b8d1fa9
Remove GetStandardisedScore() proxy method
2022-03-08 21:49:41 +09:00
Dan Balasescu
6654977a7b
Add GetScore() overload with total hitobject count
2022-03-08 21:49:41 +09:00
Dan Balasescu
2c382bd1d9
Rename GetImmediateScore() as overload of GetScore()
2022-03-08 21:49:40 +09:00
Dan Balasescu
a352a140bc
Merge pull request #17157 from peppy/fix-statistics-json-serialisation
...
Fix incorrect serialisation of submitted scores
2022-03-08 20:20:31 +09:00
Dan Balasescu
d13a66a96c
Rework test scene by only relying on OnlineID
2022-03-08 20:11:56 +09:00
Dan Balasescu
4603e082f5
Merge pull request #17160 from peppy/remove-unnecessary-user-submittable-score
...
Remove `user` from `SubmittableScore`
2022-03-08 19:34:47 +09:00
Dan Balasescu
f5cd967635
Fix scores not being recalculated in beatmap listing
2022-03-08 19:07:39 +09:00
Dean Herbert
e0dc3a04f3
Merge pull request #17159 from smoogipoo/add-hitresult-helper
...
Add IsBasic() and IsTick() extensions on HitResult
2022-03-08 18:46:39 +09:00
Dean Herbert
b0f40d9e45
Remove user from SubmittableScore
...
This wasn't being used by osu-web, and included far too much unnecessary
data. Of note, `pp` and `ruleset_id` are also not strictly required, but
there's no harm in sending them so I've left them be for now.
2022-03-08 18:38:24 +09:00
Dean Herbert
6565c95b17
Remove unused variable
2022-03-08 18:19:54 +09:00
Dan Balasescu
a172fc6cb8
Add IsBasic() and IsTick() extensions on HitResult
2022-03-08 18:19:12 +09:00
Dean Herbert
0718a55ad0
Add flow to allow recovery after running an older release (with a different realm database version)
...
As brought up in https://github.com/ppy/osu/discussions/17148
2022-03-08 18:15:28 +09:00
Dean Herbert
9a347af5c7
Add test coverage of SubmittableScore serialisation to (roughly) match spec
2022-03-08 17:58:52 +09:00
Dean Herbert
589a40ca2d
Add EnumMember naming to HitResult to allow for correct json serialisation
2022-03-08 17:58:37 +09:00
Dan Balasescu
719331420c
Merge pull request #17155 from peppy/beatmap-leaderboard-dont-handle-offset-changes
...
Fix `BeatmapLeaderboard` refreshing on changes in local offset setting
2022-03-08 15:38:05 +09:00
Dean Herbert
622ec53130
Fix BeatmapLeaderboard refreshing on unrelated changes to a beatmap
2022-03-08 14:50:47 +09:00
Dean Herbert
2a55c5e02e
Add extension method to detect and isolate realm collection-level changes
2022-03-08 14:50:47 +09:00
Henry Lin
ae1c65c38d
Add xmldoc
2022-03-08 12:07:10 +08:00
Henry Lin
8cfeffc085
Extract a major part of ApplyToBeatmap to a new method
2022-03-08 11:50:30 +08:00
Henry Lin
ded84cab3f
Separate randomisation and object positioning logic
2022-03-08 11:45:16 +08:00
Bartłomiej Dach
643f68e844
Better annotate initial rolling counter value set
2022-03-07 23:11:20 +01:00
Bartłomiej Dach
019f4d965d
Show two decimal digits on mod multiplier rather than one
2022-03-07 22:55:55 +01:00
Bartłomiej Dach
c25d7a1c75
Use rolling counter for multiplier display
2022-03-07 22:50:51 +01:00
Bartłomiej Dach
78a3b5961e
Implement basic difficulty multiplier display
2022-03-07 22:50:51 +01:00
Dan Balasescu
e0d2c8ca5e
Merge pull request #17046 from peppy/clowd-squirrel
...
Replace squirrel fork with `Clowd.Squirrel`
2022-03-07 16:25:40 +09:00
Dan Balasescu
51f6eb4028
Merge pull request #17075 from peppy/realm-property-watching
...
Add ability to watch properties via a `RealmAccess` helper method
2022-03-07 14:38:23 +09:00
Dean Herbert
31d6c75f40
Merge branch 'master' into realm-property-watching
2022-03-07 13:53:17 +09:00
Dan Balasescu
b90a5864b1
Merge pull request #17138 from peppy/disallow-icon-interaction
...
Disallow interaction with carousel set difficulty icons unless selected
2022-03-07 13:00:18 +09:00
Dean Herbert
da29947ecd
Disallow interaction with carousel set difficulty icons unless selected
...
I kinda liked this flow, but from multiple reports from users it
definitely seems in the way. We can revisit after the new design is
applied to song select.
Note that this means the tooltips also don't display. If it is preferred
that they should (arguable from a UX perspective, since I'd expect to be
able to click at that point) then the issue can be addressed using a
slightly different path (a few more lines - nothing too complex).
2022-03-07 11:34:08 +09:00
Dean Herbert
bd1adaf245
Merge pull request #17115 from frenzibyte/manual-channel-scroll
...
Refactor channel scrolling container to handle non-user scrolls
2022-03-07 11:26:23 +09:00
Dan Balasescu
ba83db0229
Merge pull request #17134 from bdach/mod-overlay/popup-screen-title
...
Implement popup screen title component
2022-03-07 11:03:38 +09:00
Dean Herbert
3e73b8c78a
Merge pull request #17059 from frenzibyte/fix-storyboard-sample-rate
...
Fix storyboard samples rate not adjusted from actual gameplay mods
2022-03-07 09:41:06 +09:00
Salman Ahmed
e5a6564034
Merge branch 'master' into fix-storyboard-sample-rate
2022-03-07 03:12:40 +03:00
Salman Ahmed
d9be65ea39
Remove no longer necessary CancelUserScroll method
2022-03-06 23:58:06 +03:00
Salman Ahmed
60334046e4
Revert UserTrackingScrollContainer changes
2022-03-06 23:57:51 +03:00
Salman Ahmed
a13a087f5d
Add xmldoc to trackNewContent to explain its purpose
2022-03-06 23:51:27 +03:00
Salman Ahmed
9ec0e74813
Move scrolling to UpdateAfterChildren to avoid scheduling
...
At least that's what I believe "let FillFlow update to new size" means.
2022-03-06 23:50:58 +03:00
Salman Ahmed
9bc1f3f014
Further refactor and simplify ChannelScrollContainer
2022-03-06 23:34:12 +03:00
Bartłomiej Dach
54275813b5
Use text flow container in popup screen title
2022-03-06 20:41:31 +01:00
Bartłomiej Dach
df0617f34c
Implement popup screen title component
2022-03-06 16:09:18 +01:00
Dean Herbert
e322eb578a
Merge pull request #17116 from bdach/sample-popover-tabbing
...
Allow tabbing between textboxes in sample point popover
2022-03-06 11:45:16 +09:00
Bartłomiej Dach
e1eeb9c6bb
Allow tabbing between textboxes in sample point popover
2022-03-06 01:43:56 +01:00
Salman Ahmed
634821e49f
Use the term "programmatically" instead
2022-03-06 00:01:45 +03:00
Salman Ahmed
5b3ffb12b7
Refactor channel scrolling container to handle manual scrolls resiliently
2022-03-05 23:27:07 +03:00
Dean Herbert
4de66bb1c6
Merge pull request #17093 from peppy/offset-ui-improvements
...
Show beatmap offset adjustments in a more visual way
2022-03-06 02:17:36 +09:00
Dean Herbert
0e8ad4b143
Switch step to Until steps due to AddOnce firing logic
2022-03-06 01:50:25 +09:00
Dean Herbert
06512e8bd9
Use const for minimum height specification in final usage location
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-03-06 01:01:22 +09:00
Dean Herbert
f8ef352306
Don't consider judgements beneath the minimum height as being applicable
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-03-06 01:00:47 +09:00
