67250 Commits

This Branch

This Branch

All Branches

• Merge branch 'master' into generic-math
  Dean Herbert · 2024-04-23 22:21:31 +08:00
  221af74f95
• Update framework
  Dean Herbert · 2024-04-23 22:04:28 +08:00
  d0edf72a0c
• Fix fade-in no longer working on videos
  Dean Herbert · 2024-04-23 22:03:32 +08:00
  602b16f533
• Merge pull request #27972 from bdach/fix-mod-column-stupidity-rfc

  Fix mod select overlay columns not displaying properly sometimes

  Dean Herbert · 2024-04-23 21:59:29 +08:00
  a7327a2998
• Add a chevron to distinguish editor menus with submenus
  Dean Herbert · 2024-04-23 21:37:01 +08:00
  436203a8c1
• Merge pull request #27973 from peppy/fix-overlay-colour

  Fix settings colour scheme wrong when viewing gameplay from skin editor button

  Bartłomiej Dach · 2024-04-23 15:22:27 +02:00
  777081e941
• Fix settings colour scheme wrong when viewing gameplay from skin editor button

  Closes https://github.com/ppy/osu/issues/27949.

  Dean Herbert · 2024-04-23 20:54:48 +08:00
  804b1b0d88
• Fix mod select overlay columns not displaying properly sometimes

  Closes https://github.com/ppy/osu/issues/26504.
  
  As far as I can tell the issue is basically another manifestation of
  https://github.com/ppy/osu-framework/issues/5129, i.e. presence
  overrides causing dropped invalidations and thus completely bogus
  hierarchy state. The fix is to raise the appropriate invalidation
  manually.

  Bartłomiej Dach · 2024-04-23 13:36:12 +02:00
  f7626aba18
• Add test coverage of transforms actually being applied to video
  Dean Herbert · 2024-04-23 19:21:55 +08:00
  564dec7a14
• Allow confirming keybinding overwrite on conflict via "select" binding
  Bartłomiej Dach · 2024-04-23 12:44:16 +02:00
  1e0db1ab9f
• Add failing tests
  Bartłomiej Dach · 2024-04-23 12:41:33 +02:00
  a978518a74
• Actually apply transforms to the video
  Dean Herbert · 2024-04-23 17:37:37 +08:00
  17ca29c2c6
• Fix incorrect xmldoc

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2024-04-23 17:34:52 +08:00
  7eeac0f3b9
• Merge pull request #27866 from Joehuu/fix-online-score-export

  Fix replay export not working correctly from online leaderboards

  Bartłomiej Dach · 2024-04-23 09:08:04 +02:00
  12acdeebf1
• Merge pull request #27808 from smoogipoo/fix-incorrect-pp-counter

  Fix gameplay PP counter not matching results screen

  Bartłomiej Dach · 2024-04-23 08:43:49 +02:00
  1f010c4bfd
• Add manual test coverage of storyboard videos
  Dean Herbert · 2024-04-23 05:21:01 +08:00
  50afd48812
• Fix code quality
  Joseph Madamba · 2024-04-22 11:23:38 -07:00
  49154c0e23
• Return Task.CompletedTask instead of null
  Joseph Madamba · 2024-04-22 11:22:39 -07:00
  35eddf35c5
• Improve xmldoc wording
  Joseph Madamba · 2024-04-22 11:17:27 -07:00
  a59bf6d373
• Revert beatmap query change
  Joseph Madamba · 2024-04-22 11:15:50 -07:00
  2eda56ff08
• Remove unused DI beatmap paramater
  Dean Herbert · 2024-04-22 18:45:02 +08:00
  9e7182acf0
• Allow storboard videos to take on no-relative size when specified by a mapper
  Dean Herbert · 2024-04-22 18:44:47 +08:00
  c43c383abf
• Apply transforms to storyboard videos

  This requires that they are a `StoryboardSprite` for simplicity. Luckily
  this works just fine.

  Dean Herbert · 2024-04-22 18:43:15 +08:00
  4ae9f81c73
• Merge pull request #27895 from 64ArthurAraujo/verify-check-incorrect-audio-formats

  Add verify checks for incorrect audio formats

  Bartłomiej Dach · 2024-04-22 11:10:51 +02:00
  308744348f
• Do not attempt to pass files that don't look like audio to BASS
  Bartłomiej Dach · 2024-04-22 10:45:09 +02:00
  70a5288a68
• Add test covering non-audio file formats not being checked
  Bartłomiej Dach · 2024-04-22 10:43:20 +02:00
  b28bf4d2ec
• Merge branch 'master' into verify-check-incorrect-audio-formats
  Bartłomiej Dach · 2024-04-22 10:34:14 +02:00
  78f97d0ec7
• Use explicit reference equality check
  Bartłomiej Dach · 2024-04-22 10:27:30 +02:00
  ceeb9b0819
• Remove redundant array type specification
  Bartłomiej Dach · 2024-04-22 10:25:46 +02:00
  1bcf835d22
• Apply generic math-related changes
  Bartłomiej Dach · 2024-04-22 10:15:56 +02:00
  09b0f3005e
• Merge pull request #27964 from smoogipoo/fix-cursormiddle-fallback

  Fix `cursormiddle` not using the same source as `cursor`

  Dean Herbert · 2024-04-22 16:05:37 +08:00
  877ca48739
• Use bitwise to check hitsound formats
  Arthur Araujo · 2024-04-22 04:44:38 -03:00
  49563f4e5b
• Comment in some clarification
  Dean Herbert · 2024-04-22 15:07:11 +08:00
  fb1d20bd39
• Merge pull request #27922 from peppy/quick-exit-from-results

  Add ability to quick exit from results screen

  Dan Balasescu · 2024-04-22 16:01:13 +09:00
  89a4a6878f
• Fix cursormiddle not using the same source as cursor
  Dan Balasescu · 2024-04-22 15:01:28 +09:00
  0170c04baf
• Add failing test
  Dan Balasescu · 2024-04-22 15:01:28 +09:00
  40c48f903b
• Merge pull request #27958 from EVAST9919/editor-table-simple

  Improve `EditorTable` performance

  Dan Balasescu · 2024-04-22 13:40:28 +09:00
  a91a7b9080
• Adjust execution order
  Andrei Zavatski · 2024-04-22 07:02:49 +03:00
  1d3fd65d86
• Don't consider editor table content for input
  Andrei Zavatski · 2024-04-21 17:40:35 +03:00
  722fa228ce
• Merge pull request #27930 from peppy/update-framework

  Update framework

  Dean Herbert · 2024-04-20 05:26:53 +08:00
  b9b341affd
• Don't require hold for quick exit at results screen
  Dean Herbert · 2024-04-20 04:53:31 +08:00
  4cffc39dff
• Merge pull request #27935 from smoogipoo/serialised-drawable-sane-defaults

  Give SerialisedDrawableInfo sane defaults

  Bartłomiej Dach · 2024-04-19 17:00:49 +02:00
  3d64ffc93e
• Merge pull request #27780 from mafarrica/27105-fix-mod-search-box-focus-changes

  Fix mod search box not tracking external changes to focus state

  Bartłomiej Dach · 2024-04-19 17:00:06 +02:00
  1344ca4e19
• Give SerialisedDrawableInfo sane defaults
  Dan Balasescu · 2024-04-19 22:03:19 +09:00
  bac70da1a1
• Merge pull request #27931 from smoogipoo/remove-unused-lookup-members

  Remove unused members from GameplaySkinComponentLookup

  Dean Herbert · 2024-04-19 20:51:09 +08:00
  6e08fd7f27
• Merge pull request #27934 from smoogipoo/remove-unused-method

  Remove unused method

  Dean Herbert · 2024-04-19 20:50:34 +08:00
  fd89195304
• Remove unused method
  Dan Balasescu · 2024-04-19 20:36:24 +09:00
  ddc1b90ee1
• Remove ChannelType from messages
  Arthur Araujo · 2024-04-19 08:01:23 -03:00
  92b85beff6
• Remove unsued import and add a blankline before yield break;
  Arthur Araujo · 2024-04-19 07:39:31 -03:00
  68e86b5105
• Use periods instead of semicolons

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Arthur Araujo · 2024-04-19 07:20:59 -03:00
  eac9dededf