1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-26 00:02:56 +08:00
Commit Graph

55274 Commits

Author SHA1 Message Date
Dean Herbert
7337d4c1aa Merge branch 'master' into kps 2022-08-31 15:41:42 +09:00
Dan Balasescu
2bf74d2b38
Merge pull request #20039 from peppy/fix-skip-button-permanent-display
Fix skip button getting stuck on screen for certain beatmaps
2022-08-31 14:17:39 +09:00
Dean Herbert
cfc7c32aff
Merge pull request #20009 from frenzibyte/fix-back-to-front-comparison
Adjust weirdly back-to-front fallback comparison in `HitObjectOrderedSelectionContainer`
2022-08-31 14:14:10 +09:00
Dean Herbert
e9463f3c19 Test editor ComposeScreen tests not adding beatmap to hierarchy
Makes it hard to test anything because `EditorBeatmap`'s `Update` method
updates whether a beatmap has timing or not (enabling the placement
controls).

Also adds a basic timing point to allow for better testing.
2022-08-31 14:07:56 +09:00
Dean Herbert
93bc4b9294 Add toggle for tournament client "auto progression" behaviour
Addresses https://github.com/ppy/osu/discussions/20038.
2022-08-31 13:44:07 +09:00
Dean Herbert
a15ea71aed
Merge branch 'master' into fix-merge-crash 2022-08-31 13:28:57 +09:00
Dean Herbert
51346e0154 Fix skip button getting stuck on screen for certain beatmaps
Closes #20034.
2022-08-31 13:22:51 +09:00
Dean Herbert
7ce1cf7560 Add test coverage of skip button failure with equal time 2022-08-31 13:22:51 +09:00
Dan Balasescu
1908a2e394
Merge pull request #20025 from peppy/fix-results-sample-glitching
Fix audio glitching when showing results screen with many scores
2022-08-31 13:10:08 +09:00
Dan Balasescu
cb4fd08f27
Merge pull request #20031 from peppy/fix-replay-file-missing-crash
Fix crash when attempting to watch a replay when the storage file doesn't exist
2022-08-31 13:06:45 +09:00
Dean Herbert
8b9ccc66b7 Update ProgressNotification font spec to match other notifications 2022-08-31 12:49:28 +09:00
Dean Herbert
85442fe032 Adjust dismiss button background colour to avoid conflict with background 2022-08-31 12:48:30 +09:00
Dean Herbert
c573396ab6 Fix IntroTestScene not clearing previous notifications hard enough 2022-08-31 12:46:54 +09:00
Dean Herbert
7c72c6b43f Fix unread count potentially missing notifications in a transforming state 2022-08-31 12:46:43 +09:00
Dean Herbert
0558dae917 Mark toasts as read when closing the overlay for added safety
I'm not sure how the read status will play out going forward so I'm just
adding this to keep things conforming for now.
2022-08-31 12:46:04 +09:00
Dean Herbert
3d93e0ded1
Merge branch 'master' into fix-resume-skip-forward 2022-08-31 12:16:15 +09:00
Bartłomiej Dach
0afa775f3f
Merge pull request #20029 from peppy/profile-header-assert
Assert non-null in `ProfileHeader` to appease r#
2022-08-30 21:36:32 +02:00
apollo-dw
ad650adab0 Fix speed note count sum 2022-08-30 18:03:44 +01:00
Dean Herbert
9eb615f942 Fix remaining test failures by strengthening PlayerLoader tests
- Click using `TriggerClick` as notifications move around quite a bit.
- Ensure any notifications from a previous test method are cleaned up.
2022-08-31 01:40:30 +09:00
Dean Herbert
31a9980686 Update remaining test expectations with new behaviour 2022-08-31 00:57:30 +09:00
Dean Herbert
a62ba9e0d9 Remove notification blocking behaviour of first run setup 2022-08-31 00:57:18 +09:00
Dean Herbert
ed11b1ba6f Improve forwarding flow to not use piling delegates 2022-08-31 00:40:53 +09:00
sw1tchbl4d3
a9aa928ce6 Fix test, make strong hits have LargeBonus judgement 2022-08-30 15:00:46 +02:00
sw1tchbl4d3
b185194d07 Apply comments by smoogi 2022-08-30 14:44:44 +02:00
Dean Herbert
224ab29ef4 Don't dismiss toasts while hovered (and adjust timings slightly) 2022-08-30 21:19:51 +09:00
Dean Herbert
403fc18976 Fix notification completion events not being run when overlay not visible 2022-08-30 21:13:43 +09:00
Dean Herbert
a7110666a0 Play notification appear sample immediately 2022-08-30 21:13:43 +09:00
Dean Herbert
95ce78a50c Reduce notification post delay now that it's less important 2022-08-30 21:13:43 +09:00
Dean Herbert
e9cfaa76c9 Change global overlay ordering so notification toasts display above settings 2022-08-30 21:13:43 +09:00
Dean Herbert
b8300ae60a Add toast notification tray 2022-08-30 21:13:43 +09:00
Dean Herbert
7b006f1f22 Add flash when a new notification is displayed to draw attention 2022-08-30 20:34:27 +09:00
Dean Herbert
60413e3e7b Enable masking for main content to avoid underlap with close button on word wrap failure. 2022-08-30 19:17:41 +09:00
Dean Herbert
6b71b4656d Remove ProgressNotification vertical movement and delay 2022-08-30 19:16:59 +09:00
Dean Herbert
928bce8fcd Fix crash when attempting to watch a replay when the storage file doesn't exist 2022-08-30 18:18:46 +09:00
Dean Herbert
d600058c98 Assert non-null in ProfileHeader to appease r# 2022-08-30 18:09:10 +09:00
Dean Herbert
c846bf20a7 Add background hover and adjust remaining metrics 2022-08-30 18:06:48 +09:00
Dean Herbert
bea12ab3c2 Rename NotificationContent to MainContent 2022-08-30 18:06:48 +09:00
Dean Herbert
09aa3e065d Move colouring to full icon content rather than background 2022-08-30 18:06:48 +09:00
Dean Herbert
0f203531d9 Allow customising the "close" button icon 2022-08-30 18:06:48 +09:00
Dean Herbert
1484ae19f0 Initial design update pass 2022-08-30 18:06:48 +09:00
Dan Balasescu
0e68620f70
Merge pull request #20026 from peppy/notifications-nrt
Apply NRT to notification classes
2022-08-30 17:23:11 +09:00
Dean Herbert
e39d236f27
Merge pull request #20028 from smoogipoo/add-legacy-total-score
Add LegacyTotalScore to SoloScoreInfo
2022-08-30 16:39:25 +09:00
Dean Herbert
b8fda1a16f Apply NRT to notification classes
and tidy things up a bit.
2022-08-30 15:57:10 +09:00
Dan Balasescu
799c015bff Add LegacyTotalScore to SoloScoreInfo 2022-08-30 15:50:19 +09:00
Dean Herbert
ea7e5797d1
Merge pull request #20024 from smoogipoo/populate-maximum-statistics-test
Populate `MaximumStatistics` for test scores
2022-08-30 15:44:52 +09:00
Dan Balasescu
8b3742188f Fix test by also clearing out maximum statistics 2022-08-30 15:42:36 +09:00
Dan Balasescu
5202c15a0e Populate MaximumStatistics for test scores 2022-08-30 15:11:39 +09:00
Dean Herbert
5d41fdfc89 Remove unnecessary usage of DrawableAudioMixer in ScorePanel 2022-08-30 15:05:21 +09:00
Dean Herbert
706ac3e44f
Merge pull request #19982 from OliBomby/fix-illegal-merge
Fixed 0 length merge being allowed
2022-08-30 12:28:18 +09:00
OliBomby
44916c51d7 Updated canMerge check to be totally accurate 2022-08-30 00:18:55 +02:00