Dan Balasescu
|
aaa6f963bd
|
Fix potential test failures due to Setup/SetUpSteps ordering
|
2022-07-29 15:27:39 +09:00 |
|
Dean Herbert
|
1a22377e19
|
Fix test deadlock due to TPL threadpool saturation
As found in aggressive CI runs:
```csharp
00007F6F527F32B0 00007f74f937c72d (MethodDesc 00007f74f5545a78 + 0x22d System.Threading.ManualResetEventSlim.Wait(Int32, System.Threading.CancellationToken)), calling (MethodDesc 00007f74f51c0838 + 0 System.Threading.Monitor.Wait(System.Object, Int32))
00007F6F527F3330 00007f74f93861ca (MethodDesc 00007f74f5259100 + 0x10a System.Threading.Tasks.Task.SpinThenBlockingWait(Int32, System.Threading.CancellationToken)), calling (MethodDesc 00007f74f5545a78 + 0 System.Threading.ManualResetEventSlim.Wait(Int32, System.Threading.CancellationToken))
00007F6F527F3390 00007f74f9385d11 (MethodDesc 00007f74f52590e8 + 0x81 System.Threading.Tasks.Task.InternalWaitCore(Int32, System.Threading.CancellationToken)), calling (MethodDesc 00007f74f5259100 + 0 System.Threading.Tasks.Task.SpinThenBlockingWait(Int32, System.Threading.CancellationToken))
00007F6F527F33E0 00007f74fc3823af (MethodDesc 00007f74f5934c08 + 0x4f System.Threading.Tasks.Task`1[[System.Boolean, System.Private.CoreLib]].GetResultCore(Boolean)), calling (MethodDesc 00007f74f52590e8 + 0 System.Threading.Tasks.Task.InternalWaitCore(Int32, System.Threading.CancellationToken))
00007F6F527F3400 00007f74fb0aad92 (MethodDesc 00007f74fb28b000 + 0x122 osu.Game.Tests.Visual.OnlinePlay.OnlinePlayTestScene+<>c__DisplayClass21_0.<Setup>b__1(osu.Game.Online.API.APIRequest)), calling (MethodDesc 00007f74f5934be8 + 0 System.Threading.Tasks.Task`1[[System.Boolean, System.Private.CoreLib]].get_Result())
00007F6F527F3470 00007f74fa9c6dd7 (MethodDesc 00007f74f921f6c8 + 0x77 osu.Game.Online.API.DummyAPIAccess.PerformAsync(osu.Game.Online.API.APIRequest))
00007F6F527F34C0 00007f74fb13c718 (MethodDesc 00007f74fb4e0c50 + 0x538 osu.Game.Database.OnlineLookupCache`3+<performLookup>d__13[[System.Int32, System.Private.CoreLib],[System.__Canon, System.Private.CoreLib],[System.__Canon, System.Private.CoreLib]].MoveNext())
```
Going with the simplest solution, as what we had was pretty ugly to start with and I don't want to overthink this, just push a fix and hope for the best.
|
2022-06-26 16:42:29 +09:00 |
|
Dan Balasescu
|
f8830c6850
|
Automated #nullable processing
|
2022-06-17 16:37:17 +09:00 |
|
Dean Herbert
|
477e520766
|
Add comment regarding deadlock avoidance
|
2022-05-31 12:24:44 +09:00 |
|
Dean Herbert
|
f935f034c2
|
Ensure request handling for OnlinePlayTestScene runs in a scheduled fashion
|
2022-05-30 16:33:07 +09:00 |
|
Dan Balasescu
|
48573d2401
|
Move test request handling earlier in setup
|
2022-02-15 23:50:10 +09:00 |
|
Dan Balasescu
|
ccd265ebe7
|
Handle beatmap lookup requests in TestRoomRequestsHandler
|
2022-02-15 23:41:50 +09:00 |
|
Dan Balasescu
|
2675bb87ff
|
Add BeatmapLookupCache as another dependency
|
2022-02-15 21:05:25 +09:00 |
|
Dan Balasescu
|
c48a0dc993
|
Move UserLookupCache to online play test dependencies
|
2022-02-15 20:56:46 +09:00 |
|
Dan Balasescu
|
b2276baf71
|
Seal OnlinePlayTestScene.CreateChildDependencies()
|
2022-02-15 20:55:57 +09:00 |
|
smoogipoo
|
bacaa9d201
|
Fix playlists test crash
|
2021-10-28 16:48:17 +09:00 |
|
smoogipoo
|
f3dba49aae
|
Rename room managers
|
2021-10-27 19:36:32 +09:00 |
|
smoogipoo
|
85b21174dd
|
Fix online play test request handling
|
2021-10-27 14:49:50 +09:00 |
|
smoogipoo
|
352949069a
|
Move filter to LoungeSubScreen
|
2021-08-17 09:36:43 +09:00 |
|
smoogipoo
|
c93c615f5e
|
Also fix up interface names
|
2021-06-25 20:15:30 +09:00 |
|
smoogipoo
|
1ed61b9b98
|
Fix up dependencies class names
|
2021-06-25 20:11:38 +09:00 |
|
smoogipoo
|
a27a647ae7
|
Rename RoomDependencies -> OnlinePlayDependencies
|
2021-06-25 18:07:47 +09:00 |
|
smoogipoo
|
04279e7f5c
|
Add some xmldocs
|
2021-06-25 18:02:53 +09:00 |
|
smoogipoo
|
7aefbe3da1
|
Move UserLookupCache inside dependencies
|
2021-06-25 17:37:02 +09:00 |
|
smoogipoo
|
aa5d22d04a
|
Remove "test container", make everything go through OnlinePlayTestScene
|
2021-06-25 13:02:19 +09:00 |
|